From: "Xueming(Steven) Li" <xuemingl@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Shahaf Shuler <shahafs@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add supported hash function check
Date: Thu, 22 Mar 2018 10:42:44 +0000 [thread overview]
Message-ID: <VI1PR05MB1678282C59F1A02ECA8E5FAEACA90@VI1PR05MB1678.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180319082949.6wezkieapgbn3dny@laranjeiro-vm.dev.6wind.com>
Just remind, denying unsupported hash function in rte_eth_dev_configure() might
impact some user app using PMD that simply ignoring them silently.
Testpmd command "port config <port> rss all" should be updated as well
to 'all' supported values from rte_eth_dev_info, I'll include this change in
next version.
> -----Original Message-----
> From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> Sent: Monday, March 19, 2018 4:30 PM
> To: Xueming(Steven) Li <xuemingl@mellanox.com>
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Shahaf Shuler
> <shahafs@mellanox.com>; dev@dpdk.org
> Subject: Re: [PATCH] net/mlx5: add supported hash function check
>
> On Sun, Mar 18, 2018 at 03:37:20PM +0800, Xueming Li wrote:
> > Add supported RSS hash function check in device configuration to have
> > better error verbosity for application developers.
> >
> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> > ---
> > drivers/net/mlx5/mlx5_ethdev.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> > b/drivers/net/mlx5/mlx5_ethdev.c index b73cb53..175a1ff 100644
> > --- a/drivers/net/mlx5/mlx5_ethdev.c
> > +++ b/drivers/net/mlx5/mlx5_ethdev.c
> > @@ -346,6 +346,14 @@ struct ethtool_link_settings {
> > rx_offloads, supp_rx_offloads);
> > return ENOTSUP;
> > }
> > + if (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf &
> > + MLX5_RSS_HF_MASK) {
> > + ERROR("Some RSS hash function not supported "
> > + "requested 0x%" PRIx64 " supported 0x%" PRIx64,
> > + dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf,
> > + (uint64_t)(~MLX5_RSS_HF_MASK));
> > + return ENOTSUP;
> > + }
> > if (use_app_rss_key &&
> > (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len !=
> > rss_hash_default_key_len)) {
> > --
> > 1.8.3.1
> >
>
> I would answer than an application should not try to configure something
> not advertise by the device.
> This information is present in struct rte_eth_dev_info returned by
> mlx5_dev_infos_get() and thus the devops of the device.
>
> Seems rte_eth_dev_configure() should be fixed to avoid configuring wrong
> values.
>
> Regards,
>
> --
> Nélio Laranjeiro
> 6WIND
next prev parent reply other threads:[~2018-03-22 10:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 7:37 Xueming Li
2018-03-19 8:29 ` Nélio Laranjeiro
2018-03-22 10:42 ` Xueming(Steven) Li [this message]
2018-03-26 11:39 ` Nélio Laranjeiro
2018-04-02 12:41 ` Xueming(Steven) Li
2018-04-04 7:35 ` Nélio Laranjeiro
2018-04-09 12:10 ` [dpdk-dev] [PATCH v1 1/2] ethdev: " Xueming Li
2018-04-16 22:56 ` Thomas Monjalon
2018-04-17 14:24 ` [dpdk-dev] [PATCH v2 " Xueming Li
2018-04-17 22:00 ` Thomas Monjalon
2018-04-18 11:55 ` Xueming(Steven) Li
2018-04-18 12:15 ` Thomas Monjalon
2018-04-17 14:24 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: only config supported RSS hash types Xueming Li
2018-04-18 8:11 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add supported hash function check Xueming Li
2018-04-18 8:11 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types Xueming Li
2018-04-18 11:06 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add supported hash function check Xueming Li
2018-04-18 11:06 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types Xueming Li
2018-04-18 13:25 ` Adrien Mazarguil
2018-04-18 13:54 ` Xueming(Steven) Li
2018-04-18 14:16 ` Adrien Mazarguil
2018-04-18 14:26 ` Xueming(Steven) Li
2018-04-18 14:47 ` Adrien Mazarguil
2018-04-18 14:10 ` Xueming(Steven) Li
2018-04-18 14:30 ` Adrien Mazarguil
2018-04-19 15:50 ` Xueming(Steven) Li
2018-04-19 15:48 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add supported hash function check Xueming Li
2018-04-20 8:10 ` Adrien Mazarguil
2018-04-19 15:48 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: new parameter for port config all rss command Xueming Li
2018-04-20 8:10 ` Adrien Mazarguil
2018-04-20 13:06 ` [dpdk-dev] [PATCH v5 1/2] ethdev: introduce generic IP/UDP tunnel checksum and TSO Xueming Li
2018-04-20 13:48 ` Ferruh Yigit
2018-04-20 14:23 ` Ferruh Yigit
2018-04-20 14:23 ` Xueming(Steven) Li
2018-04-20 13:06 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: testpmd support Tx generic tunnel offloads Xueming Li
2018-04-20 14:29 ` Xueming(Steven) Li
2018-04-20 14:30 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add supported hash function check Xueming Li
2018-04-20 14:35 ` Ferruh Yigit
2018-04-20 14:44 ` Xueming(Steven) Li
2018-04-23 15:20 ` Thomas Monjalon
2018-04-23 16:07 ` Ferruh Yigit
2018-04-23 16:06 ` Ferruh Yigit
2018-04-23 18:14 ` Thomas Monjalon
2018-05-01 11:04 ` Ferruh Yigit
2018-05-01 14:04 ` Thomas Monjalon
2018-04-20 14:30 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: new parameter for port config all rss command Xueming Li
2018-04-09 12:10 ` [dpdk-dev] [PATCH v1 2/2] app/testpmd: config all supported RSS functions Xueming Li
2018-04-16 22:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB1678282C59F1A02ECA8E5FAEACA90@VI1PR05MB1678.eurprd05.prod.outlook.com \
--to=xuemingl@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).