From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0060.outbound.protection.outlook.com [104.47.0.60]) by dpdk.org (Postfix) with ESMTP id D71521B65D; Mon, 29 Jan 2018 11:54:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3W0CCLLaShAYz+FXrbUgTwNncSiHeKj295/XaKtOVWM=; b=XSe8RhOKGimgRhwlOB7bY/YKWp9ZmAnPAgG3dSmC9mcP6Is6s7jOfydDv5SWX7F8ynXp+bumRmhcp3BtzTMyFSO6c2xixrj80cxsxrbJgeOizYIS4ojRE0skGgnSHKu1sGim5npazPZG7ygxJtoakS0YldGuKj3nCRYx6sNye60= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3246.eurprd05.prod.outlook.com (10.170.238.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Mon, 29 Jan 2018 10:54:16 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c%13]) with mapi id 15.20.0444.016; Mon, 29 Jan 2018 10:54:16 +0000 From: Shahaf Shuler To: Mordechay Haimovsky , Adrien Mazarguil CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] net/mlx4: fix dev rmv not detected after port stop Thread-Index: AQHTmNwMM7rTNxFmy0+XiB+ZCx6fu6OKrDrQ Date: Mon, 29 Jan 2018 10:54:16 +0000 Message-ID: References: <1516357009-15463-1-git-send-email-motih@mellanox.com> <1517214877-126768-1-git-send-email-motih@mellanox.com> In-Reply-To: <1517214877-126768-1-git-send-email-motih@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3246; 7:RrdV56Tw/hj4eyBfgK7AVZ5jugPVdQLGVKaj8BdsUgukVyGvKSTrZZHmOnHjTIPmGMK5xjs+r+M+bwsiLbFmchCRI86VQc96sotnjX34Q1SU0k44dkEKsQQL4dhMUS/jle1tbzV6ibgD6zBUKc7t1ge0QxbJ7TjmWrepXUKKCUUjieZAc5nwiILYBnAUMOGU2Lj90VfEFoegJUVJtUzbjEfdkt2IGRbtOBVl/hVMfL5BYsKc9RTB5+WsKFJSTMp7 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 70c07e9a-a0be-48bc-26e6-08d56706a434 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB3246; x-ms-traffictypediagnostic: VI1PR05MB3246: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231101)(944501161)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR05MB3246; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB3246; x-forefront-prvs: 0567A15835 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(376002)(346002)(366004)(39860400002)(189003)(199004)(54906003)(4326008)(81156014)(8676002)(8936002)(102836004)(7696005)(76176011)(2900100001)(105586002)(106356001)(110136005)(316002)(25786009)(478600001)(6246003)(66066001)(6506007)(99286004)(14454004)(305945005)(6436002)(3846002)(6116002)(7736002)(229853002)(2950100002)(81166006)(5250100002)(5660300001)(86362001)(2906002)(74316002)(55016002)(9686003)(53936002)(3280700002)(97736004)(3660700001)(26005)(33656002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3246; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: WBwh3J2kTwSFfItUV12IhrAfXMjlAs8Fiq1wsFbCoRCMHimg20VzRgRPz5KzZNO5+pKPN/oFmKdnIX6NLmp2Mg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70c07e9a-a0be-48bc-26e6-08d56706a434 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2018 10:54:16.2736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3246 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 10:54:19 -0000 Mordechay Haimovsky, Monday, January 29, 2018 10:35 AM: > In failsafe device start can be called for ports/devices that had been pl= ugged > out. > The mlx4 PMD detects device removal by listening to the device RMV events= , > when the mlx4 port is being stopped, the PMD no longer listens to these > events causing the PMD to stop detecting device removals. > This patch fixes this issue by moving installation of the interrupt handl= er to > device configuration, and toggle only the Rx-queue interrupts on start/st= op. >=20 > Fixes: a6e8b01c3c26 ("net/mlx4: compact interrupt functions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Moti Haimovsky > --- > V3: > Modifications according to review inputs from Shahaf Shuler > See: 1516357009-15463-1-git-send-email-motih@mellanox.com >=20 > V2: > Fixed commit message. > --- >=20 > drivers/net/mlx4/mlx4.c | 10 ++++++++-- > drivers/net/mlx4/mlx4.h | 2 ++ > drivers/net/mlx4/mlx4_intr.c | 41 > ++++++++++++++++++++++++++++++++++++++--- > 3 files changed, 48 insertions(+), 5 deletions(-) >=20 Acked-by: Shahaf Shuler =20 Adrien - let me know if you see issues with this patch, I want to include i= t on RC2.