From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20042.outbound.protection.outlook.com [40.107.2.42]) by dpdk.org (Postfix) with ESMTP id 491442C2E; Mon, 15 Jan 2018 07:45:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yAyvPH5UXeyhwoUTyLWSKJmV+i0NGEs54Q5AbL3jkT0=; b=cecGh6f4G7Y8sydLgzBxLzHlrR3SrL3qB88U8shsTcipqdhtRIn4AlHzSn2WQJUt/8wV6sBbT1VO9GMZoJ8zkgchqp87gMubynYFuLrV/u2GEvSGDnwiDHKpQcsEi2frMoj4AzpCX2bo17ZfZFaGSDXRFDqab+6IYUUwL2V5SHA= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1901.eurprd05.prod.outlook.com (10.166.44.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 06:45:41 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0407.009; Mon, 15 Jan 2018 06:45:41 +0000 From: Shahaf Shuler To: Yongseok Koh , Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: "dev@dpdk.org" , Yongseok Koh , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH] net/mlx5: fix deadlock of link status alarm Thread-Index: AQHTijsLx4Qz2Mp4wkaie+CXGRZWaKN0hE0g Date: Mon, 15 Jan 2018 06:45:41 +0000 Message-ID: References: <20180110174649.33662-1-yskoh@mellanox.com> In-Reply-To: <20180110174649.33662-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1901; 7:W8uZz8BrZz5bBo359QNFDhFajJf8IvkMeo1TDxrgm19fEB5kbN4WIhovFHkxmRpx8iparr9//HnOn0gc6XNeWJoJl1ydaGnieVYLuCd0WgeSC6CBeI/6fnk8qKnX0eqwhMRzOapP2dAa/dLMBiP5GB+F9I1JQ+asbipiUqtX+lJ151Q1+9dChNUFVPBYvN+eAOnM9TZXUiCPR/7TOxQVjvRJHNyoRtdYjWYxNXHBe6ulzWbHfyijUY/srDmG2BGa x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8f8652c5-5442-4694-e763-08d55be39877 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1901; x-ms-traffictypediagnostic: VI1PR05MB1901: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(10201501046)(3231023)(944501161)(3002001)(93006095)(93001095)(6055026)(6041268)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR05MB1901; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB1901; x-forefront-prvs: 0553CBB77A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(396003)(39860400002)(366004)(376002)(199004)(189003)(6436002)(6506007)(229853002)(110136005)(54906003)(6246003)(5660300001)(55016002)(9686003)(76176011)(53936002)(7696005)(4326008)(97736004)(2950100002)(102836004)(59450400001)(86362001)(25786009)(99286004)(316002)(14454004)(2906002)(8936002)(74316002)(7736002)(305945005)(68736007)(8676002)(3660700001)(81156014)(3846002)(6116002)(81166006)(33656002)(478600001)(66066001)(3280700002)(2900100001)(106356001)(5250100002)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1901; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 6Q+Y+8/2MweiApib3Xz+hWJSHaXXbwEFEx6xBRi4w8NHk9RImJqJ5/u6VZ+Fw/sTl7RPrYhUKKfVIrbOjVWN7A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f8652c5-5442-4694-e763-08d55be39877 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2018 06:45:41.5241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1901 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix deadlock of link status alarm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 06:45:43 -0000 Wednesday, January 10, 2018 7:47 PM, Yongseok Koh: > If mlx5_dev_link_status_handler() is executed while canceling the alarm, > deadlock can happen because rte_eal_alarm_cancel() waits for all callback= es > to finish execution and both calls are protected by priv->lock. >=20 > Fixes: 198a3c339a8f ("mlx5: handle link status interrupts") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh > Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5.h | 16 ++++++++++++++++ > drivers/net/mlx5/mlx5_ethdev.c | 13 +++++++++---- > 2 files changed, 25 insertions(+), 4 deletions(-) >=20 Applied to next-net-mlx, thanks.=20