From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0079.outbound.protection.outlook.com [104.47.1.79]) by dpdk.org (Postfix) with ESMTP id D82D31B01B for ; Tue, 9 Jan 2018 11:07:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KA76uO7T5n0aTLRseu/GMkoGaWeIs4TpegrWTkGosqk=; b=YqURrH3Td4fSpEZNsHYWcwPdojJg6dG99bK/JYvhoyCQ/mCRHcG3hYG3Rhj5B5al6xEfFpBNtfqCaUhSB/n3rxnqE5TAwzU86NOuH7GGcIhN9QPbJmZgu09ulxy6rFu8m58AhicN309V82SU60Bs7fP72K1qHsYODvt1jvaHrFo= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3151.eurprd05.prod.outlook.com (10.170.237.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Tue, 9 Jan 2018 10:07:35 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0386.009; Tue, 9 Jan 2018 10:07:35 +0000 From: Shahaf Shuler To: "Lu, Wenzhuo" , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags Thread-Index: AQHTfi5tvVoy4fi3002rpF85JEFJzqNrN20AgAAuyOA= Date: Tue, 9 Jan 2018 10:07:35 +0000 Message-ID: References: <079c2831ae6d80d105d7faf548a5683d965459e1.1514281260.git.shahafs@mellanox.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B70C54B@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C54B@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3151; 7:nEKN/SU+Y/b0o0wujTKUBOtUbWQVpmEWuCWHnkInK7J/l2ZAlRxA6PdwpjobMUiTsbCY0HeLKcUitBaKQ8bEu11ERwGXE2G737rqdx7MSbBvc0dcVs7MFeiw8MqsDHhoM3ctdwxfnYKPOI7nf2NZCUSZAjRtihidrQAmvIp4jhvmYAx/Bzy5HNNn3kTg24RsRcxeXgA/zaKLrHJ6cxkE/4sMZC0Adiq6FS+ukwh4LzAH+aJEUBuiCyRIIp4qGu53 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8296dc6c-7766-4824-3942-08d55748ce50 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB3151; x-ms-traffictypediagnostic: VI1PR05MB3151: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(944501075)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR05MB3151; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB3151; x-forefront-prvs: 0547116B72 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(39380400002)(366004)(39860400002)(346002)(199004)(189003)(13464003)(97736004)(305945005)(5660300001)(3846002)(6116002)(6246003)(2900100001)(74316002)(68736007)(5250100002)(478600001)(7736002)(86362001)(25786009)(3660700001)(2906002)(99286004)(105586002)(8676002)(110136005)(6506007)(53546011)(7696005)(106356001)(8936002)(76176011)(14454004)(316002)(81156014)(81166006)(53936002)(9686003)(2950100002)(102836004)(33656002)(6436002)(229853002)(4326008)(3280700002)(55016002)(66066001)(93886005)(129583001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3151; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 77p/ieZWvKsPksP9/PONWs1FZKwjEPfnHT15rUl7YDpr4iC3eeceFZxdaVATIOblnWbvzaU3BIQmy3O4ld9gkA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8296dc6c-7766-4824-3942-08d55748ce50 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2018 10:07:35.2794 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3151 Subject: Re: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 10:07:37 -0000 Tuesday, January 9, 2018 9:17 AM, Lu, Wenzhuo: --Shahaf > -----Original Message----- > From: Lu, Wenzhuo [mailto:wenzhuo.lu@intel.com] > Sent: Tuesday, January 9, 2018 9:17 AM > To: Shahaf Shuler ; Wu, Jingjing > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags >=20 > Hi Shahaf, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > > Sent: Tuesday, December 26, 2017 5:44 PM > > To: Wu, Jingjing ; Yigit, Ferruh > > > > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v3 08/10] app/testpmd: remove txqflags > > > > Since testpmd is now using the new Ethdev offloads API and there is a > > way configure each of the tx offloads from CLI or command line, there > > is no need for the txqflags configuration anymore. > > > > Signed-off-by: Shahaf Shuler > > Acked-by: Nelio Laranjeiro >=20 >=20 > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > 806548196..91dcb31c0 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -259,11 +259,6 @@ int16_t tx_free_thresh =3D > RTE_PMD_PARAM_UNSET; > > int16_t tx_rs_thresh =3D RTE_PMD_PARAM_UNSET; > > > > /* > > - * Configurable value of TX queue flags. > > - */ > > -int32_t txq_flags =3D RTE_PMD_PARAM_UNSET; > > - > > -/* > > * Receive Side Scaling (RSS) configuration. > > */ > > uint64_t rss_hf =3D ETH_RSS_IP; /* RSS IP by default. */ @@ -2084,9 > > +2079,6 @@ rxtx_port_config(struct rte_port *port) > > > > if (tx_free_thresh !=3D RTE_PMD_PARAM_UNSET) > > port->tx_conf.tx_free_thresh =3D tx_free_thresh; > > - > > - if (txq_flags !=3D RTE_PMD_PARAM_UNSET) > > - port->tx_conf.txq_flags =3D txq_flags; > I think we have some problem if just remove this code. Because port- > >tx_conf.txq_flags is used by many NICs. If txqflags is removed, all thes= e > NICs have to use the default value and have no chance to change it. I th= ink > it's a good idea to use tx-offloads to replace txqflags, but we may need = to > clear the drivers' code first. There is an internal function in ethdev which do translation from the Tx of= floads to the txqflags. Checkout ``rte_eth_convert_txq_offloads``. This is specifically to support PMDs which still use the old offloads API.= =20 So in fact application needs only to specify the Tx offloads on the tx_conf= and those will be converted to txqflags. The PMD see no difference.=20