From: Shahaf Shuler <shahafs@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Nicolau, Radu" <radu.nicolau@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix IPsec Rx with SSE on
Date: Tue, 31 Oct 2017 18:51:48 +0000 [thread overview]
Message-ID: <VI1PR05MB31493ABAE84CAF2627D3B2B7C35E0@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <0cb51041-aedb-ff33-6787-adf301e19c54@intel.com>
Tuesday, October 31, 2017 7:16 PM, Ferruh Yigit:
> On 10/31/2017 8:47 AM, Ananyev, Konstantin wrote:
> >
> >
> >> -----Original Message-----
> >> From: Nicolau, Radu
> >> Sent: Friday, October 27, 2017 2:25 PM
> >> To: dev@dpdk.org
> >> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Nicolau, Radu
> >> <radu.nicolau@intel.com>
> >> Subject: [PATCH] net/ixgbe: fix IPsec Rx with SSE on
> >>
> >> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") And small
> >> performance improvement
> >>
> >> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
It looks this commit breaks the compilation with GCC on redhat 7.3.
Server details:
4.13.0-rc4+ #1 SMP Wed Aug 9 09:18:48 IDT 2017 x86_64 x86_64 x86_64 GNU/Linux
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)
Compilation log:
Configuration done using x86_64-native-linuxapp-gcc
/work/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c: In function ‘desc_to_olflags_v_ipsec’:
/work/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:140:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
rearm = _mm_set_epi32(((uint32_t *)rx_pkts[0]->rearm_data)[2],
^
/work/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:141:10: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
((uint32_t *)rx_pkts[1]->rearm_data)[2],
^
/work/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:142:10: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
((uint32_t *)rx_pkts[2]->rearm_data)[2],
^
/work/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:143:10: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
((uint32_t *)rx_pkts[3]->rearm_data)[2]);
^
/work/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:154:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
((uint32_t *)rx_pkts[0]->rearm_data)[2] = _mm_extract_epi32(rearm, 3);
^
/work/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:155:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
((uint32_t *)rx_pkts[1]->rearm_data)[2] = _mm_extract_epi32(rearm, 2);
^
/work/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:156:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
((uint32_t *)rx_pkts[2]->rearm_data)[2] = _mm_extract_epi32(rearm, 1);
^
/work/dpdk.org/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c:157:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
((uint32_t *)rx_pkts[3]->rearm_data)[2] = _mm_extract_epi32(rearm, 0);
^
cc1: all warnings being treated as errors
make[4]: *** [ixgbe_rxtx_vec_sse.o] Error 1
make[3]: *** [ixgbe] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [net] Error 2
make[1]: *** [drivers] Error 2
make: *** [all] Error 2
next prev parent reply other threads:[~2017-10-31 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 13:24 Radu Nicolau
2017-10-31 15:47 ` Ananyev, Konstantin
2017-10-31 17:15 ` Ferruh Yigit
2017-10-31 18:51 ` Shahaf Shuler [this message]
2017-11-01 11:28 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2017-11-01 20:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB31493ABAE84CAF2627D3B2B7C35E0@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).