From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00067.outbound.protection.outlook.com [40.107.0.67]) by dpdk.org (Postfix) with ESMTP id 08540377A; Thu, 23 Nov 2017 14:00:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1OSV0Sh6FQ5dPcqRm+kyxL2bUM+jVQ22ItpWAPjl7xI=; b=iZ09ZO3Kze/KtvdnP/SceTq8lAYyqC3HICqT56tXni5I7TGXqtbWBW5LV6IkugnVp6SZMGVDtxe8PPKqBJCMLccRmDL7uV0VJvAZaKokeG8Bw6wfrxfpF8xfOLv5FVu79wH+Zf9jdh/ZKVHOAo2HTgBqKKxaPyoaianaG2/h0qQ= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3150.eurprd05.prod.outlook.com (10.170.237.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.239.5; Thu, 23 Nov 2017 13:00:31 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::195e:382c:dacf:b291]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::195e:382c:dacf:b291%13]) with mapi id 15.20.0218.017; Thu, 23 Nov 2017 13:00:31 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Thierry Herbelot" CC: "dev@dpdk.org" , Adrien Mazarguil , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: cleanup the allocation of the buffer used for the ethtool stats Thread-Index: AQHTXvjka/15wHiubk+IfIf3w/LA66MYNMoAgAnB/EA= Date: Thu, 23 Nov 2017 13:00:31 +0000 Message-ID: References: <20171117075500.bgusljznteuhwdo2@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20171117075500.bgusljznteuhwdo2@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3150; 6:wDfhlxjoeMe8ccyQWnF0AVwKf63gncP8MFI8X74Do857Yu6HvjVNZtmyRF7JRP/8qcomLvQ/PcwnW4ZVNuGIfySb3zycwhCbh7GGErV6COfpzhCVhgFcf3cJvBjMfRT+zczi/jqKb6iM6H+hnNdr59j5x9GIzd64yw+FZbRwSYsOnOFrlILAbLsAaJwJz3YMPUqCXExASD9yVf6JarVn7dgA5y7/TT1Pd6/BKEwkDI3mgF29UaLjK/FQL+Km+PXxw25XpqC7hEdAwUiQG4c79DmpUfV3lgNoKADMieenJDWFmScGJ6LvPq+MGgevMuurSOHhDdFWJVt7mzm9bfUcVjSEutgQ9iXWLe4/EJSw1Jg=; 5:B7cC9y6wRXfurEBPw7QfLE308+2m9697CbsuhjOQ6KJfBwDG5iVs6CTt2D12QGnrZ0873pMMxcC3MdV3KRFLmCtpfxb9Dzp1lQ6TlNI27JkvPGBcUXNEGgs/kcT8XePYZwxk5VCzAOg4hZzJicyEuWjNP6A/+JyVdayLZGgpI+Q=; 24:ct2lXX+RT/wdsOo11u/Rj9W6+oNIJuiWl31e4E2hgaDG7grG8J3qf/FW5YReFpZhGlC31+4eJRoAc2+EB+5RTi28vnORZGorEmXoRJ66/s4=; 7:60ee69ZpW0ga6+BzgyQinHLgRLu1EnxhsQVYAAlLurt8pTY/UjxksjSkEx52AjZjXWK5+WheupVW7WC46VjZzK2qXlhJiU7pKIjHLWJK437vojoiZuUMmacR8A9pA1rxOGdm0LJCbepe7lxPrkV8KruUbSU+2NS7njS7A8J1askDP+8rIccOJ6EFDZ6+hYJnCsAJw7gimIX4v7NfDF5Kwoi63zXtGZbmcTDGcl4x90M1euXE3MB0YyXTXEK+jMQU x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a0d7178e-7cf3-4e3b-ade9-08d532722d8b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600025)(4604075)(2017052603258); SRVR:VI1PR05MB3150; x-ms-traffictypediagnostic: VI1PR05MB3150: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(3231022)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(20161123562025)(20161123558100)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB3150; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB3150; x-forefront-prvs: 05009853EF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(6009001)(346002)(376002)(366004)(39860400002)(189002)(199003)(99286004)(4326008)(3846002)(25786009)(8676002)(9686003)(97736004)(229853002)(305945005)(316002)(7736002)(110136005)(54906003)(55016002)(74316002)(6116002)(189998001)(102836003)(478600001)(68736007)(6246003)(33656002)(2950100002)(14454004)(3660700001)(66066001)(5660300001)(6506006)(5250100002)(81166006)(53936002)(7696004)(106356001)(8936002)(2906002)(76176999)(50986999)(54356999)(6436002)(86362001)(2900100001)(101416001)(3280700002)(105586002)(81156014)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3150; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0d7178e-7cf3-4e3b-ade9-08d532722d8b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2017 13:00:31.3801 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3150 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: cleanup the allocation of the buffer used for the ethtool stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 13:00:33 -0000 Hi Thierry Friday, November 17, 2017 9:55 AM, Nelio Laranjeiro: > > 2.11.0 >=20 > Acked-by: Nelio Laranjeiro Am having the following check-git-log errors: Headline too long: net/mlx5: cleanup the allocation of the buffer used for the ethtool= stats Wrong tag: Fixes: a4193ae3bc4f ('net/mlx5: support extended statistics') Wrong 'Fixes' reference: Fixes: a4193ae3bc4f ('net/mlx5: support extended statistics') Is it candidate for Cc: stable@dpdk.org backport? net/mlx5: cleanup the allocation of the buffer used for the ethtool= stats is the below suggestion[1] acceptable? If so I will merge into next-net-mlx [1] Author: Thierry Herbelot Date: Fri Nov 17 14:51:34 2017 +0100 net/mlx5: cleanup allocation of ethtool stats =20 Simplify the computation for the needed size: - exact size for the structure header, - exact size for a number of 64-bit counters. =20 Fixes: a4193ae3bc4f ("net/mlx5: support extended statistics") Cc: stable@dpdk.org =20 Signed-off-by: Thierry Herbelot Acked-by: Nelio Laranjeiro >=20 > Thanks, >=20 > -- > N=E9lio Laranjeiro > 6WIND