* [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for outer IP
@ 2018-01-03 8:06 Yongseok Koh
2018-01-03 8:29 ` Nelio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2018-01-03 8:06 UTC (permalink / raw)
To: adrien.mazarguil, nelio.laranjeiro; +Cc: dev, Yongseok Koh, stable
Checking HW checksum offload flag for outer IP is missing. If flag is set
for only outer IP, this can't be set properly.
Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel packets")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index e70d52361..90f129168 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
@@ -636,7 +636,8 @@ txq_ol_cksum_to_cs(struct mlx5_txq_data *txq_data, struct rte_mbuf *buf)
/* Should we enable HW CKSUM offload */
if (buf->ol_flags &
- (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM)) {
+ (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM |
+ PKT_TX_OUTER_IP_CKSUM)) {
if (txq_data->tunnel_en &&
(buf->ol_flags &
(PKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN))) {
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for outer IP
2018-01-03 8:06 [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for outer IP Yongseok Koh
@ 2018-01-03 8:29 ` Nelio Laranjeiro
2018-01-07 14:13 ` Shahaf Shuler
0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2018-01-03 8:29 UTC (permalink / raw)
To: Yongseok Koh; +Cc: adrien.mazarguil, dev, stable
On Wed, Jan 03, 2018 at 12:06:22AM -0800, Yongseok Koh wrote:
> Checking HW checksum offload flag for outer IP is missing. If flag is set
> for only outer IP, this can't be set properly.
>
> Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel packets")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
> index e70d52361..90f129168 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.h
> +++ b/drivers/net/mlx5/mlx5_rxtx.h
> @@ -636,7 +636,8 @@ txq_ol_cksum_to_cs(struct mlx5_txq_data *txq_data, struct rte_mbuf *buf)
>
> /* Should we enable HW CKSUM offload */
> if (buf->ol_flags &
> - (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM)) {
> + (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM |
> + PKT_TX_OUTER_IP_CKSUM)) {
> if (txq_data->tunnel_en &&
> (buf->ol_flags &
> (PKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN))) {
> --
> 2.11.0
>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for outer IP
2018-01-03 8:29 ` Nelio Laranjeiro
@ 2018-01-07 14:13 ` Shahaf Shuler
0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2018-01-07 14:13 UTC (permalink / raw)
To: Nélio Laranjeiro, Yongseok Koh; +Cc: Adrien Mazarguil, dev, stable
Wednesday, January 3, 2018 10:30 AM, Nelio Laranjeiro:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for
> outer IP
>
> On Wed, Jan 03, 2018 at 12:06:22AM -0800, Yongseok Koh wrote:
> > Checking HW checksum offload flag for outer IP is missing. If flag is
> > set for only outer IP, this can't be set properly.
> >
> > Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for
> > tunnel packets")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> > Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to next-net-mlx, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-07 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-03 8:06 [dpdk-dev] [PATCH] net/mlx5: fix HW checksum offload for outer IP Yongseok Koh
2018-01-03 8:29 ` Nelio Laranjeiro
2018-01-07 14:13 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).