From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10081.outbound.protection.outlook.com [40.107.1.81]) by dpdk.org (Postfix) with ESMTP id 0218A1B024 for ; Tue, 9 Jan 2018 11:02:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qLljimwiBZXNmcNwWwfuvr9w8PynVF3xt3OLRpsRC6I=; b=evBIO6xrKh9YB4Bx0djT0Mw6xtL25KU1RJ8XmIJQU38DMcgW24n+Nvu7zgh8Vp03dTztEGMw1yJAd+DY80qiNVL3mEGML29XEVX3tIYRfGCaHwYkPAqYWxCRyFSVwKdMQ22yMXr27CkVetYHQq/pZWx0xrXcqWB3F/c2Cpe0mc8= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3151.eurprd05.prod.outlook.com (10.170.237.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Tue, 9 Jan 2018 10:02:22 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0386.009; Tue, 9 Jan 2018 10:02:22 +0000 From: Shahaf Shuler To: "Lu, Wenzhuo" , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API Thread-Index: AQHTfi5PlcAuFUYAJ0GqcKAnlfCYXqNrGMaAgAAUHhCAAAmSAIAALXiQ Date: Tue, 9 Jan 2018 10:02:22 +0000 Message-ID: References: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C42F@shsmsx102.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B70C530@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C530@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3151; 7:5vL9lU/Esef4vDjCMYalhwtTa5uvSKcWADBai0j9xkmd1GcRUdzzHICtXmCkVI284uOoRRTNYcqPZKIBg68kVQYOsh9lkLi7EMjYIYRHJfTr8Zj4veA5Lcaz7PhvRn0COjf/06bGwnSZHY1in3qqmkL04WVruY9jXOQ3Z9gu1W7uvB4ErnYQfZ/RqnuSEQ0JQ+Q2CURCr0mvP9XCDIp+j1r6wV6y3U3tF2WPzLRV9DwZ49jC7Xg7FXzUDK5jWm2T x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b35d5204-92e9-409d-1aeb-08d5574813bd x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB3151; x-ms-traffictypediagnostic: VI1PR05MB3151: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(944501075)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR05MB3151; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB3151; x-forefront-prvs: 0547116B72 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(39380400002)(366004)(39860400002)(346002)(199004)(189003)(97736004)(305945005)(5660300001)(3846002)(6116002)(6246003)(2900100001)(74316002)(68736007)(5250100002)(478600001)(7736002)(86362001)(25786009)(3660700001)(2906002)(99286004)(105586002)(110136005)(6506007)(59450400001)(7696005)(106356001)(8936002)(76176011)(14454004)(316002)(81156014)(81166006)(53936002)(9686003)(2950100002)(102836004)(33656002)(6436002)(229853002)(4326008)(3280700002)(55016002)(66066001)(93886005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3151; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: F6/jA8Au5xe0c+Vrrmh9x6jPt9gH6L+n+FR46xZLEpIRct77f1JCh4gs5Ngsde2yDnvZoiO5WO51ezzIbo1HVg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b35d5204-92e9-409d-1aeb-08d5574813bd X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2018 10:02:22.2902 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3151 Subject: Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 10:02:31 -0000 Tuesday, January 9, 2018 9:14 AM, Lu, Wenzhuo: > > The original code doesn't have such restriction because testpmd wasn't > > configuring Tx offloads at all. It used it's own Tx offloads enum > > (which I removed on later patches) to indicate which offloads is set. > > From the device perspective all the Tx offloads should be set. > > It did had a way to configure offloads with txqflags parameter, but > > this required queues reconfigurations. > ' cmd_tx_vlan_set_parsed' is the function which configures TX vlan insert= ion. > This patch adds the restriction in it. > For example, on ixgbe it does support on the fly configuration. APP doesn= 't > need to stop the device or reconfigure the queues. What is mean is that in the old offloads API, all the Tx offloads were enab= led by default, besides the ones which were masked with txqflags. This is why testpmd didn't have any limitation on changing the Tx offloads.= All of them were enabled, it just needed to choose with which one to use. Now, with the new offloads API, the Tx offloads are disabled by default, an= d enabled per application need on device and queue configuration. In order to call device/queue configuration the port must be stopped. This = is requirement from ethdev API. Now, there is an API in ethdev to configure Rx VLAN offloads on the flight = for supported devices. If there are devices which supports it also in the Tx side, and you see a g= ood use case for that, then need to think of new API in ethdev to configure= Tx VLAN offloads on the flight. However, the plain conversion of testpmd from the old to the new API requir= es the port to be stopped for all of the Tx offloads.=20