From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00074.outbound.protection.outlook.com [40.107.0.74]) by dpdk.org (Postfix) with ESMTP id C14321B284 for ; Thu, 21 Dec 2017 14:47:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6Fra1+jM7kHl02hXZwzcS2Qu5SCWZVXcMpE2POEMqEc=; b=GiGeuMrC5JoMuU/CMRSXj3lP5HRJB8vpQ2hmkKnARWYdARknkHHlQpBQ6yW0LL/0tnbprf4Ag4nznBEXqz76+RSK+WqDuhraJNu0JdHZnPPY5T1LfRIN4pYzY3WYgFFHHCiyjj23cDrUMaHgtvH+X9daETbdkOYK8x2mg76jd0w= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3152.eurprd05.prod.outlook.com (10.170.237.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Thu, 21 Dec 2017 13:47:12 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::355f:857b:fdfd:afd9]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::355f:857b:fdfd:afd9%13]) with mapi id 15.20.0323.018; Thu, 21 Dec 2017 13:47:12 +0000 From: Shahaf Shuler To: "De Lara Guarch, Pablo" , "dev@dpdk.org" , "Ananyev, Konstantin" , "Nicolau, Radu" , "arybchenko@solarflare.com" Thread-Topic: [dpdk-dev] [PATCH v2 03/39] examples/l2fwd-jobstats: convert to new ethdev offloads API Thread-Index: AQHTc0SpBhvxWwEQd0quqb4dy6fff6NKpI8AgAM48wA= Date: Thu, 21 Dec 2017 13:47:12 +0000 Message-ID: References: <20171123121419.144132-1-shahafs@mellanox.com> <7ddb1ea46013dad991a4330a5c22a90c2c54064a.1513081087.git.shahafs@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3152; 6:Yui87Q6ee7nQDkgmCSkG1CEYEJ8tb56hHddzJPtCHn4dk4rIS7Zk7L21wURQVodGsFv4JNEf6GN4B2tKD2XNNz3ucqcJWMzzFJzff9ZVkTo95EtgHOKCeL/uJUEEe/CrBMaf27R8CN0c7dp74VTk9kAr8DEJ0WH9N/mLfllVeTKD6TFTqORSBlvwvO6Prm6KmCKkBHRjUR+yeOgjpigsTncMUAMdc6uazBj7gkQLmFlrdOyB1pe1KcfofmItwx66p/lMj5J3rPjw+KZcnxWS/FU7OtOzd+D/utjxrk9kVtrjjDevOSAUihhafwM5MWTzutdAG4AoE4LvI95Sw+Zr+7hezCMSpdyg4MIaUyZgLLM=; 5:hFVrtY57pVJQjrum6w0uvxyKKAaEoJsqKLaiqRCTPUY03fhvH44XIRa831ge5nO+hsuSHeI663XZSkYL9X93HVyUBww0kCpqVM0Azjt27gTlyGHCaitRsrupDFw6TgrXZscZsQkI8Toz0+3zpXG3OZEAwPJFNG2kxB6M7kEt6HE=; 24:eSvthA8WRbDJ4pIm1hpCH2Afq7QLt88PcpAc7XpYbCVELnHYnWovtQvpp8rp43sJ31suoIGPglja01rkghTrFbFOeJC7fwpmb+n+5d017ss=; 7:UqDQeqmwYPkHXxby9fk7E3X6TMKe3L1nqiXoJMSNlglCzTRrl190nhdpF4zMCq/yuQBFTGslXu4GKomttOiJBc6PdRssk3gbQiIdsEIwPtI/J7dW5vYrpUwrFkOO8YJHOG69pmMjFXQakG0owG7Ev8FON13toN4f7hHJbCtS7QdRbbZIPCmnxPERPiLtmwwqG3qvzKlXm2oQOFVazcoOdkn/twrQE5m0iHMb4vU3jDGblVoaR2BgU7kgkAojkR7n x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c3b040fa-fe53-4b62-975c-08d5487956c9 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008031)(2017052603307)(7153060); SRVR:VI1PR05MB3152; x-ms-traffictypediagnostic: VI1PR05MB3152: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231023)(3002001)(6055026)(6041268)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR05MB3152; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB3152; x-forefront-prvs: 0528942FD8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(376002)(346002)(366004)(396003)(189003)(199004)(43544003)(99286004)(8936002)(105586002)(478600001)(106356001)(76176011)(2950100002)(81166006)(7736002)(25786009)(93886005)(33656002)(81156014)(9686003)(6506007)(2906002)(5660300001)(97736004)(6436002)(14454004)(6116002)(55016002)(53936002)(2900100001)(2501003)(66066001)(316002)(5250100002)(74316002)(86362001)(305945005)(68736007)(3660700001)(6246003)(110136005)(3280700002)(229853002)(7696005)(3846002)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3152; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3b040fa-fe53-4b62-975c-08d5487956c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2017 13:47:12.5372 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3152 Subject: Re: [dpdk-dev] [PATCH v2 03/39] examples/l2fwd-jobstats: convert to new ethdev offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 13:47:14 -0000 Tuesday, December 19, 2017 2:33 PM, De Lara Guarch, Pablo: >=20 > There is a compilation error when building for 32-bit targets: >=20 > examples/l2fwd-jobstats/main.c:883:11: error: format '%lx' expects > argument of type 'long unsigned int', but argument 3 has type 'uint64_t {= aka > long long unsigned int}' > [-Werror=3Dformat=3D] > printf("Some Rx offloads are not supported " > ^ > examples/l2fwd-jobstats/main.c:883:11: error: format '%lx' expects > argument of type 'long unsigned int', but argument 4 has type 'uint64_t {= aka > long long unsigned int}' > [-Werror=3Dformat=3D] > examples/l2fwd-jobstats/main.c:890:11: error: format '%lx' expects > argument of type 'long unsigned int', but argument 3 has type 'uint64_t {= aka > long long unsigned int}' > [-Werror=3Dformat=3D] > printf("Some Tx offloads are not supported " > ^ > examples/l2fwd-jobstats/main.c:890:11: error: format '%lx' expects > argument of type 'long unsigned int', but argument 4 has type 'uint64_t {= aka > long long unsigned int}' > [-Werror=3Dformat=3D] >=20 > This happens on all the apps (I acked the first two apps, since I missed = this > issue when I was reviewing them). Thanks, will take care.=20 In fact am thinking of removing those prints, they don't seems necessary. T= he PMD can print error/warn log in case of bad offloads configuration.=20 >=20 > Thanks, > Pablo