From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10084.outbound.protection.outlook.com [40.107.1.84]) by dpdk.org (Postfix) with ESMTP id B9B0F31FC for ; Thu, 18 Jan 2018 07:32:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CoGI8UsYK66pFZEhY1iUHXRfE7w82Wx097sKo18Xtbw=; b=MbQicrPYLJmcXVJBA83UZF8WSpt802TTTXoOoj38hPMDEWbuTs/cwpziX+9c53CG9RTbwmkf5LWOwjqfz3K+mZg/fX9Hxm3KPJSrJnKcrX+S3TJvwMFs3/qBTm29cRsDZXthKjQti+E+ycGD0JCC7+6FW3lQwiqw4lt70gSpZH8= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1773.eurprd05.prod.outlook.com (10.165.236.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Thu, 18 Jan 2018 06:32:36 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0407.012; Thu, 18 Jan 2018 06:32:36 +0000 From: Shahaf Shuler To: Thomas Monjalon , Andrew Rybchenko , Ivan Malov CC: "dev@dpdk.org" , Ferruh Yigit Thread-Topic: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names Thread-Index: AQHTirQOVUVo4QIhREiMosRtRukC6aN4XSaAgADZioA= Date: Thu, 18 Jan 2018 06:32:36 +0000 Message-ID: References: <1515658359-1041-1-git-send-email-arybchenko@solarflare.com> <1515658359-1041-2-git-send-email-arybchenko@solarflare.com> <1871861.OTzHAPg5Oj@xps> In-Reply-To: <1871861.OTzHAPg5Oj@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1773; 6:WlOAjwz3/xdMScL4Jdg9MnbndpMceZedy814EjRr+bcDrJhPj+5T2HIKr2mM2JRbQyTAHr8a+9nRWyJI19BahgnG4WoDJ4dtIFHXelb0U8VHiTZIe8AkBEiu+p2Wt/ihF8Pz7JtAPV3JgmR35JcN5wyEscJDeDYrQ7tehVgy12loB7Uf0caYQjWHcNzVSNvESrrwVLwexYOrm5kdcyTNvaueWNuTUISWRymJPsmTIsAeNeHZhTTiDwUEERXOzUjpWsQkallLGJBu1FfDgZ5aJolEXSkJB1mTvnceRt4z5LgCNtfYY58zIIeCCMS4TfG1YwxSUtEz9vcBR/dRLlE7vtW7sjTZLu571SiIhnTcHYzHgtk9vHJ7bhQmTloXj7sX; 5:ABsye+K+200nZo3Ce/imi1GRnmzoCH+OfQWtD3meGhjk5fb8ZWe00t6P4PqSYmZgVqr9H2qInv7hl1dIJ0DrkFJ25Noekp+Ve6sh/vkQAH2WW/T4ERwbDvLSeEG5o3Cw32s7/2/GVieJs5tZ0yR+NO8gHI4rhlsl9JowGrRqnVQ=; 24:jFbosQJgVfuygSvfWZsJz/9/OQz2sVstsw3NPILXZ00lDz4S6r20NsMErYoNVdHKzQH8v4hDJ98VtHnrrsDO0+/EXZ5OGvRmr/bTsQf5YkM=; 7:FNGF61ESXeRRdqdKwsTKRMbgJuFfJ43Oo4DQajoMNSvtxZh7i1vj3SuuXQH+RQnuZ1S8TqlmUUnX/aBjzXbLVsJFHQ63PJNRgfJiM3xVhStqOmx7EZJ6EBB2pBg0eGzd7SMA9G2vNBD2vcn1x6P7g7sU8OuWbqNhgDcgHhcQYD+ucT3ep6/ndGyBElGIhaYwJTr74LtxYpvvAZzQMEK+i9nYCruu6s5PWfS8CqTSfd5Z8lIM1nzPwHaAExmfOC8u x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: c0870641-6f8b-4f8a-0ab5-08d55e3d43e9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1773; x-ms-traffictypediagnostic: VI1PR05MB1773: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231023)(944501161)(6055026)(6041268)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR05MB1773; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB1773; x-forefront-prvs: 05568D1FF7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(39380400002)(366004)(346002)(376002)(189003)(199004)(4477795004)(99286004)(3660700001)(105586002)(305945005)(3280700002)(5250100002)(74316002)(2906002)(66066001)(478600001)(6246003)(76176011)(14454004)(3846002)(86362001)(2900100001)(6116002)(59450400001)(316002)(102836004)(6506007)(26005)(7696005)(8676002)(9686003)(54906003)(81156014)(81166006)(8936002)(4326008)(53936002)(33656002)(110136005)(6436002)(97736004)(106356001)(2950100002)(68736007)(25786009)(55016002)(5660300001)(7736002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1773; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: EpvDVcXyLzN3T6xQLB15dNDFrVZXnUlxQsPbtY9SCL9BQXl/ZpUNrax/Ga0/6fwSqNtEhZhcXaFwnocztsFG4w== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0870641-6f8b-4f8a-0ab5-08d55e3d43e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2018 06:32:36.7061 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1773 Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 06:32:41 -0000 Wednesday, January 17, 2018 7:33 PM, Thomas Monjalon: 09:12, Andrew Rybchenko: > > From: Ivan Malov > > > > +#define RTE_RX_OFFLOAD_BIT2STR(_name) \ > > + { DEV_RX_OFFLOAD_##_name, #_name } > > + > > +static const struct { > > + uint64_t offload; > > + const char *name; > > +} rte_rx_offload_names[] =3D { > > + RTE_RX_OFFLOAD_BIT2STR(VLAN_STRIP), > > + RTE_RX_OFFLOAD_BIT2STR(IPV4_CKSUM), > > + RTE_RX_OFFLOAD_BIT2STR(UDP_CKSUM), > > + RTE_RX_OFFLOAD_BIT2STR(TCP_CKSUM), > > + RTE_RX_OFFLOAD_BIT2STR(TCP_LRO), > > + RTE_RX_OFFLOAD_BIT2STR(QINQ_STRIP), > > + RTE_RX_OFFLOAD_BIT2STR(OUTER_IPV4_CKSUM), > > + RTE_RX_OFFLOAD_BIT2STR(MACSEC_STRIP), > > + RTE_RX_OFFLOAD_BIT2STR(HEADER_SPLIT), > > + RTE_RX_OFFLOAD_BIT2STR(VLAN_FILTER), > > + RTE_RX_OFFLOAD_BIT2STR(VLAN_EXTEND), > > + RTE_RX_OFFLOAD_BIT2STR(JUMBO_FRAME), > > + RTE_RX_OFFLOAD_BIT2STR(CRC_STRIP), > > + RTE_RX_OFFLOAD_BIT2STR(SCATTER), > > + RTE_RX_OFFLOAD_BIT2STR(TIMESTAMP), > > + RTE_RX_OFFLOAD_BIT2STR(SECURITY), > > +}; > > + > > +#undef RTE_RX_OFFLOAD_BIT2STR >=20 > Why this undef? >=20 > > --- a/lib/librte_ether/rte_ethdev_version.map > > +++ b/lib/librte_ether/rte_ethdev_version.map > > @@ -198,6 +198,12 @@ DPDK_17.11 { > > > > } DPDK_17.08; > > > > +DPDK_18.02 { > > + global: > > + > > + rte_eth_dev_rx_offload_name; > > +} DPDK_17.11; >=20 > New functions should be experimental. >=20 > > EXPERIMENTAL { > > global: Apart from Thomas comments looks OK to me.=20