* Re: [dpdk-dev] [PATCH] ethdev: add notice for planned name size change [not found] <20170706150751.27251-1-stephen@networkplumber.org> @ 2017-08-07 22:19 ` Yongseok Koh 2017-08-08 4:56 ` Shahaf Shuler 0 siblings, 1 reply; 3+ messages in thread From: Yongseok Koh @ 2017-08-07 22:19 UTC (permalink / raw) To: Stephen Hemminger; +Cc: dev > On Jul 6, 2017, at 8:07 AM, Stephen Hemminger <stephen@networkplumber.org> wrote: > > VMBUS support will use GUID in eth_dev_data name field which requires > at least 37 characters. Plan for increase in size now. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 2e708dbe0deb..d5b70c50064a 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -95,3 +95,7 @@ Deprecation Notices > The non-"do-sig" versions of the hash tables will be removed > (including the ``signature_offset`` parameter) > and the "do-sig" versions renamed accordingly. > + > +* ethdev: An ABI change is planned for 17.11 for the structure eth_dev_data. Isn't it better to use "``rte_eth_dev_data``"? > + The size of the unique name will increase RTE_ETH_NAME_MAX_LEN from 32 to > + 64 characters to allow using a globally unique identifier (GUID) in this field. Except for the small comment above, Acked-by: Yongseok Koh <yskoh@mellanox.com> Thanks, Yongseok ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: add notice for planned name size change 2017-08-07 22:19 ` [dpdk-dev] [PATCH] ethdev: add notice for planned name size change Yongseok Koh @ 2017-08-08 4:56 ` Shahaf Shuler 2017-08-08 9:47 ` Thomas Monjalon 0 siblings, 1 reply; 3+ messages in thread From: Shahaf Shuler @ 2017-08-08 4:56 UTC (permalink / raw) To: Yongseok Koh, Stephen Hemminger; +Cc: dev Tuesday, August 8, 2017 1:20 AM, Yongseok Koh: > > On Jul 6, 2017, at 8:07 AM, Stephen Hemminger > <stephen@networkplumber.org> wrote: > > > > VMBUS support will use GUID in eth_dev_data name field which requires > > at least 37 characters. Plan for increase in size now. > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > --- > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index 2e708dbe0deb..d5b70c50064a 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -95,3 +95,7 @@ Deprecation Notices > > The non-"do-sig" versions of the hash tables will be removed > > (including the ``signature_offset`` parameter) > > and the "do-sig" versions renamed accordingly. > > + > > +* ethdev: An ABI change is planned for 17.11 for the structure > eth_dev_data. > Isn't it better to use "``rte_eth_dev_data``"? > > > + The size of the unique name will increase RTE_ETH_NAME_MAX_LEN > from > > + 32 to > > + 64 characters to allow using a globally unique identifier (GUID) in this > field. > > Except for the small comment above, > Acked-by: Yongseok Koh <yskoh@mellanox.com> Acked-by: Shahaf Shuler <shahafs@mellanox.com> > > Thanks, > Yongseok ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: add notice for planned name size change 2017-08-08 4:56 ` Shahaf Shuler @ 2017-08-08 9:47 ` Thomas Monjalon 0 siblings, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2017-08-08 9:47 UTC (permalink / raw) To: Stephen Hemminger; +Cc: dev, Shahaf Shuler, Yongseok Koh > > > VMBUS support will use GUID in eth_dev_data name field which requires > > > at least 37 characters. Plan for increase in size now. > > > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > > --- > > > +* ethdev: An ABI change is planned for 17.11 for the structure > > eth_dev_data. > > Isn't it better to use "``rte_eth_dev_data``"? > > > > > + The size of the unique name will increase RTE_ETH_NAME_MAX_LEN > > from > > > + 32 to > > > + 64 characters to allow using a globally unique identifier (GUID) in this > > field. > > > > Except for the small comment above, > > Acked-by: Yongseok Koh <yskoh@mellanox.com> > > Acked-by: Shahaf Shuler <shahafs@mellanox.com> Acked-by: Thomas Monjalon <thomas@monjalon.net> Applied, thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-08 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170706150751.27251-1-stephen@networkplumber.org>
2017-08-07 22:19 ` [dpdk-dev] [PATCH] ethdev: add notice for planned name size change Yongseok Koh
2017-08-08 4:56 ` Shahaf Shuler
2017-08-08 9:47 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).