From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0050.outbound.protection.outlook.com [104.47.2.50]) by dpdk.org (Postfix) with ESMTP id B03091B315 for ; Mon, 5 Feb 2018 07:14:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rK0H5C6bQqUveAQjGArlA9faa2f3kacAiJQty32uI/c=; b=JXERCQdaVbfdahUouZP3J8Rsfv2k4n0xCrxVie+uZi3DfN9/DAcd8mEijwTgdkRPhZpCEzDEyt4yS00PoQ/YO/O8y7OXqbriBvXJtFwd7YxxyWK5Zso+gLQTeu3KenjV6HTHrV8VUHWAVF9NN1/YmPYyUBQkedqMHQffSBWwakw= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3326.eurprd05.prod.outlook.com (10.170.238.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Mon, 5 Feb 2018 06:14:14 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c%13]) with mapi id 15.20.0464.015; Mon, 5 Feb 2018 06:14:14 +0000 From: Shahaf Shuler To: Yanglong Wu , "dev@dpdk.org" CC: "wenzhuo.lu@intel.com" Thread-Topic: [PATCH v2] app/testpmd:vlan filter fail Thread-Index: AQHTnioaXB8kplOUgEy/67d6QmBa/KOVU5qQ Date: Mon, 5 Feb 2018 06:14:14 +0000 Message-ID: References: <20180202050950.64400-1-yanglong.wu@intel.com> <20180205023357.104418-1-yanglong.wu@intel.com> In-Reply-To: <20180205023357.104418-1-yanglong.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3326; 6:aJJOTKtXoEt0t8ip9VpnvKiyOPjsqxZg7vRxSxHEvzJER2OoCmc+i6U+1Y4s0hSyndqXWHXZP8bS8VIxKzVIU+t20myPmn0VpsJzMqVAu6XViksqDC372cTeJ/3XNdoLY1/kdfl0BQeTnMzIbBmdAJg8FKU0qaOuYUKm3ip/cLazHLjrIEUZNQnWVWDvum2fTVNE9AfGJQ3Kz24EJJTDSbUnFHtkjqKNdm17H5RAY9WpIvPlvsI/n7CxkiKfiQsPdh80unaCNYGaklgk/G+L2M0FcagktVt3B2m+Ut8j/sypszjdIsV4rNGYBKSjP7bfMgTNNhYUP6ca63kv/Ilc2Kr8hz3FBxgKV0DNwGH8gjhKZDvPE1IzAWHCZyv/n4Be; 5:2qXm+9Gpi/w1hGmWTrR7zZZCjCqbi8bxLYIiHlqrSAXQVGlBvFqxoG0gkQafl3iAvbAeHm2DC7gYfM4Me8koCEzNwdWTgzRsku2h/JW15ZzRlwtZyymg3C72y2Vlhf3zdog8GEJ8f9hKkI6nuMVkCR6Gd+7EnHWrBjaTbsZ5OZw=; 24:4aNBxESJo5m+O/o+COJ7IYVIQUQ6kwRKaEfVvDlapvGBMkNfv8hTii13HLpa6Wp0DptnDV65F7JHyWaGUsqPHOK4R6W68SMTBlz9fXXWEsE=; 7:hloXHCqjwjiRtTDOmLw9Oh/OPQO/gbjOKB645/IHJ/FKKiYpfopUeKEElPRl8gwZmMhZbcYyraLR6LkJcsIp7xtIUvL4FMwm3EWh4aDiVseGE+zrJ1w1Naex8D+QDwIKrhKllqnoi2t28cntOplgG+qTFXrZjuBkVfGy5oiU8gJbtWdoqjuGpvt5x6678z0IgBDzDCXJbWBokBXznOaJF2561VMnLfOR/Hj49ZwwVm7ZBc/lHNfmgJklSeCgHjn6 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2c919c03-0383-4860-fae5-08d56c5fae62 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB3326; x-ms-traffictypediagnostic: VI1PR05MB3326: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231101)(2400082)(944501161)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR05MB3326; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB3326; x-forefront-prvs: 0574D4712B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(396003)(346002)(39380400002)(39860400002)(189003)(199004)(229853002)(99286004)(25786009)(2900100001)(4326008)(68736007)(81166006)(81156014)(6436002)(8936002)(8676002)(53936002)(55016002)(9686003)(305945005)(7736002)(74316002)(86362001)(186003)(97736004)(2501003)(5250100002)(2950100002)(5660300001)(110136005)(66066001)(6246003)(33656002)(26005)(102836004)(76176011)(6506007)(7696005)(105586002)(316002)(14454004)(3280700002)(6116002)(3846002)(3660700001)(106356001)(2906002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3326; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: rAkdRhjqEybk6MNDqIpAzCho6jDL86ZsPtgdsihZZCqv07hLB6t/nkQVoQ7agKXCjSumrbc8RBJovNpcBUO0nA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c919c03-0383-4860-fae5-08d56c5fae62 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2018 06:14:14.4020 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3326 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 06:14:15 -0000 Hi Wu, Few small comment.=20 Monday, February 5, 2018 4:34 AM, Yanglong Wu: > Subject: [PATCH v2] app/testpmd:vlan filter fail The commit title can better describe the patch, something like: "app/testpm= d: fix port DCB configuration" >=20 > This bug is caused by miss port configuration. The above line is not needed.=20 > The port_conf for the DCB configuration should inherit the same > configuration of the port. >=20 > Fix:0074d02fc(convert to new Rx offloads API) It needs to be : Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API") > Signed-off-by: Yanglong Wu > --- > v2: > changing patch accoding to the review > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 5dc8ccac5..da1d9bd3a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2324,6 +2324,9 @@ init_port_dcb_config(portid_t pid, > /* Enter DCB configuration status */ > dcb_config =3D 1; >=20 > + port_conf.rxmode =3D rte_port->dev_conf.rxmode; > + port_conf.txmode =3D rte_port->dev_conf.txmode; > + > /*set configuration of DCB in vt mode and DCB in non-vt mode*/ > retval =3D get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, > pfc_en); > if (retval < 0) > -- Otherwise - Acked-by: Shahaf Shuler > 2.11.0