From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40066.outbound.protection.outlook.com [40.107.4.66]) by dpdk.org (Postfix) with ESMTP id E12FB7D3E for ; Thu, 24 Aug 2017 08:56:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iS1KY1MM99EohYqq8o+NYKUBt8SIjLwSFz/PAy5lR6w=; b=effoLSUIFybRbJJ8WtMvtI7YEPcy+12BeyxoHo4L+QFk/M78HAohwBcHN8TYrJ5Ao/yrCmhquGOClr27b0/i24jO6iAQMbRVCUAfm5CMyj0evNc7oS/ppFF3eySCpA8SndMVGaOZKxrcQ+aD1ogtCGRB9cKsUrVjbn4j4U+lVBE= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1072.eurprd05.prod.outlook.com (10.162.11.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1362.18; Thu, 24 Aug 2017 06:56:12 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::8450:1a86:2dd0:82c2]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::8450:1a86:2dd0:82c2%13]) with mapi id 15.01.1362.019; Thu, 24 Aug 2017 06:56:12 +0000 From: Shahaf Shuler To: Bruce Richardson , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Sagi Grimberg , "dev@dpdk.org" , "Adrien Mazarguil" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/mlx5: replace memory barrier type Thread-Index: AQHTGlGzvYkeXtqYSke5PWPHRM1ZaqKR1DkAgAAZ3QCAAShlAA== Date: Thu, 24 Aug 2017 06:56:11 +0000 Message-ID: References: <1503301622-14220-1-git-send-email-sagi@grimberg.me> <1503301622-14220-2-git-send-email-sagi@grimberg.me> <20170823113908.GW12995@autoinstall.dev.6wind.com> <20170823131142.GA13944@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170823131142.GA13944@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1072; 6:p8GBkOM18+0W8B5HJdVRzQP2q8T8UF+XnEWWv2Yj5Qlauu1zQtx96guXF/TZibT19DsEstW2cjy52QgAty560ovLy0LWpo9LEo+1kwKwcnpP1tahJae4Eq4gZOUf1tN/Gssg/UkGT9pvTEK9nAT3JHOjcsEYUl/DKcht9ABkNm2TVzkg42BANMHtTOxKToP0ruC98nHMKhWOl2f4zMVcADtsEYr+Ig/4IBtpJuq5QodUtAEhTLwo5mUEw+3heDu1XM4igLGhHz2DlQRS1LYv//4vRlKF376f3QHvWOLVMK/IPBee8JyAlu5x2pbnPYTGPP0Q52Nx9WGhIc6CRiD/+A==; 5:4eIe+rpEXuX9Vq/M+4CpaLsi97xgcRBmWDoSL9FazgFfRulbxfMiYmsBeBinsueOf3HoBXzx5FfAUv8/1X+t6+fKvrpu7K9qfcCUUYMDbFzn8y6dECKK4boqMTM0vBH5o6TAUZGphE9L4EQ5MMEoEw==; 24:0F1tr2pYzWBNi8Qzezimb+oLH5Iy9YVkZbHEKPbuvnB2UK5kh5TU2BtgUs2DD+gcPFsDzdenujdFRfTlNLZKCqwwQaADEMbyKGqXFDg455M=; 7:iQ9bXrDGY7kumxsfEIiq44sxY9r2KeH/IRabWveVzFH0pv4xoBY8+7bQ5OH8Dp/PEAn1FotiuVVnAf50c5ZEJG3D9NXbggcvGKLo7Tm4liqeOAw5aIGXpXi6jrv+1Bezg0edlmvLqJh3pjawCP2UQTBt8MCF/i6/WbDvTnUSzy0aS4iJ7tQ6fnuhmDzXrztZ5XdEUhn0pYUdwQVVMwCx2FKc5wliOFj3PfMUicYGgJs= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: 3471d359-a537-4263-2b76-08d4eabd34c6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603196)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB1072; x-ms-traffictypediagnostic: VI1PR05MB1072: x-exchange-antispam-report-test: UriScan:(788757137089); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB1072; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB1072; x-forefront-prvs: 04097B7F7F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(24454002)(377454003)(199003)(51914003)(189002)(6506006)(102836003)(189998001)(55016002)(2900100001)(8936002)(66066001)(86362001)(229853002)(5660300001)(81156014)(81166006)(8676002)(68736007)(3846002)(99286003)(7696004)(7736002)(14454004)(25786009)(4326008)(6116002)(305945005)(53936002)(74316002)(33656002)(3280700002)(6436002)(9686003)(54906002)(97736004)(478600001)(54356999)(2906002)(93886005)(6246003)(5250100002)(76176999)(2950100002)(106356001)(3660700001)(105586002)(101416001)(50986999); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1072; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2017 06:56:11.9797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1072 Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: replace memory barrier type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 06:56:14 -0000 Wednesday, August 23, 2017 4:12 PM, Bruce Richardson: > On Wed, Aug 23, 2017 at 01:39:08PM +0200, N=E9lio Laranjeiro wrote: > > On Mon, Aug 21, 2017 at 10:47:01AM +0300, Sagi Grimberg wrote: > > > > Acked-by: Nelio Laranjeiro > > > While a compiler barrier may do on platforms with strong ordering, I'm > wondering if the rte_smp_wmb() macro may be needed here to give > compiler barrier or actual memory barrier depending on platform? Thanks for the catch! However, the description of rte_smp_wmb() not seems to fit our case here. We don't try to sync between different lcores, rather between the device an= d a single lcore.=20 Maybe rte_io_wmb fits better?=20 >=20 > /Bruce