From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40087.outbound.protection.outlook.com [40.107.4.87]) by dpdk.org (Postfix) with ESMTP id B77F61B20F; Wed, 10 Jan 2018 16:22:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ia9gog50aozi3/XLeIEgN8BJcZ8q00Fl7ijcOGbVI2Y=; b=Z5xkdihEr7x3ITq5nY0aZJdUJaylOXjc/pyul6b5WuRJIqMj7WDs1Vzqu+LoxKcJeOrrza2DByUem5ydNQ4XAZL9+Tj169phsBLj/x3eXwXmh7M/Xla8fhrdhmNf0BL4WKhebjPCbV72bA0Rs+YYS/v1yXLmml4W47ulrbEkYYQ= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by DB6PR0501MB2037.eurprd05.prod.outlook.com (10.168.9.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 15:22:11 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0386.009; Wed, 10 Jan 2018 15:22:11 +0000 From: Shahaf Shuler To: Yongseok Koh , Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: "dev@dpdk.org" , Yongseok Koh , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: fix overwriting bit-fields in SW Rx queue Thread-Index: AQHTiXDFA34hQm31WUaf260g6groA6NtOoog Date: Wed, 10 Jan 2018 15:22:11 +0000 Message-ID: References: <20180108220645.13493-1-yskoh@mellanox.com> <20180109173850.17707-1-yskoh@mellanox.com> In-Reply-To: <20180109173850.17707-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB6PR0501MB2037; 6:TSLVC5Ky79P6LWAnIPcMZG9g6jnXPfRNgDArY3r4eoCQiqtRNrv1pSFJcwerPlQgiFBDw27XQMBZBA4uU8/hsroU0COSbZZXn+OHuml9e1R/24LkuEwXHv5kgvGpIgRaYQnLjqEHsoWLm1aIsHFAZIqQu6l37hKspQ5UBcR9SqlIjlN/PloYYU4nBEr9pb8fxdbXnbPTGEqKm3jNJ99BMeuIktD1M4siQlC9405K+BLJvwqnnxxUi9whMFVsY4NBRf3j35q2Jh1XA62sKMzcEeC6wFsVn8iwcA7PYuBFxQAf/ys3fWtc7VJvvwi1+L3iZNlS/fyP2PGmCvLBZVyQpoH5gX9N+rIwDTM+9wE3UrvEfhX3SSmFU4avejKmc61G; 5:NeJ66/9D2crYWDvnP1Nm1QFpMLUNkZObxQZ3X6A4nkFAd5g3Yc2BhiP/nWhVI4l+xCeoon5BI0IXa7sA1BnIBd4Ekmp1xIIBatAKFXdw7oyr19PNvmtI4Q/2nJXjx2YMVTibIBihYBPIp0YDHchs6naxN7L6kHME9TARSKcQND0=; 24:uZTBvr7ifQD6limk9TuMoaXTCEzOxkItuOMOLDCxe+vM+ZwgGiHEMTUzjgtPNysJte+8n3Yx4DxosvEXHYn6Jx13xwx4qvubF14KXR+3Ih4=; 7:B490kdB2ZLumD6BRBbiwyziUZED8+zynZS0KvQn9j8M/J4rqhGN51+z2pfbwYcIjtroCkq+jsWmVGvVnK97/Jjz0JwegY59k4tbdAYAEAKYfv7/4aHx8UBgtJVbTbmxZkDQWyfIRKBdyvHY2wwtyi1mfVuBIY85TEHy7owXdlpsj2UwnnCbjY3di3A8BwTg3SmDmQUDRUyzGdZwt1YQCr+ACCp8zWMFIxQCGExd1W5A2F2PzfSQ8bDexRnscIs9A x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f232f00f-a1d6-4539-b103-08d5583debf2 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:DB6PR0501MB2037; x-ms-traffictypediagnostic: DB6PR0501MB2037: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231023)(944501075)(93006095)(93001095)(6055026)(6041268)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DB6PR0501MB2037; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DB6PR0501MB2037; x-forefront-prvs: 0548586081 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(346002)(396003)(366004)(376002)(189003)(199004)(14454004)(6436002)(55016002)(4326008)(99286004)(9686003)(6246003)(33656002)(229853002)(316002)(7696005)(53936002)(74316002)(2906002)(2900100001)(6116002)(3846002)(305945005)(7736002)(3280700002)(76176011)(105586002)(97736004)(106356001)(59450400001)(5660300001)(110136005)(54906003)(478600001)(86362001)(3660700001)(2950100002)(5250100002)(68736007)(8936002)(6506007)(102836004)(66066001)(25786009)(81156014)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2037; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: tVVCDzQtXqYDUc56Pi6vaXKLj2JzzOBMP6DkLe06JW3a4oembyZ/nNoNmT8jrU3TqZQztLgNkJCBO9l2GdGHOw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f232f00f-a1d6-4539-b103-08d5583debf2 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2018 15:22:11.6030 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2037 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix overwriting bit-fields in SW Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 15:22:14 -0000 Tuesday, January 9, 2018 7:39 PM, Yongseok Koh: =20 > Bit-fields in mlx5_rxq_data can be changed on the fly by a control plane = - e.g. > rxq->mark. However, vectorized Rx uses a bit-field to mark pending errors= . > Even if one bit is written, consequence is to write the whole integer and= this > can cause a synchronization issue - two entities write to a same block wi= thout > locking. As the pending_err bit is entirely internal use for the datapath= , this > can be replaced with a local variable. >=20 > Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") > Fixes: 570acdb1da8a ("net/mlx5: add vectorized Rx/Tx burst for ARM") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh Applied to next-net-mlx, thanks.