From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0043.outbound.protection.outlook.com [104.47.1.43]) by dpdk.org (Postfix) with ESMTP id 8195C1B025 for ; Tue, 9 Jan 2018 11:03:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JCeAzcQtgWq0daduf3gb3azyvSLGfyXHYSlzk9ReLbU=; b=fIv9MNKGZQHHN+p1jPvOVaP4FECWxKYAPf83npdO4R6PGDDIlvOIosB8Fvv0HVOtibIbbVZCbz96RfP+Br0BhPDUpqKBHTwmj21I6xnfaVwLK1bW1j5p2FBOT3KPVNzjzy6lmj3Vo0jsm349VS7ZEM2fzWWWQ5SNCCxwOTyYhl8= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Tue, 9 Jan 2018 10:03:43 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0386.009; Tue, 9 Jan 2018 10:03:43 +0000 From: Shahaf Shuler To: "Lu, Wenzhuo" , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight VLAN configuration Thread-Index: AQHTfi56Pn2HyERYhUaO6yKuHjknFaNrRP8AgAAgk2A= Date: Tue, 9 Jan 2018 10:03:43 +0000 Message-ID: References: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C5D9@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C5D9@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3149; 7:8X/HRcmft7DhHLji1KDeQs6yL4FX5tTcgQILukqRx7p9u4NlnC4BJ+6g0sTZk3m7ctnDwmvW+GeTi1sApp0Ednek3EM3k/yCq+Oq2eOYb12m+b9LYiZzq+UhCZTfJ1HuutoHIhZKIEw5P6HsHeq20ZGXzsRyE+b9SqBNBf1BrPdQSP+QfYtp4lH7LngGRS6Sr/Sff9bhh0rcuFiyjpRHVTUc0ECuq3JLEd/PmlcAkGapU2EbzIlyF6GTMuCkoGob x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1ae74190-bf68-449e-8324-08d55748445f x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB3149; x-ms-traffictypediagnostic: VI1PR05MB3149: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231023)(944501075)(10201501046)(6055026)(6041268)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:VI1PR05MB3149; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB3149; x-forefront-prvs: 0547116B72 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(39860400002)(366004)(39380400002)(346002)(52084003)(189003)(199004)(4326008)(229853002)(2906002)(7736002)(316002)(25786009)(76176011)(5660300001)(66066001)(106356001)(110136005)(478600001)(105586002)(7696005)(6116002)(33656002)(3846002)(14454004)(59450400001)(6506007)(6246003)(102836004)(99286004)(5250100002)(305945005)(3660700001)(6436002)(8936002)(53936002)(2900100001)(55016002)(9686003)(74316002)(81166006)(81156014)(93886005)(68736007)(86362001)(3280700002)(97736004)(2950100002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3149; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: gM/p7p3LrLwQPaDl+XV4vdRAHkhcaiCzpvg9NRmVVHp5hIxO20RgWf3fZlPwVx9j4Zg6/ATS+wZC0Og5H5sBBA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ae74190-bf68-449e-8324-08d55748445f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2018 10:03:43.8383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3149 Subject: Re: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight VLAN configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 10:03:45 -0000 Tuesday, January 9, 2018 10:06 AM, Lu, Wenzhuo: > > Subject: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight > > VLAN configuration > > > > On ethdev there is an API to configure VLAN offloads after the port > > was started and without reconfiguration of the port or queues. > > > > In the current design of the application, when the Rx offloads are > > changed (through "port config all" CLI command) the port configuration > > is overwritten, therefore the configuration made for the VLAN is lost. > > > > This patch is to address the issue by a configuration of each port Rx > > offloads separately instead of using the global Rx config. > > > > Fixes: 6dbb2b336586 ("app/testpmd: convert to new Ethdev Rx offloads > > API") > This patch is not applied yet. The number 6dbb2b336586 could be > meaningless. If the previous patch need to be fixed, may I suggest just > merge this one to that? Or this patch fixes some older issues actually? Well, this was done per Ferruh's request to better split the patches. I can merge it with the Rx one, agreed?=20