From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00054.outbound.protection.outlook.com [40.107.0.54]) by dpdk.org (Postfix) with ESMTP id B00AA1B6DB; Tue, 30 Jan 2018 21:37:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1jFAe90w7bwbQYbD76e02ZEzuEC8sRxNwSvWGvFORfQ=; b=GuG22OCPV9D5sbKTDcLLxAoITK7mR33/b6iU+z3kugHvSP9ZBbWXU1bRU0+0yiXJMV99uT57+AS2hsX6ilhWhdp4ZcvPVqRHLd10Y5gRoW+dnAVWjp5PAqYeH3faUhbGjeSiENtzg2fa6shXf408cn5xCpAjVjCXykdjerIj40E= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1568.eurprd05.prod.outlook.com (10.164.86.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Tue, 30 Jan 2018 20:37:06 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c%13]) with mapi id 15.20.0444.016; Tue, 30 Jan 2018 20:37:06 +0000 From: Shahaf Shuler To: Adrien Mazarguil CC: Mordechay Haimovsky , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] net/mlx4: fix dev rmv not detected after port stop Thread-Index: AQHTmNwMM7rTNxFmy0+XiB+ZCx6fu6OKrDrQgAF+owCAALYFUA== Date: Tue, 30 Jan 2018 20:37:06 +0000 Message-ID: References: <1516357009-15463-1-git-send-email-motih@mellanox.com> <1517214877-126768-1-git-send-email-motih@mellanox.com> <20180130093958.GE4256@6wind.com> In-Reply-To: <20180130093958.GE4256@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1568; 7:myQchIDa6eShVumW1hfaIkpEVmp4nN531yF1wCzGMjt74iGeCfjOtZRvn6W03Zm5YNhSotQI4lSQ7NVLhzMSvxbIOK9EJP0O+vpjkiH8xbSmqJ9RqCL8Ar1fEs6ZHoyslTokQvVlzDE6DMuH19CoHFHS3PpTo7jbBekY6jUBQSChCPoV3h8/W4X8D5ZqJGz4FH/1V+mXHmAa9Ur5By0aoTb/zaelvESoQduPTQ/lCoxPLejW+1o3wcQYg4VD+OjP x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ea620c45-a94e-4b2c-d443-08d568213a33 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1568; x-ms-traffictypediagnostic: VI1PR05MB1568: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(944501161)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR05MB1568; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1568; x-forefront-prvs: 0568F32D91 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(39380400002)(39860400002)(396003)(199004)(189003)(54906003)(99286004)(25786009)(97736004)(2900100001)(8676002)(81166006)(81156014)(8936002)(6436002)(93886005)(478600001)(14454004)(229853002)(186003)(33656002)(6246003)(316002)(106356001)(5890100001)(55016002)(5250100002)(9686003)(53936002)(5660300001)(68736007)(105586002)(3660700001)(2906002)(2950100002)(6916009)(4326008)(66066001)(74316002)(6116002)(3846002)(7736002)(305945005)(6506007)(102836004)(76176011)(7696005)(86362001)(26005)(3280700002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1568; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: NQrGqSXrDh9XSO27mzjxLNu6kiWcD6ml3JVH1miYOenXoPxXz0YH3Ttww3DaAZpBn/nztkVmDH1MgMq98rgo3w== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea620c45-a94e-4b2c-d443-08d568213a33 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2018 20:37:06.1239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1568 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 20:37:08 -0000 Tuesday, January 30, 2018 11:40 AM, Adrien Mazarguil: > Unfortunately I didn't get a chance to review this patch before it was ap= plied. > I'm not sure a stopped port is supposed to report events (interrupts). Wi= ll > applications expect them to occur at this point? Why not? Stopped port is still counted as attached. The fact the application stopped= the packet receive on it doesn't mean it should not receive a sync events = (such as the remove event). async events, by definition, are not related to traffic being flows through= the port.=20 >=20 > In my opinion it's not a fix, as in, it doesn't address an issue introduc= ed by the > mentioned patch whose behavior was correct. >=20 > It's probably too late to change it now and it does address an issue seen= with > a use case involving this PMD, however I think the fail-safe PMD could as= well > poll using the recently-added rte_eth_dev_is_removed() when it's aware > the underlying port is stopped instead of expecting interrupts. >=20 > -- > Adrien Mazarguil > 6WIND