From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0049.outbound.protection.outlook.com [104.47.1.49]) by dpdk.org (Postfix) with ESMTP id B283A1B8F1; Thu, 1 Feb 2018 09:40:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3UJTE0a8Vfh7NHnbFy2HLDQgLhiykpAlpmdqvzhGUl4=; b=k3/r8lTqvlR+O9I4aHmAm5P9iNwTgND6m4N+KAGTAqgT5S4ThwxyAYMm36dt5wHPguL4HtiHagZdVl4TvD8XfE2aps6WniPAa4RcHZNDly+04l43iS8xJbM1l0lyQOIaSMjhggZ8hOvDn2wVKdej5pChq0/8zf+AnR8fAH4zvrs= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3502.eurprd05.prod.outlook.com (10.170.239.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 1 Feb 2018 08:40:19 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::cd00:54ee:63a8:937c%13]) with mapi id 15.20.0444.016; Thu, 1 Feb 2018 08:40:19 +0000 From: Shahaf Shuler To: Adrien Mazarguil CC: Mordechay Haimovsky , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx4: fix drop flow resources not freed Thread-Index: AQHTmqjTszu+w5kUeEGaXnxnvGb/p6OPOyBA Date: Thu, 1 Feb 2018 08:40:19 +0000 Message-ID: References: <1517327640-182072-1-git-send-email-motih@mellanox.com> <20180131153141.1289-1-adrien.mazarguil@6wind.com> In-Reply-To: <20180131153141.1289-1-adrien.mazarguil@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3502; 7:n0gpNz+eW9udtGCePn31DOKIoDILsYUmYXv2sZJPEQb3ZJlB5ge27S+nVlA7Uw+icjhN4My5NYjDS31XTVsWqFuYUBL14x+SWmmjdZfsjAnNFYKOA6efAxxHkI/mJhSNvKLIUGQaLkHI31DW9tOJ+BMxb9S4bJC2mugVp/LFJChKSttwox1KljWSyf0f5VW0YBZdLl27RK5N0aMQZz92jksBcf3nEGE4PA4ionmDvOfVnQdO3jrr6GWY+3MZHRSz x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3d34e5c0-8c02-4139-5239-08d5694f6d08 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB3502; x-ms-traffictypediagnostic: VI1PR05MB3502: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231101)(2400082)(944501161)(93006095)(93001095)(6055026)(6041288)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR05MB3502; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB3502; x-forefront-prvs: 0570F1F193 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(39860400002)(396003)(346002)(376002)(189003)(199004)(7736002)(6246003)(6506007)(3280700002)(7696005)(25786009)(33656002)(3660700001)(5660300001)(86362001)(2950100002)(6916009)(76176011)(4326008)(106356001)(105586002)(2900100001)(102836004)(74316002)(55016002)(305945005)(6436002)(26005)(229853002)(9686003)(53936002)(59450400001)(8676002)(8936002)(99286004)(5250100002)(81156014)(478600001)(14454004)(68736007)(81166006)(2906002)(97736004)(66066001)(316002)(54906003)(3846002)(186003)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3502; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Z2nUcmDln4ivWT1ClVQFoTurh76E1qvhtLT/f5kINiXUVFMLwTCxNxkabWoPW4jvfJqzVzxA2boextQYGsYI0g== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d34e5c0-8c02-4139-5239-08d5694f6d08 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2018 08:40:19.4294 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3502 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: fix drop flow resources not freed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 08:40:21 -0000 Wednesday, January 31, 2018 5:33 PM, Adrien Mazarguil: > Resources allocated for drop flow rules are not freed properly. This caus= es a > memory leak and triggers an assertion failure on a reference counter when > compiled in debug mode. >=20 > This issue can be reproduced with testpmd by entering the following > commands: >=20 > flow create 0 ingress pattern eth / end actions drop / end port start a= ll port > stop all port start all port stop all quit >=20 > The reason is additional references are taken when re-enabling existing f= low > rules, a common occurrence when rehashing configuration. >=20 > Fixes: d3a7e09234e4 ("net/mlx4: allocate drop flow resources on demand") > Cc: stable@dpdk.org >=20 > Reported-by: Moti Haimovsky > Signed-off-by: Adrien Mazarguil > --- Applied to next-net-mlx, thanks.=20