From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA142A00BE; Fri, 1 Nov 2019 08:31:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E05821DFE3; Fri, 1 Nov 2019 08:31:32 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20064.outbound.protection.outlook.com [40.107.2.64]) by dpdk.org (Postfix) with ESMTP id F064C1DFE1 for ; Fri, 1 Nov 2019 08:31:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NlxcKTYBNU+4E7R4PsBwAnz4wx7wX+pS2GFPEMkoCEf4IGjwPJYRnkPp9yElTAKdp3VxL2fp5O977leTFU6G3hGT9FhE07ISW/E7W3COkincEfkvV3+aiS+OHeMK6tC+uaZJC0vLJy+UYcX9MbSzpJmLEjyDezRpS1Idx+/kqDyYOO3Aey8wjDzLFVcS8gNFgSsFeumdJt5MMBaFdu//lVqyQe6rCSpc6SRBcKzoazmyveFgrn8xD2sZ3BMfNzxi49577c6J/otGOb24DKNM/65q/j6GqpPicSS/+NnSXkO5Ov+60tDFLuKvpPafAFNUKsaa0rBZEuAQnMvJzIYitg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=opHqTlO8ypO8xfANyP20G+2XPhuWVASjfezJtIyd5tU=; b=QoHf83S4mN8+eaxB+USlABK6hxGQMsVbdpqTIFahDuU5kMXQNSiMYOeP/BD6l0Y8Q/sSSg6AxNAbOUHhRABbLAkF702ttaUe+QglxS2Hd7JYx7RFCMcDQ4aw63gBaFPSSGKI3tOC7XcmrDk6R8dZoBuCbbta/ccYLOoV2LLIiCkdLjFBMucjnxlbWvDaScTLX4jWtz7rz49Nlg0NWILv+Yg6spR5rMkfrXUKham2eJOiIgJbVyG9kc7YI2slV8Am2R/CREo8tsf7VutD5zJs0kFPHkQVxHrWlv5kHcrLzxsLg++0fSdbACS2kABYrB0+IkTdqOz8WmvDisJaIDA20Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=opHqTlO8ypO8xfANyP20G+2XPhuWVASjfezJtIyd5tU=; b=SmyW0c48R/XKvyCjyAg+roz55aOwlhZmEAxiBGbxZVo1m39uu24zBUp6BI9ezYkrAt14P9werSCTrW6kso7Ekem06vsY+p8ttO/mTfBb8tTUxps2+Gy6c4fI9MaJJXQ1WnWlAHMZJbCgK+BPWUYtAhINEQoc1YeVWDwdj0N94FU= Received: from VI1PR05MB3278.eurprd05.prod.outlook.com (10.170.238.23) by VI1PR05MB3488.eurprd05.prod.outlook.com (10.170.239.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.17; Fri, 1 Nov 2019 07:31:30 +0000 Received: from VI1PR05MB3278.eurprd05.prod.outlook.com ([fe80::4032:5e7c:bbfd:8485]) by VI1PR05MB3278.eurprd05.prod.outlook.com ([fe80::4032:5e7c:bbfd:8485%6]) with mapi id 15.20.2387.031; Fri, 1 Nov 2019 07:31:30 +0000 From: Slava Ovsiienko To: Jack Min , Matan Azrad , Shahaf Shuler CC: "dev@dpdk.org" , Moti Haimovsky Thread-Topic: [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header Thread-Index: AQHVkFQ/x++JlAXH3k+CDRyxND4fHqd16/DA Date: Fri, 1 Nov 2019 07:31:30 +0000 Message-ID: References: <3044c96c749c83daf43e85754113c5bef68af855.1572571554.git.jackmin@mellanox.com> In-Reply-To: <3044c96c749c83daf43e85754113c5bef68af855.1572571554.git.jackmin@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0d461716-a6f1-41f3-ea09-08d75e9d83b0 x-ms-traffictypediagnostic: VI1PR05MB3488:|VI1PR05MB3488: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 020877E0CB x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(189003)(199004)(13464003)(6506007)(54906003)(102836004)(81156014)(76116006)(186003)(9686003)(6246003)(53546011)(26005)(14454004)(55016002)(25786009)(52536014)(478600001)(74316002)(8676002)(486006)(66476007)(476003)(229853002)(3846002)(256004)(6116002)(76176011)(305945005)(6436002)(66446008)(64756008)(66556008)(7736002)(7696005)(86362001)(110136005)(81166006)(71200400001)(6636002)(71190400001)(107886003)(316002)(2906002)(5660300002)(33656002)(66946007)(8936002)(99286004)(11346002)(446003)(66066001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3488; H:VI1PR05MB3278.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Otl+yDNZXcg826q/jqpg/5O6YVwXsKvgDyUqiq7QxD0maGhJWHotXop/xEYx1uYCzvj9coo7EckXh5XbOHaSMK028XNtGXmXhX/vvLPNfSeY+/3hmDl5s1Jpl/j3rkPiWPIuxzovXcnLRSbujkw3viXzUrK/Ckv7V73m/rlLGA+F3nlJD0bklMw1frHGUO923nUZYVXdvJmMVse1DIPtqF3WHidnibzauXivzgU/9yDj1tcRe5LiLsRwGnZfIvzwZ6acLpbuSOo0Jza0Mo+PI/rDDlZuMC6XRwrT83MOJEDXuP9e3nHnhpZnG0VGqlBvLGPR0Wk6HwltssmYfZZIYo6z1BpV9PST5eOSclJXRXLJpUqWrxW75HZ/3WjcHukzcaTgzLGytmYBwoE300CLZ97jtELv9Wwnx6Y/nAFf1iT3rsie9ARzho3sNhZDPjdc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d461716-a6f1-41f3-ea09-08d75e9d83b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2019 07:31:30.7021 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OlD6Vuzjvs69OnePgX0gSrATbvK9Ph79BKcKoe35DmmK325qtEJ/voEVEbmgk3EN8HyYeE5on15iWnQkQSGd3eI9kgVbw00dpK0D2cqRRI4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3488 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xiaoyu Min > Sent: Friday, November 1, 2019 3:33 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header >=20 > Currently if user want to set VLAN id/pcp on an about to be pushed VLAN > header, the of_set_vlan_vid/of_set_vlan_pcp must be present _before_ > action of_push_vlan: >=20 > [1] ... actions of_set_vlan_vid vlan_vid 2 / of_push_vlan ... >=20 > This is misleading because people think rule [1] intends to set VLAN id o= n the > existing VLAN header and then push one new VLAN header on top of it. >=20 > A more natual way to set VLAN id/pcp on an to be pushed VLAN header > should be: >=20 > [2] ... actions of_push_vlan / of_set_vlan_vid vlan_vid 2 / ... >=20 > Fixes: a5f2da0b816b ("net/mlx5: support modify VLAN ID on new VLAN > header") > Fixes: 68fad3635042 ("net/mlx5: support modifying VLAN priority on VLAN > header") > Cc: motih@mellanox.com >=20 > Signed-off-by: Xiaoyu Min Acked-by: Viacheslav Ovsiienko