From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F403EA0524; Wed, 29 Jan 2020 07:47:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D098B1D157; Wed, 29 Jan 2020 07:47:58 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75]) by dpdk.org (Postfix) with ESMTP id 136B11D150; Wed, 29 Jan 2020 07:47:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l81f0I26mkZEsPENp9KFKdo2G1lLp4dNq1BxixHkcFw8zLLv7LRIKjJgCxxDnDc8jhJmdeaTcHYntLD9Yg2geOGE6NDmpCLsGTvcPeMSn2wyocCsBcRSFtjU7KpDmy/raZMkygU6RrayijzxqTILhXOdvv6tjWvvHnX3nk/TozEN6H2mNpYddGkHpPC2ShD9r7wsyl2SlABxsMHeBHgCw9cK9uh4s6b3KJmmJAmfWW1EPHemlutRqUmc0LiFgFX99y6KeAXBYzlcOvnkMPv0P0+KDUn8FT3Y0fCMEhTB2pUWhqxSqkCTjDuzZIQLxS808eAYLG1QgjyFVfTl1Ts2GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dZDeATwyyEKfSq9qYlNdZMZSAsbuF0QVwzuR6EQQj40=; b=ZNYLz6b8TclnO6NX2cAgHhKOq1D2bunytXcdl+d+ovjaVfRWoHpevJu9J60epihOXT4T6XmUv5+oYqnNX/kzJodwvyLZViyfmyOsN8o/jWz1q/eYbqItccaYEYUBJhUxAdQP7mLRHTBckf7+wCcG3xKs/bYwwcVH6rn2yVVrEiRh/p/Z8YRpoXnaoBUJmg5N+vmLm666kxYb9yVdD9ZzWC981j84VIZmvWTTOyz32Zx+/Rw8lR5Z2cX7A4ekdp2a7zJFQpIr7zBvKqn/yW0mba/ncmYgnJLKNxwKgZVKLS7oKsg7C20lxEz1A5N/NxYmnb2zPeByjhsroNFaY5YUEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dZDeATwyyEKfSq9qYlNdZMZSAsbuF0QVwzuR6EQQj40=; b=nPojUt+sRC3E93lKx/03G2tuRjVaMfqyjOCymAr4AuOr/pfb4IYqwq3QI6NC/B9907g4eilqngB9crx/5BUgdOQVaihr35rz2M4uDugy/iLtXX9yDjwXY3EoIQi2QiVYIyMEk6Nww9hlEk+gTRpeC8ZKfAwprEAWNynjXa9/nQI= Received: from VI1PR05MB3278.eurprd05.prod.outlook.com (10.170.239.156) by VI1PR05MB4511.eurprd05.prod.outlook.com (10.171.182.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.24; Wed, 29 Jan 2020 06:47:54 +0000 Received: from VI1PR05MB3278.eurprd05.prod.outlook.com ([fe80::71dc:a42b:ba15:2405]) by VI1PR05MB3278.eurprd05.prod.outlook.com ([fe80::71dc:a42b:ba15:2405%7]) with mapi id 15.20.2665.026; Wed, 29 Jan 2020 06:47:54 +0000 From: Slava Ovsiienko To: Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: make FDB default rule optional Thread-Index: AQHV1f1UsKsKmY4U7kOfwfXoZhTBVagBM/TQ Date: Wed, 29 Jan 2020 06:47:54 +0000 Message-ID: References: <1580231203-13912-1-git-send-email-matan@mellanox.com> In-Reply-To: <1580231203-13912-1-git-send-email-matan@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [77.75.144.194] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1205163c-f79b-4601-b9b9-08d7a4872b47 x-ms-traffictypediagnostic: VI1PR05MB4511:|VI1PR05MB4511: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1091; x-forefront-prvs: 02973C87BC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(189003)(199004)(55016002)(2906002)(66946007)(9686003)(76116006)(66556008)(64756008)(8676002)(66476007)(66446008)(6862004)(478600001)(33656002)(8936002)(6636002)(52536014)(81156014)(81166006)(4326008)(54906003)(5660300002)(316002)(7696005)(450100002)(26005)(86362001)(71200400001)(186003)(53546011)(6506007)(309714004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB4511; H:VI1PR05MB3278.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sWav/fi0/JyW1cX0x92ux6zUCjji1+EJmm8NqQjryGzVWECcIEpybMo708z1RFdTImshz/n7nZO4N/5oFFHYfk6553uAjffxJi4er+c9lD8TBtFZTbTvs7AX5axXszk9idJEfckefQpP/TUSjJ0bId1xYKqKW55E4eRtfoa5DhfmRKcJq/IriefeJJBnkrqSr8j8VxaYLg/o94zMa0A8XvTLxuE7lyc9XUdK/m8yS7IlFxKcigIAvd2WtP5HZKYrZrz2Uq4Oa9mTPedRUoDCY1Exaj1oHQROIN2Pci4qmg2Gr5fntzAUkpPurwTIIlUe99g4Un/r1uklBRlXG04R9VZGC3QXu0QBEVxEi2lZCIO+IF/eLaQKlPcTfI21/EEbWsnqnAoXAGNObIr0tj75f9+IH6aISfPXUMhtHhE0kxMsfSslWlTHdQayUvg70bFZhQIfjFXsB5rSz+cNl1UANmDUEJJDvtNorOCDPRWUWUxACFYAj9Yg/cqR21atqsKm x-ms-exchange-antispam-messagedata: TrfXKJNiBo9kkjX3sFnHD+VmdMdAJiw3ZOC/wmvC0IIUgTCh3kxCM/UB+GHN0n7DrDhaTUbZZgZlPe4ojdRsFGNOihuHY0GtrGChwL0qszI1re9vySwqU72jrGcZqYhVoS2FhsBN9DQIzHQqHAdecg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1205163c-f79b-4601-b9b9-08d7a4872b47 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2020 06:47:54.7986 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8b5f7g3yjrzBs/BTF3iOSbheb2o81u96G/dCvJUGc2L7mmLp8huDGZaUpUcjYmGyqsqo5HCXVHGgQkNEzOLeyrlCsfFaL2X/9tOcut9TERI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4511 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: make FDB default rule optional X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Matan Azrad > Sent: Tuesday, January 28, 2020 19:07 > To: Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: make FDB default rule optional >=20 > There are RDMA-CORE versions which are not supported multi-table for some > Mellanox mlx5 devices. >=20 > Hence, the optimization added in commit [1] which forwards all the FDB > traffic to table 1 cannot be configured. >=20 > Make the above optimization optional: > Do not fail when either table 1 cannot be created or the jump rule (all = =3D>jump > to table 1) is not configured successfully. > In this case, all the flows will be configured to table 0. >=20 > [1] commit b67b4ecbde22 ("net/mlx5: skip table zero to improve insertion > rate") >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_flow.c | 6 ++++-- > drivers/net/mlx5/mlx5_flow.h | 4 ++-- > drivers/net/mlx5/mlx5_flow_dv.c | 11 ++++++----- > drivers/net/mlx5/mlx5_trigger.c | 11 ++++++++--- > 5 files changed, 21 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > 5818349..1fc2063 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -792,6 +792,7 @@ struct mlx5_priv { > /* UAR same-page access control required in 32bit implementations. > */ #endif > uint8_t skip_default_rss_reta; /* Skip configuration of default reta. *= / > + uint8_t fdb_def_rule; /* Whether fdb jump to table 1 is configured. */ > }; >=20 > #define PORT_ID(priv) ((priv)->dev_data->port_id) diff --git > a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index > 5c9fea6..ffaf8a2 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -5575,6 +5575,8 @@ struct mlx5_flow_counter * > * Value is part of flow rule created by request external to PMD. > * @param[in] group > * rte_flow group index value. > + * @param[out] fdb_def_rule > + * Whether fdb jump to table 1 is configured. > * @param[out] table > * HW table value. > * @param[out] error > @@ -5585,10 +5587,10 @@ struct mlx5_flow_counter * > */ > int > mlx5_flow_group_to_table(const struct rte_flow_attr *attributes, bool > external, > - uint32_t group, uint32_t *table, > + uint32_t group, bool fdb_def_rule, uint32_t *table, > struct rte_flow_error *error) > { > - if (attributes->transfer && external) { > + if (attributes->transfer && external && fdb_def_rule) { > if (group =3D=3D UINT32_MAX) > return rte_flow_error_set > (error, EINVAL, > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h > index 39be5ba..82b4292 100644 > --- a/drivers/net/mlx5/mlx5_flow.h > +++ b/drivers/net/mlx5/mlx5_flow.h > @@ -753,8 +753,8 @@ struct mlx5_flow_driver_ops { uint32_t > mlx5_flow_id_release(struct mlx5_flow_id_pool *pool, > uint32_t id); > int mlx5_flow_group_to_table(const struct rte_flow_attr *attributes, > - bool external, uint32_t group, uint32_t *table, > - struct rte_flow_error *error); > + bool external, uint32_t group, bool fdb_def_rule, > + uint32_t *table, struct rte_flow_error *error); > uint64_t mlx5_flow_hashfields_adjust(struct mlx5_flow *dev_flow, int > tunnel, > uint64_t layer_types, > uint64_t hash_fields); > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index b90734e..d57d360 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -3357,7 +3357,7 @@ struct field_modify_info modify_tcp[] =3D { > target_group =3D > ((const struct rte_flow_action_jump *)action->conf)->group; > ret =3D mlx5_flow_group_to_table(attributes, external, target_group, > - &table, error); > + true, &table, error); > if (ret) > return ret; > if (attributes->group =3D=3D target_group) @@ -4334,7 +4334,7 @@ struct > field_modify_info modify_tcp[] =3D { > int ret; >=20 > ret =3D mlx5_flow_group_to_table(attributes, external, > - attributes->group, > + attributes->group, !!priv->fdb_def_rule, > &table, error); > if (ret) > return ret; > @@ -7011,7 +7011,7 @@ struct field_modify_info modify_tcp[] =3D { > mhdr_res->ft_type =3D attr->egress ? > MLX5DV_FLOW_TABLE_TYPE_NIC_TX : >=20 > MLX5DV_FLOW_TABLE_TYPE_NIC_RX; > ret =3D mlx5_flow_group_to_table(attr, dev_flow->external, attr->group, > - &table, error); > + !!priv->fdb_def_rule, &table, error); > if (ret) > return ret; > dev_flow->group =3D table; > @@ -7279,8 +7279,9 @@ struct field_modify_info modify_tcp[] =3D { > case RTE_FLOW_ACTION_TYPE_JUMP: > jump_data =3D action->conf; > ret =3D mlx5_flow_group_to_table(attr, dev_flow- > >external, > - jump_data->group, > &table, > - error); > + jump_data->group, > + !!priv->fdb_def_rule, > + &table, error); > if (ret) > return ret; > tbl =3D flow_dv_tbl_resource_get(dev, table, diff --git > a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index > ab6937a..7e12cd5 100644 > --- a/drivers/net/mlx5/mlx5_trigger.c > +++ b/drivers/net/mlx5/mlx5_trigger.c > @@ -423,9 +423,14 @@ > } > mlx5_txq_release(dev, i); > } > - if (priv->config.dv_esw_en && !priv->config.vf) > - if (!mlx5_flow_create_esw_table_zero_flow(dev)) > - goto error; > + if (priv->config.dv_esw_en && !priv->config.vf) { > + if (mlx5_flow_create_esw_table_zero_flow(dev)) > + priv->fdb_def_rule =3D 1; > + else > + DRV_LOG(INFO, "port %u FDB default rule cannot be" > + " configured - only Eswitch group 0 flows are" > + " supported.", dev->data->port_id); > + } > if (priv->isolated) > return 0; > if (dev->data->promiscuous) { > -- > 1.8.3.1