From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCFEDA0528; Thu, 9 Jul 2020 16:47:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E51F31E8EC; Thu, 9 Jul 2020 16:47:49 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by dpdk.org (Postfix) with ESMTP id 47C6B1E8E1 for ; Thu, 9 Jul 2020 16:47:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+58eDGbJMO9skojCuXxHsgn0aKxnSf6K1PbTqC7ttUWO487PrLCi1qrone1+YI6Uo0qZqfGXSx9WWS8lIQMk/yU8BEEIhmnw1G0BFS7jgL0G9FzuZt2o22k+mSvEPhdRuISWPZGaAIi38XzXP0tewC809KzfNTZpCdJ12beOHefBcVMRD6RtpRpl2l6H1ASqoFxWk8z0erfbppUAFsskRPWsAfYp92NP1ghtnrHC1q7pbU5yeYP+e8w2F8S+LaHA/OXVPk8HixyHlVvstmkHA2nGWxhgOrCJYsiEfoLX2kgGX+Bvf+TxGjT0bEEBAFWt9Em3M8w0pdgYMB0sNObfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZ/Hmc7QQJdetM1SfQU1/u6jwCW7vToR0VxVWwWeUPg=; b=XHtYEp/bjnVRA0BTOSjV6f2WVa7nZzAWgh2HIrWUCRzVs+dqhftBtvxUw2mvlCfSEaZwYiE3uqeg0jY0Vjl0sNbLpC17YJN13b86taFajLKf7e1heh9cXX58xg6cQ/oXBolFq50Sp0n7o6qvw5zUOlRhES0JThiexCineiU8A68SdtWYB12r94QLUs+PWHsSRV6hF8UwQ856pYvhImSFJI6hCD/kOkY5zaZA+ExsSrrzWmZkHKPgzQR2BHKYqi9tb6mbFx4/mWTE5KR9JQSYFx1a9Xe0uRcZZtHEo1bHWzvn0IA4wwXZtrnVDsQJtI0u3Uz/IQ1HVWKf9uf3WVQAKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZ/Hmc7QQJdetM1SfQU1/u6jwCW7vToR0VxVWwWeUPg=; b=c1+BDwNgRmFK4A3c/ADfaUhwpVQeI+rES3OzPzqybhjS4oZbn8mWGSk60Xk7V1H5d/obnpyJQTziOFBdTjsOqXypQa8wTz7jY5ExpcGsuuuxbtU7oXT8lSE64C43QO3zwp2GdestkEUhdnk1RKDHp2dBh1cCYqLFY7lc7Beqc5o= Received: from VI1PR05MB4192.eurprd05.prod.outlook.com (2603:10a6:803:4e::18) by VI1PR05MB7136.eurprd05.prod.outlook.com (2603:10a6:800:184::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Thu, 9 Jul 2020 14:47:45 +0000 Received: from VI1PR05MB4192.eurprd05.prod.outlook.com ([fe80::f53d:1b8c:d023:c5d0]) by VI1PR05MB4192.eurprd05.prod.outlook.com ([fe80::f53d:1b8c:d023:c5d0%7]) with mapi id 15.20.3174.022; Thu, 9 Jul 2020 14:47:45 +0000 From: Bing Zhao To: Thomas Monjalon CC: Ori Kam , Slava Ovsiienko , Raslan Darawsheh , Matan Azrad , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/5] net/mlx5: add flow translation of eCPRI header Thread-Index: AQHWVeuYqhkS/1ub0ECLQqjzNzdiyKj/UpjQ Date: Thu, 9 Jul 2020 14:47:45 +0000 Message-ID: References: <1594219387-240274-1-git-send-email-bingz@mellanox.com> <1594219387-240274-3-git-send-email-bingz@mellanox.com> <2329750.AB1Zr4nes2@thomas> In-Reply-To: <2329750.AB1Zr4nes2@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [112.10.106.122] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4901fee6-3682-4f89-33d6-08d824170aed x-ms-traffictypediagnostic: VI1PR05MB7136: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uiPujUEIXhE2zRoRmiJF9EXOR8f57Y+D0hYVEhmpC+wEPfMcolnyyOa9P/2XV2ojJDQNbFyCrxenc0P9h6F8i7Q2wKnnYNijA2io+NE4bGaOUOnQa9xAUWEpjs2MA0kbqajL3tKStAwy+nlSyrIsfIs0fz1Enr7iMbRcQhbcC3q835Qdvo0xds0F1kR+lEb9D3r6K4oOcZ6KktlnfBv9fMFs833NLTUrBQa/u/R2Naly0nf5RgV+3wSvWTf8J4cAkE+oJl8j25TVSBZvYkbLSgfpQtPqe+IV2oB2WA8RC1eOLOSPirNUBrU/jjvUKYxS6QE9oiFQ2uvbqDOy8PF8XA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB4192.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(366004)(39860400002)(376002)(346002)(136003)(53546011)(186003)(8936002)(6506007)(4326008)(54906003)(6916009)(33656002)(9686003)(76116006)(83380400001)(66946007)(66556008)(64756008)(66446008)(66476007)(71200400001)(478600001)(86362001)(52536014)(2906002)(26005)(7696005)(55016002)(5660300002)(316002)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: VWsIYgMdWhOJ9gWcCwlF7PjQ36sLvS2GeKxHBuKHTFC1RnkKhg4kq3jk+7Xg6uwFrbNLbxOoJ5Upg8v9atm3EXquSS+yy/d/rwOqgxbL7hExH0tMkvLm3Z61FyYPfVeoor5a7xPvkXqdiWpF6Wr5dtoxByhCeWhIZkWGXCvoLjYjws5fvikBEuuqFUCGe/KjHC260133dbA1If/K85vrnVDeNrhvh8ozkhM1gzo0tg+sBfK+NCx4MDN3L1cKOhdJm+14iL2/jqQo+jOjeHM4+dFkDrpH+u3lia+DiVca0tz1kz7DwQRZ1C/sLvu7Xw+8XFDp1xWpDp2C5wDuK6XAgZjkPNpsS8rX1v0CDfeEa5cwNO2Ii1EsJLLEavD1Yf/mN7OIPl5MpiZmVdUBTSyoWKr55ubi9xtJeqEJ3sXn44A2n6LWY6RxY2Sh6nBM9Eo5wBlxkz6B1M+Ucblqwwhm6eJC00GwXBqOGoJ2UfnwFEGtKW14Ad4zsjp4kqLI/Uzr Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB4192.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4901fee6-3682-4f89-33d6-08d824170aed X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2020 14:47:45.7371 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J7c7tFUrL4hQRw/h9sUxMtviGjT/7BksCfjIXCBIkX/jRxfDnDM9O/omQAYE4vBEeg60RmKIyr6aQB0IWJCzIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB7136 Subject: Re: [dpdk-dev] [PATCH 2/5] net/mlx5: add flow translation of eCPRI header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Got it, I will add it. Thanks for your comments. BR. Bing > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, July 9, 2020 8:22 PM > To: Bing Zhao > Cc: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh > ; Matan Azrad ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] net/mlx5: add flow translation of > eCPRI header >=20 > 08/07/2020 16:43, Bing Zhao: > > In the translation stage, the eCPRI item should be translated into the > > format that lower layer driver could use. All the fields that need to > > matched must be in network byte order after translation, as well as > > the mask. Since the header in the item belongs to the network layers > > stack, and the input parameter of the header is considered to be in > > big-endian format already. > > > > Base on the definition in the PRM, the DW samples will be used for > > matching in the FTE/STE. Now, the type field and only the PC ID, RTC > > ID, and DLY MSR ID of the payload will be supported. The masks > should > > be 00 ff 00 00 ff ff(00) 00 00 in the network order. Two DWs are > > needed to support such matching. The mask fields could be zeros to > > support some wildcard rules. But it makes no sense to support the > rule > > matching only on the payload but without matching type filed. > > > > The DW samples should be stored after the flex parser creation for > > eCPRI. There is no need to query the sample IDs each time when > > creating a flow rule with eCPRI item. It will not introduce insertion > > rate degradation significantly. > > > > Signed-off-by: Bing Zhao > > --- > > drivers/common/mlx5/mlx5_prm.h | 16 ++++- > > drivers/net/mlx5/mlx5.h | 15 +++++ > > drivers/net/mlx5/mlx5_flow_dv.c | 130 > > ++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 160 insertions(+), 1 deletion(-) >=20 > In this patch, you could add the feature in the release notes, as part of > mlx5 section, and probably in the mlx5 guide too. >=20 >=20 >=20