From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60047.outbound.protection.outlook.com [40.107.6.47]) by dpdk.org (Postfix) with ESMTP id D69F45681 for ; Wed, 24 Oct 2018 07:54:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4TZXSKu77zdJHSZ1pemq1mzLYGqGnnwjR58DjwVmd0=; b=poAmOpGPyGgl8+OgMMmPT4JDHcFlM2ZfcoJ3zhPLOkCMQ58EIoYDrafTfWRVXgzAD1zyRGsG3Tm9zQ77puJGrVxueNg1dbe4xAJtHWeoZ3uKqiVGpwR+oBRk/X5jZuTHDBqCYrV+bjGMNlVYH6FpADM5YuCtrImdwMayg8mqX6M= Received: from VI1PR05MB4224.eurprd05.prod.outlook.com (52.133.12.13) by VI1PR05MB1263.eurprd05.prod.outlook.com (10.162.122.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Wed, 24 Oct 2018 05:54:42 +0000 Received: from VI1PR05MB4224.eurprd05.prod.outlook.com ([fe80::345d:803:9e2:679c]) by VI1PR05MB4224.eurprd05.prod.outlook.com ([fe80::345d:803:9e2:679c%4]) with mapi id 15.20.1273.019; Wed, 24 Oct 2018 05:54:42 +0000 From: Dekel Peled To: Ori Kam , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , "olivier.matz@6wind.com" , Adrien Mazarguil , Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" CC: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation Thread-Index: AQHUati2gkMnBLfffEWTw+t7UFKIDKUtIFCAgADF2pA= Date: Wed, 24 Oct 2018 05:54:42 +0000 Message-ID: References: <1540301331-51065-1-git-send-email-dekelp@mellanox.com> <1540301331-51065-2-git-send-email-dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dekelp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1263; 6:GR1Y/YjFqy0YNG5DWvFPrQ+iDjOVfDQ2mEi2arRIfSeqWdRteS0c/4KKX72IAoHkiYWNCzcNgefrI0Y2xaDRkZc1fabt2GNMaicn8bqx/B1f2PknYODx66i3kKQlWHT1YcEtDvhhvck9/6E0HU4wVW/lrKXO28ZN33LGtoVvUoZDKuF8CsHe5YbjsSAhnsEdeVXc3kXAcG+hFFvv7zmAfa0XK5z5zwzgCJJLsH9qvyOip+Rg2Tre10OJqa2PD/O5UgM4cGV9gnWgDUM6eg7MvEa4zPiVKldJkKESSiY8Qwgr5GKcR5t/guSBjLx8xfV8rzx4ohfY4GOiulKwYz8xiLj/zDO73D8oFEkc/Mc4gtWiGvbmNiZUNhdU392R02CaN3dd1hY/gKrFyWdt9J4CJQo+f7nw9EPuP+ZWXALI829ivbjoe+wCx+ef4sOIGNE7+lx7yRjfDRD1UfQfkWIuSA==; 5:KKi0yrWuYKiFHTYsKtsLHhLwpZVguGQXTRQM4LJqa0wQdJ58iUBX1kKGg0ry2N0vaNKUDevs2nEbMFmI9DqMUKL21Y+TlhbrOkWXy6Pez/vo9YaioSEtnVmKoTzU+k5RLLy1mCw/q+BQdFBDDigwdmXEgJI7OLwF10325hGOSbE=; 7:AuWYJjrhZJEAtMUfdVH5pugb6xdVFGnjF6zbgnd+WHdHGWEkNhMVN2/PSCu1cIRzNpnf4JNSEVmRqlzA5bPLfEzChC6gi4p8mMNDmH5p7LC6R0ucbveRfAJRNetN400LrabX+6UOIshQKPETKPBxFiohg3L1r1SSxvOagKeHy6hlwytjLxkgWstMbecI7+kKt1MLMsh/gcLmgp4CAqsGX67xVGDaqUnrsxYFF32l1aZPZv7iglIYA42k1kody6EZ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: a7685ac2-4378-4a7d-b714-08d63975318a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB1263; x-ms-traffictypediagnostic: VI1PR05MB1263: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:VI1PR05MB1263; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1263; x-forefront-prvs: 083526BF8A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(136003)(396003)(39860400002)(13464003)(199004)(189003)(99286004)(74316002)(7696005)(256004)(305945005)(76176011)(7736002)(2900100001)(6506007)(53546011)(26005)(186003)(81156014)(81166006)(68736007)(8936002)(102836004)(476003)(486006)(11346002)(446003)(2906002)(8676002)(316002)(6246003)(575784001)(6436002)(9686003)(55016002)(71200400001)(229853002)(71190400001)(53936002)(97736004)(2201001)(106356001)(5250100002)(2501003)(105586002)(14454004)(478600001)(86362001)(54906003)(110136005)(3846002)(6116002)(4326008)(25786009)(66066001)(33656002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1263; H:VI1PR05MB4224.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: EeoqrsAAPKz9Sp0nK0Y8FTtPQcA4PZtKaymaF1nM4RUyFGQo+bG671xqAxRiw+PU75+O79rYTHCmNwqYRuZbpD3AgV5lWt+dIAvRsZqBz9kV1cCoUGeslilc66j44wbCbFZWtPau0L7QcVQ2oZB7jsaSh8U8qmJUo4bkJ5I3CUfPk79ApBKqXaDr8q5i/z8y+IxHi1xYyTzuRTYTa+a7esS5/Dw/+tm8bmxrUPOC3+5Zl65E9pauhPUtT2+HOFJgTa+Di7QVT2veScELC60t79BeC75FHPXkDkPvzKdtJfUf1c1E+jEe/NBeXZeTdSDmPm4A1BG3skQeQlXvOlSti73BD3D1/frQAKPj55DIGFg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7685ac2-4378-4a7d-b714-08d63975318a X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2018 05:54:42.2713 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1263 Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 05:54:45 -0000 > -----Original Message----- > From: Ori Kam > Sent: Tuesday, October 23, 2018 9:06 PM > To: Dekel Peled ; wenzhuo.lu@intel.com; > jingjing.wu@intel.com; bernard.iremonger@intel.com; > olivier.matz@6wind.com; Adrien Mazarguil ; > Thomas Monjalon ; ferruh.yigit@intel.com; > arybchenko@solarflare.com > Cc: Shahaf Shuler ; dev@dpdk.org; Dekel Peled > > Subject: RE: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Dekel Peled > > Sent: Tuesday, October 23, 2018 4:29 PM > > To: wenzhuo.lu@intel.com; jingjing.wu@intel.com; > > bernard.iremonger@intel.com; olivier.matz@6wind.com; Adrien Mazarguil > > ; Thomas Monjalon > ; > > ferruh.yigit@intel.com; arybchenko@solarflare.com > > Cc: Shahaf Shuler ; dev@dpdk.org; Ori Kam > > ; Dekel Peled > > Subject: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation > > > > Previous patch introduced the Tx metadata feature, with unnecessary > > restrictions on data entry. > > > > This fix updates the documentation, removing the data entry > > restrictions on metadata item. > > > > Fixes: aa0b9484eb5f ("ethdev: support metadata as flow rule criteria") > > Cc: dekelp@mellanox.com > > > > Signed-off-by: Dekel Peled > > --- > > doc/guides/prog_guide/rte_flow.rst | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/doc/guides/prog_guide/rte_flow.rst > > b/doc/guides/prog_guide/rte_flow.rst > > index 6fb0535..d6683e4 100644 > > --- a/doc/guides/prog_guide/rte_flow.rst > > +++ b/doc/guides/prog_guide/rte_flow.rst > > @@ -1196,21 +1196,21 @@ Item: ``META`` > > > > Matches an application specific 32 bit metadata item. > > > > -- Default ``mask`` matches the specified metadata value. > > +- Default ``mask`` matches any 32 bit value. > > > Are you sure from the impelmetion it looks like default mask is all ones,= This > means that the first comment is the correct one. >=20 Right, will change it. > > .. _table_rte_flow_item_meta: > > > > .. table:: META > > > > - +----------+----------+-----------------------+ > > - | Field | Subfield | Value | > > - +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+ > > - | ``spec`` | ``data`` | 32 bit metadata value | > > - +----------+----------------------------------+ > > - | ``last`` | ``data`` | ignored | > > - +----------+----------+-----------------------+ > > - | ``mask`` | ``data`` | ignored | > > - +----------+----------+-----------------------+ > > + +----------+----------+---------------------------------------+ > > + | Field | Subfield | Value | > > + > > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D+ > > + | ``spec`` | ``data`` | 32 bit metadata value | > > + +----------+--------------------------------------------------+ > > + | ``last`` | ``data`` | upper range value | > > + +----------+----------+---------------------------------------+ > > + | ``mask`` | ``data`` | bit-mask applies to "spec" and "last" | > > + +----------+----------+---------------------------------------+ > > > > Actions > > ~~~~~~~ > > -- > > 1.8.3.1