From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <shahafs@mellanox.com> Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40047.outbound.protection.outlook.com [40.107.4.47]) by dpdk.org (Postfix) with ESMTP id AC4FE56A3 for <dev@dpdk.org>; Sun, 3 Jun 2018 12:41:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zNYM4MZLPSXqbZDRC40iQ/Fev7ddxFRMSBQ8zwQP4B8=; b=KEE3PHOEhYVI2jYm1bftgX0mx1XjOXvYlQA7uPGw7E+0eKPqCVj1qpKq84EjcP5WSURNZMGDFyavYH/MhyN0o1krUPprGT01vIxTU6laMCO5Ss2hHSejjN8mPA0z9BNeqyG1mcchuNWkaGV8LjETlr40mCbiArv0FavOS++0cTo= Received: from VI1PR05MB4431.eurprd05.prod.outlook.com (52.133.13.26) by VI1PR05MB3277.eurprd05.prod.outlook.com (10.170.238.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.797.11; Sun, 3 Jun 2018 10:41:46 +0000 Received: from VI1PR05MB4431.eurprd05.prod.outlook.com ([fe80::dd74:beb9:cc5:221d]) by VI1PR05MB4431.eurprd05.prod.outlook.com ([fe80::dd74:beb9:cc5:221d%4]) with mapi id 15.20.0820.015; Sun, 3 Jun 2018 10:41:46 +0000 From: Shahaf Shuler <shahafs@mellanox.com> To: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "Xueming(Steven) Li" <xuemingl@mellanox.com>, Wei Dai <wei.dai@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com> Thread-Topic: [PATCH] ethdev: force RSS offload rules again Thread-Index: AQHT+OKHwNm0DgeJeECDrm2kZps9YqROHPQQ Date: Sun, 3 Jun 2018 10:41:46 +0000 Message-ID: <VI1PR05MB443154231B403543F6DD9372C3600@VI1PR05MB4431.eurprd05.prod.outlook.com> References: <20180531132245.19424-1-ferruh.yigit@intel.com> In-Reply-To: <20180531132245.19424-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [180.168.40.154] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3277; 7:Fdr4pzdQ5ZiHgJyVykGAksRDmlqy0i8MHLcZ5Fp08caFXZbEneg3RXifUo7OHCFsaCQ4aLcvQDXo8rY4GkydTQiFQuM3r60g86MExMJug/lA3zasAf+Yj7pNNi5yD16gjBNxA796N8Q9yGWXz1H7kxDvA7RJQQA3dPFh2ddBWXT/U+Pc7DTLyXJkmThgaxsV7vaOj7XaOPGUOzD8EqIPLTfKIn3ybJ9xp8jn+/Wu5yJ/q7DjPn102vt4w8rMGxLy x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB3277; x-ms-traffictypediagnostic: VI1PR05MB3277: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: <VI1PR05MB3277E8B9B7FBB23630820877C3600@VI1PR05MB3277.eurprd05.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(278428928389397); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:VI1PR05MB3277; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB3277; x-forefront-prvs: 069255B8B8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(39860400002)(39380400002)(396003)(199004)(43544003)(189003)(9686003)(4326008)(316002)(7696005)(66066001)(6246003)(110136005)(478600001)(68736007)(3280700002)(33656002)(14454004)(486006)(3660700001)(476003)(5250100002)(11346002)(76176011)(102836004)(8676002)(229853002)(53936002)(446003)(6506007)(186003)(54906003)(2900100001)(99286004)(81166006)(26005)(6436002)(8936002)(3846002)(6116002)(106356001)(105586002)(74316002)(25786009)(97736004)(55016002)(305945005)(59450400001)(81156014)(7736002)(86362001)(2906002)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3277; H:VI1PR05MB4431.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: GbbpammV9dbA/D96kQeM9Le354qwU9FxyY4nmosOiCwVB7shTzQ3+1iZ9c7n1uzHr3Kuxj51jS7kqLElaoU63RE62mAlueBTLq2WxkOHbmMfboys8ZVwe3fGYY2xaUdhszl5hOPjxv8rB+T4g5rcyeNMO2b9TlI4bG9BVyrgQud/PEt14Y+jSuKU17CcXIda spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: fca6ee68-3e64-4e44-18f8-08d5c93e9aaf X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fca6ee68-3e64-4e44-18f8-08d5c93e9aaf X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2018 10:41:46.0302 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3277 Subject: Re: [dpdk-dev] [PATCH] ethdev: force RSS offload rules again X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sun, 03 Jun 2018 10:41:47 -0000 Thursday, May 31, 2018 4:23 PM, Ferruh Yigit: > Subject: [PATCH] ethdev: force RSS offload rules again >=20 > PMDs should provide supported RSS hash functions via > dev_info.flow_type_rss_offloads variable. >=20 > There is a check in ethdev if requested RSS hash function is supported by > PMD or not. > This check has been relaxed in previous release to not return an error wh= en a > non supported has function requested [1], this has been done to not break > the applications. >=20 > Adding the error return back. > PMDs need to provide correct list of supported hash functions and > applications need to take care this information before configuring the RS= S > otherwise they will get an error from APIs: > rte_eth_dev_rss_hash_update() > rte_eth_dev_configure() Are the current app/examples in DPDK tree behave accordingly? =20