Re: [dpdk-dev] [PATCH] vdpa/mlx5: set default queue indices

[Asaf Penso <asafp@mellanox.com>]

Thanks Maxime.

Regards,
Asaf Penso

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, April 15, 2020 10:35 AM
> To: Asaf Penso <asafp@mellanox.com>; dev@dpdk.org
> Cc: Slava Ovsiienko <viacheslavo@mellanox.com>; Matan Azrad
> <matan@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: set default queue indices
> 
> Hi Asaf,
> 
> On 3/23/20 6:50 PM, Asaf Penso wrote:
> > The rte_vhost_get_vring_base function is being called to get the values
> > of last_avail_idx and last_used_idx.
> > These fields will not have the correct values in case the function
> > returns an error.
> >
> > Adding a check for the function return value, and in the case of an
> > error, set the fields to be zero and print a warning message.
> 
> Fixes tag is missing here.
> I will add it while merging:
> 
> Fixes: bff735011078 ("vdpa/mlx5: prepare virtio queues")
> 
> > Signed-off-by: Asaf Penso <asafp@mellanox.com>
> > Acked-by: Matan Azrad <matan@mellanox.com>
> > ---
> >  drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Thanks,
> Maxime