From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22BDDA00C5; Thu, 2 Jul 2020 12:25:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0935C1D8D4; Thu, 2 Jul 2020 12:25:53 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150042.outbound.protection.outlook.com [40.107.15.42]) by dpdk.org (Postfix) with ESMTP id F26FE1D6D6 for ; Thu, 2 Jul 2020 12:25:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gC7rx/B1p+vQRZt2I2phwXW7IrjBxHhrPXtgFhppXclT6vmxfHjpOd4Jxl8tmHcFu+HD0x6V7oIj+TSneG46q7xB3ecqVE+kECtI356SfFd4dWF5QtAmio8RhkKLy/x29kT3IRWxw1oGdmO+iYTDZMwVpQ+bvvqcWdB9iq8siKgM3OOEMpgErvNpu/NHhOhmeLqow5XOK8/qgLQVqkimcHgWkOoT+ni4L42dMeALwKLxMadUDBF/+jnwZcSjgiKFpJX46amz+mRdFlU8GLKf+bv2TK4mUyEcz4OVE0Klp035JcZCRUAJvbl1WW7byFzsF2nDPBVebI+odidMlZJtfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Z30LYiTYAc+IGf6tQs9UbHRvEqcHZhiLxafV7p7LSY=; b=bN0y0s0Sqz6o/ZyWCEnl7Qrp1Bw2UrMAmozyeUvv3vIXt9G824ua4BfmrhxH/B3yaDiRnc5bu8G1zZYGYJkXOTp19hTlXUba2UmoNeusTVMbueytOkOVOu0IsQhp/zZOhTgqG2k/ueXvPPfnMkCGUfHIiasrZNeD7GfzF9arK2KRM/nV5Y+ib8pghdElL6Dq/LkRIFmqEkTWrtr2+JbabyP4NfyFePrY8HsG4qHY2TRViNZnkbHPqe81DeL/DWysznne9VfxLG6+Hdg5I1+z8BbGFO8ThgJfPWqPnDxubIcxVCK37XX1DbB0dFKguhQ414qre5jciSfv3wUrUh804g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Z30LYiTYAc+IGf6tQs9UbHRvEqcHZhiLxafV7p7LSY=; b=T4J5LNC/YFxnQrvH7L1Rw/rO8L4X62qIQUSVIEQg90F2bxeWS3oTvwhIzhLbH/oPvZ8plQ5wrvH3feYqtCcfHFP+zYQT+nxdusn7DSIkBrvdFIJXTNLSxxv9yw4CxDhkz6WGj+zemOw/rA+eerMvpZ5xspjYfwX9twIOqQbZojg= Received: from VI1PR05MB5872.eurprd05.prod.outlook.com (2603:10a6:803:de::17) by VI1PR05MB6943.eurprd05.prod.outlook.com (2603:10a6:800:18e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.27; Thu, 2 Jul 2020 10:25:51 +0000 Received: from VI1PR05MB5872.eurprd05.prod.outlook.com ([fe80::ec95:ae9e:77c8:63ae]) by VI1PR05MB5872.eurprd05.prod.outlook.com ([fe80::ec95:ae9e:77c8:63ae%6]) with mapi id 15.20.3153.027; Thu, 2 Jul 2020 10:25:51 +0000 From: Fady Bader To: Thomas Monjalon CC: "dev@dpdk.org" , Tasnim Bashar , Tal Shnaiderman , Yohad Tor , "dmitry.kozliuk@gmail.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" Thread-Topic: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows Thread-Index: AQHWTmy8AtlLc2uIO0yFu0UX60zsKaj0GR4Q Date: Thu, 2 Jul 2020 10:25:51 +0000 Message-ID: References: <'20200531124151.16848-2-fady@mellanox.com'> <20200622115528.22928-1-fady@mellanox.com> <20200622115528.22928-2-fady@mellanox.com> <2273109.IVLB8IxS53@thomas> In-Reply-To: <2273109.IVLB8IxS53@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [213.57.105.94] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9200b9c5-cd1a-4be0-63cc-08d81e724b5d x-ms-traffictypediagnostic: VI1PR05MB6943: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jk3ZcegMNMLu2/cqTSetFoSG2xdTQiCWM2Xw+srNipjygFojU5hiiiYQPtzVILqxnje1thPXnrsqbc7WeUOx7/NmKVSFfBf4xbMHpNggdfBXj2Pbr3AI1q/rVMYywChstGiWOSSLTJaiHFOSAjiFSHHQr6Uu/5h+yDfG0pw4SSVj4uZsTHvX7L0FYA67kJfdJUauxsHst29HbPKuhleqqpgVO6hTCdM+9T3udKhz1RC8avqGbgqyxBN4FU/wxicnZNT01q2P8t8ct2v4Fku5WujT4ilFdjs1GBkQ6C4+VMrFzE4XrKix0vzcR9AjKRNoUI+k0y3MuTfBBCV5D1HwAg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5872.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(346002)(396003)(136003)(39860400002)(6916009)(9686003)(55016002)(26005)(186003)(76116006)(64756008)(66946007)(66476007)(66556008)(66446008)(71200400001)(54906003)(316002)(7696005)(6506007)(83380400001)(53546011)(86362001)(4326008)(33656002)(45080400002)(2906002)(5660300002)(478600001)(8936002)(8676002)(52536014)(7416002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: pQvstWRlCOjubsgPInLISDnRBATuyzaFnGazgf/VUh56tOEDiwsmkcxlv9qTs19Lmoe4GiDncuT0psU4E0yrTmNxrOsRhhOs0ywkHk5sRLusxWae/NxYjQ8U7h2izAAV0v7Hma6m+xtiV6IlS9tZNJhh6krxDN+ezJMFSDYgdn3aTWJ4+6vLqWkDJifcXRsxAlqfsfOYevn6BX35OM73wRkIgliSLNRfH0xHRoqlYl7PJH3XTtnX5hSyCV8lSdB0mPYugbY+x4zFXbfPAD2hiUwYFiHgEOZhR6MSO3AsA9wWTnF+JcV10hYpc7p8tbnLU2TEKS55SdJLNFCe/s/QDSUOncN2MtBMMWpRmWmG7Wlpt9zT5EHJmsl89LMgyjESklTUA7JhBvlNAXqiDKYodlO6JcU2SoHriwmhQ7Bw28hcJrCN5O44CI/OWltMJwxB+CdemCbwiSpYtYwqYOsWCU9FL7AnwRytZCWDgHKGET8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB5872.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9200b9c5-cd1a-4be0-63cc-08d81e724b5d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 10:25:51.0542 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rT0jQ/1h/0b0kGpk9z9C/k4md0XMx5hW6Xb4HnhnsCnMdaM7R2me7kFzAl4ocLBT/uitYBANy4q4Pf7CMtM/Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6943 Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, June 30, 2020 2:26 AM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozliuk@gmail.com; harini.ramakrishnan@microsoft.com; > ocardona@microsoft.com; pallavi.kadam@intel.com; ranjit.menon@intel.com; > olivier.matz@6wind.com; arybchenko@solarflare.com; mdr@ashroe.eu; > nhorman@tuxdriver.com > Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning o= n > Windows >=20 > 22/06/2020 13:55, Fady Bader: > > Function versioning is not needed on Windows, also the function > > versioning implementation is not supported by Windows. >=20 > I think it was said that "not needed" is not right. > Let's just say that it is not supported for now. Ok, I'll change. >=20 > > Function versioning was disabled on Windows. > > > > Signed-off-by: Fady Bader > > --- > > --- a/lib/librte_eal/include/rte_function_versioning.h > > +++ b/lib/librte_eal/include/rte_function_versioning.h > > +#ifdef RTE_EXEC_ENV_WINDOWS > > +#undef RTE_BUILD_SHARED_LIB > > +#endif >=20 > This trick is a bit weird but works. > A comment is missing to explain that function versioning is disabled but = shared > libraries are allowed for Windows. Sure, I'll add a comment to explain. >=20 >=20