From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCDB8A00C5; Sun, 5 Jul 2020 10:51:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 46DD71DA55; Sun, 5 Jul 2020 10:51:17 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69]) by dpdk.org (Postfix) with ESMTP id C4C772C30 for ; Sun, 5 Jul 2020 10:51:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HtHTB31nN0eefVi3NEZD++Jl/ly+V5oo+e/gqELeboTgxuKXUnb8H+gtvQLEEUhfQX8A6CrYmnjmOwa2D62pYSfPRRQJY6G6+hnkozIOKd/uqL3Sbj5uB+4OkMFwfsl6nWnkml9JAjPcyc0RCgrEg3HfwcUFsX5zlClk6Ssplk74O60qyUVTnExpdwd9HaPg5Moe0atppFnX3UMd5e1aDGYjJUh7w7wC674tjdRws0MHjguQ/0cW7dXbJLcqQe3zD6BD+ViWBsiFgf4ExaBf1YkIFuWalPqw56k/iok6mj7/ZqK7DN5rNn1IfBo955jBoZ2M9T/hLHP06fA5E5Fxig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1twTMUvA11ryZ3PiE95rKzBK2N7WCCmM/8+zlfHiDDk=; b=fK+wwlOUiROwwh4lak1nRqYF1ChUjHXpTDFeVAC8+XV+xMRpG0HZM/Wo9faov8h7zon+gCaMErykJhWb4dNo8wURAtzCH70cknQ+I4Bnd9MMntFi7sPlIKlHYNCy3OLfYsH32g9n7/dW2YDxK2Bkbxr8ywebexRNcdbQjtysx7SjNb2g5iBQdZ8/5sKXFw0XtDx//q+3FjEfGoKNKtuHo1NjR0YaXYkOL+OzA4N6QZHSIunzz0Pezri2eHJmYvXa12ceZnp2ezDjIDKM0vVoYVwRBKFbQAiwXsy+d1ZmHQW34F3UkSBaF34vVh8JY9CWpyNvMxXb9JnCPTYZkViHew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1twTMUvA11ryZ3PiE95rKzBK2N7WCCmM/8+zlfHiDDk=; b=f1QYPGZSliqm2EYd5A1frU0G4ctED1oA846plzHtSH8I3KDcPnmu9c8pBLw8IFWAKgmO5Pk6tuMZz1+XNQCy9TjTel2UiLcnQ0Jdets6TOcoX6WyR9JPV9dO1FhMxy6n5iu9U2XvaU7RZ0ZdfDkZzQ2i3xG/Qf4J7vP6g345MQM= Received: from VI1PR05MB5872.eurprd05.prod.outlook.com (2603:10a6:803:de::17) by VI1PR05MB5119.eurprd05.prod.outlook.com (2603:10a6:803:a7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.29; Sun, 5 Jul 2020 08:51:14 +0000 Received: from VI1PR05MB5872.eurprd05.prod.outlook.com ([fe80::ec95:ae9e:77c8:63ae]) by VI1PR05MB5872.eurprd05.prod.outlook.com ([fe80::ec95:ae9e:77c8:63ae%6]) with mapi id 15.20.3153.029; Sun, 5 Jul 2020 08:51:13 +0000 From: Fady Bader To: Thomas Monjalon , "Kinsella, Ray" CC: "dev@dpdk.org" , Tasnim Bashar , Tal Shnaiderman , Yohad Tor , "dmitry.kozliuk@gmail.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "nhorman@tuxdriver.com" Thread-Topic: [PATCH v3 1/4] eal: disable function versioning on Windows Thread-Index: AQHWTswZJqy1POoPpEadUJe/uN8anaj0ZGoAgAQv5uCAAB1AAIAAAk/Q Date: Sun, 5 Jul 2020 08:51:13 +0000 Message-ID: References: <'20200531124151.16848-2-fady@mellanox.com'> <67f92962-1cc1-cdbc-0371-a57a5b38533d@ashroe.eu> <4076841.gji8TSPR8A@thomas> In-Reply-To: <4076841.gji8TSPR8A@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [213.57.105.94] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a4a7f026-252f-4542-68c0-08d820c092b0 x-ms-traffictypediagnostic: VI1PR05MB5119: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 045584D28C x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XdI9+8/XNTgLkpnWk+Af01kIsU2nOG3iijvLZvcDdEIJyXrYG8mlAswaC5Yo0rghIp65m1Vk6DNzPJIAtLdnEpXdvfObQJ6FBzE6yNj6EWd7Y98z6ftimo0whSmFG1gwFOkgpD6Np8o7Nm9AI/P2MuDTRYy40LLkY4D1VRefGMV5yvHLJT1tDmi45USLrdlDgOTD98B0G0/hmbBvyeJs5+1+fFMi5D02gR8hG6H30tRjc4l7lrQ48yh0Lj4SqHLuTyLJw22ci95ob6cAv+xpWhjJClKwBzfJx5Jy3Mu0VS2/C2i+SPFcMDKKezznwcJ9 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5872.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(346002)(396003)(376002)(39850400004)(6506007)(186003)(53546011)(71200400001)(83380400001)(2906002)(7416002)(66476007)(66556008)(66446008)(52536014)(64756008)(66946007)(8676002)(9686003)(86362001)(55016002)(26005)(76116006)(33656002)(478600001)(8936002)(7696005)(5660300002)(4326008)(110136005)(316002)(45080400002)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: +Pt+LX09SVbZzMFNwlIK0WmdTbm/O3Q/YOPoIlnE4i9qYTSbSbA8V6bwz47bmcM36eBiIgavQTRv5Oh8XjdoTBWSFjOM5s4LHmijwc3d9EbkFNaGBGugFWqUSsKpfGCAr2ZqXCC2h4epPVR8WudVibMsQBu1yGDczvaCS0oUuuA7MP0qU7r7dPxNZO3wtWD++EizT/bDMHeEGCpR3mWsQ5y1igqsIQlyMHZIBb7X6WnmZcmm09ydR4kLLuuocyvAfGrtWLrE6vnos+K0A6r/41fpAKeoX7/CNcYS/ZjVA+ZSwGdVmjFFT844kX6sUObL209vzdllRVxPbnFaOSBgKzZoRGQ4MS4HunWpUrjgoI6UzLyzHXYTNPFp6NdXa/RGaYnaZSutnf4K2/mQuG+DhfH824t3SQFZsLaZN9uQMRW6RUOOXveHXGmdCP+l4kDsbZM7Pgs2swi1AF1haKFLS6AGRAtOLLYTisNpwp2wcnc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB5872.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4a7f026-252f-4542-68c0-08d820c092b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2020 08:51:13.8630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xstRz50yz2WfZJyTYxVokn/QkLb3TDXJbIuKLJFSnZBKXKuBIYIcBLE7Bg61DMqX5JZuWqwa46O243sOufSwAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5119 Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Sunday, July 5, 2020 11:38 AM > To: Kinsella, Ray ; Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozliuk@gmail.com; harini.ramakrishnan@microsoft.com; > ocardona@microsoft.com; pallavi.kadam@intel.com; ranjit.menon@intel.com; > olivier.matz@6wind.com; arybchenko@solarflare.com; nhorman@tuxdriver.com > Subject: Re: [PATCH v3 1/4] eal: disable function versioning on Windows >=20 > 05/07/2020 09:00, Fady Bader: > > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > > On 22/06/2020 12:55, Fady Bader wrote: > > > >> --- a/lib/librte_eal/include/rte_function_versioning.h > > > >> +++ b/lib/librte_eal/include/rte_function_versioning.h > > > >> @@ -11,6 +11,10 @@ > > > >> #error Use of function versioning disabled, is > "use_function_versioning=3Dtrue" > > > in meson.build? > > > > Do we need a meson error/rule that catches if people explicitly > > > > try to enable > > > function_versioning. > > > > We don't want to just silently fail under such circumstances? > > > > > > > > Would something in lib/meson.build would work better? > > > > > > > > if use_function_versioning and target_machine.system =3D=3D "Window= s" > > > > // complain loudly ... > > > > endif > > > > > > > > I think this would be a better approach. > > But instead of checking if the use of function versioning is enabled > > under Windows and then complain, I think we should simply disable it > > from Windows in the meson.build file. Something like this: > > > > if target_machine.system =3D=3D "Windows" > > use_function_versioning =3D false > > endif >=20 > Did you try? >=20 > If you disable function versioning, compilation will fail with the #error= message > above, right? > Yes, the compilation fails, we can also change the rte_function_versioning.= h code in order not to fail under Windows. What do you think ? =20