From: Fady Bader <fady@mellanox.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Tasnim Bashar <tbashar@mellanox.com>,
Tal Shnaiderman <talshn@mellanox.com>,
Yohad Tor <yohadt@mellanox.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
Omar Cardona <ocardona@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Ranjit Menon <ranjit.menon@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows
Date: Sun, 5 Jul 2020 12:24:05 +0000 [thread overview]
Message-ID: <VI1PR05MB587292DF47773AFF07E8729ABF680@VI1PR05MB5872.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zUfk74DO5DHr8E2Si2x-b28TZHwRr6b+L_j8BEc43Fgw@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Sunday, July 5, 2020 3:01 PM
> To: Fady Bader <fady@mellanox.com>
> Cc: dev <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>; Tasnim
> Bashar <tbashar@mellanox.com>; Tal Shnaiderman <talshn@mellanox.com>;
> Yohad Tor <yohadt@mellanox.com>; Dmitry Kozlyuk
> <dmitry.kozliuk@gmail.com>; Harini Ramakrishnan
> <harini.ramakrishnan@microsoft.com>; Omar Cardona
> <ocardona@microsoft.com>; Pallavi Kadam <pallavi.kadam@intel.com>; Ranjit
> Menon <ranjit.menon@intel.com>; Olivier Matz <olivier.matz@6wind.com>;
> Andrew Rybchenko <arybchenko@solarflare.com>; Ray Kinsella
> <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
> Subject: Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows
>
> On Sun, Jul 5, 2020 at 1:47 PM Fady Bader <fady@mellanox.com> wrote:
> > diff --git a/lib/librte_eal/rte_eal_version.map
> b/lib/librte_eal/rte_eal_version.map
> > index 196eef5afa..9ad843c754 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -395,4 +395,5 @@ INTERNAL {
> > rte_mem_map;
> > rte_mem_page_size;
> > rte_mem_unmap;
> > + __rte_trace_mem_per_thread_alloc;
>
> The CI result is not there yet, but I expect issues.
> This symbol is marked as experimental, not internal.
> + it is exported already in the experimental section of the EAL map.
You are right, I'll remove it in the next version of the patch.
>
> Why did you need this line?
>
>
> --
> David Marchand
next prev parent reply other threads:[~2020-07-05 12:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 13:14 [dpdk-dev] [PATCH v4 0/3] build mempool " Fady Bader
2020-07-02 13:14 ` [dpdk-dev] [PATCH v4 1/3] eal: disable function versioning " Fady Bader
2020-07-05 11:46 ` [dpdk-dev] [PATCH v5 0/3] build mempool " Fady Bader
2020-07-05 11:46 ` [dpdk-dev] [PATCH v5 1/3] eal: disable function versioning " Fady Bader
2020-07-06 8:19 ` Bruce Richardson
2020-07-06 10:39 ` Fady Bader
2020-07-05 11:46 ` [dpdk-dev] [PATCH v5 2/3] mempool: use generic memory management Fady Bader
2020-07-05 11:50 ` Andrew Rybchenko
2020-07-05 12:08 ` Dmitry Kozlyuk
2020-07-05 12:25 ` Fady Bader
2020-07-05 11:46 ` [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows Fady Bader
2020-07-05 12:01 ` David Marchand
2020-07-05 12:24 ` Fady Bader [this message]
2020-07-05 13:47 ` [dpdk-dev] [PATCH v6 0/3] build mempool " Fady Bader
2020-07-05 13:47 ` [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning " Fady Bader
2020-07-05 14:36 ` Tal Shnaiderman
2020-07-05 20:23 ` Thomas Monjalon
2020-07-06 7:02 ` Fady Bader
2020-07-05 13:47 ` [dpdk-dev] [PATCH v6 2/3] mempool: use generic memory management Fady Bader
2020-07-05 15:26 ` Dmitry Kozlyuk
2020-07-05 20:08 ` Thomas Monjalon
2020-07-05 13:47 ` [dpdk-dev] [PATCH v6 3/3] mempool: mempool build on Windows Fady Bader
2020-07-05 20:25 ` Thomas Monjalon
2020-07-06 11:32 ` [dpdk-dev] [PATCH v7 0/3] build mempool " Fady Bader
2020-07-06 11:32 ` [dpdk-dev] [PATCH v7 1/3] eal: disable function versioning " Fady Bader
2020-07-06 12:22 ` Bruce Richardson
2020-07-06 23:16 ` Thomas Monjalon
2020-07-06 11:32 ` [dpdk-dev] [PATCH v7 2/3] mempool: use generic memory management Fady Bader
2020-07-06 11:32 ` [dpdk-dev] [PATCH v7 3/3] mempool: mempool build on Windows Fady Bader
2020-07-06 23:29 ` [dpdk-dev] [PATCH v7 0/3] build mempool " Thomas Monjalon
2020-07-02 13:14 ` [dpdk-dev] [PATCH v4 2/3] mempool: use generic memory management Fady Bader
2020-07-03 13:16 ` Olivier Matz
2020-07-02 13:14 ` [dpdk-dev] [PATCH v4 3/3] mempool: mempool build on Windows Fady Bader
2020-07-03 13:17 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB587292DF47773AFF07E8729ABF680@VI1PR05MB5872.eurprd05.prod.outlook.com \
--to=fady@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).