From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CBE5A00C5; Mon, 6 Jul 2020 09:02:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EF0C1D6BA; Mon, 6 Jul 2020 09:02:33 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80041.outbound.protection.outlook.com [40.107.8.41]) by dpdk.org (Postfix) with ESMTP id 94E811D698 for ; Mon, 6 Jul 2020 09:02:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KPZz0NpTYslA4IJ8rPh6UJTqATCj/0JDsnsfMrWbB3oigGGyjsHkuLiw1prdNcY+IPNlNbY3V7wjEGTOd3xdXhBnraz7+4jrr6lTO1QMLr5KhwlYxV4dB8Gq5U5aDNQGeQw6T9UmajTZHI8WYg5Jp7SeE0qVQUTB/PZ8A5d3Qp7fZjc3/mmIdUr3XCh8NdC9htqJ9FPkKRvN2yYdBbjdFk1st8D30WA1f7ZwAIwVTkY0MejwOmlHckIsiCvH5UeteezJhzk0n9Z3bmo87EC7oJEN/ArYLjSXlGccEKEsQPEcguIX85U9NWf5c3DIiVev7WwW71jwvyaDYfMP4LXgFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TwSIQbJ/BV8TONKO04V6XkUxkrT7MmGCdKExT2+2LRQ=; b=ROI2vtQBcF30z62lWod6KUQ9imwVzfrxLzEwdtX2PHq+1fR5SoGG8IKnHWdLrIlNYWTn9sbFBHeYJYtOKRQ4cAvmRwzZhV5rNhW90PUIvt3VsXnJchNyzyRM7gf4ASBH6pGRC2TnowOf9I7hM7iiixFRspuuf30BHQrahQmEInN8FZ7IpLrXw9Pg0gVhahFW1aUNFDBZgTd8d8Ae5YJooO30+9Zdg4J5NrKv5qq+fyXX4wK9ur8iT61+Cxouvo03Tibn52W3Zqri4juK0hVqaBs1pZ5oDpBwjz2f+Wy/5ckaYW3HeIGERxu94mgeZaLiT15chfX3EeUAzgr4rW9XuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TwSIQbJ/BV8TONKO04V6XkUxkrT7MmGCdKExT2+2LRQ=; b=HCbPF2ZEGGk1zeGgXxCwbvbIz6HlGXLvTAPgWZuqHVTsBSG2hOS+CzI3uaGvQdeuMaD+cA0EMlYGi4Lb0dAG1ZZ+/7c45AH8puSklCqc/PNSTCO/pyktBb3HctTgLnDBTKNoBQDTxHBWrkHDjtcOKhTnNMJjOepgkycDXKxBljA= Received: from VI1PR05MB5872.eurprd05.prod.outlook.com (2603:10a6:803:de::17) by VI1PR0502MB3677.eurprd05.prod.outlook.com (2603:10a6:803:f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Mon, 6 Jul 2020 07:02:31 +0000 Received: from VI1PR05MB5872.eurprd05.prod.outlook.com ([fe80::ec95:ae9e:77c8:63ae]) by VI1PR05MB5872.eurprd05.prod.outlook.com ([fe80::ec95:ae9e:77c8:63ae%6]) with mapi id 15.20.3153.029; Mon, 6 Jul 2020 07:02:31 +0000 From: Fady Bader To: Thomas Monjalon CC: "dev@dpdk.org" , Tasnim Bashar , Tal Shnaiderman , Yohad Tor , "dmitry.kozliuk@gmail.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" Thread-Topic: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows Thread-Index: AQHWUwo17ZTgLUPCbUqnFqDF26WEiaj6IEkQ Date: Mon, 6 Jul 2020 07:02:31 +0000 Message-ID: References: <20200705114629.2152-1-fady@mellanox.com> <20200705134746.26240-1-fady@mellanox.com> <20200705134746.26240-2-fady@mellanox.com> <6814192.mXDoOMZkCk@thomas> In-Reply-To: <6814192.mXDoOMZkCk@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [213.57.105.94] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 538c8a46-f298-4663-d169-08d8217a8d78 x-ms-traffictypediagnostic: VI1PR0502MB3677: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 04569283F9 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m3pdhgXHdKnB5zrwNbrCYcLS1Mw/PQzOhKvF20MIlEKa+y2alejeZScdpOOCxU/Xdj/TKEj8XwLIQAwjokDWXMDaRkxbJZzRQkCj8GauxNOJC2wFzkfG4o6kIWrH5mkatsAO95COkKdA0pMdN29pXdJ3hE4esGPIgOZuOIMIVbsa/gPk/ze7AlXmKK8QYmXT8E+bDnYdfvEra3dTmSba2YW3VNhUAuae4hjmrb3o018XJc5wgXJKaVuW5y4/1KxVrt1rU60t5lX9Zzsp41WgIogj7VM6wWngHJ1z+/A/JNpo7ZWvdWWslebPRt7eFS3f x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB5872.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(7416002)(52536014)(86362001)(45080400002)(186003)(26005)(53546011)(6506007)(54906003)(2906002)(55016002)(71200400001)(7696005)(33656002)(9686003)(66476007)(66556008)(64756008)(66446008)(66946007)(5660300002)(316002)(478600001)(6916009)(76116006)(4326008)(8936002)(83380400001)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: lTyUyCuIq8fa9VYFCkEVbt0Z4EXunLj6NRdbCdOddGFRrpsD3QD3M1sLhrmWkiKW8vZNoh9ZJ/LLq8x8CwmgeYPB7qGUDKBGeQs3Rb0Ywrnv1Crjxpqc8C9EK9oxUbeilxj3pz0bkJF8wM+3nNn0geQaV31F/W9ElzuU2okQqdsrH3OxYwf43IgJJEvy9ZhCcOrPpNJhS1TKzxFOb4E99tr6RCMwovE3JGhpTITnfIefkcI3bKbZ/jz+8tCtzsLidpxqOMU/vmsqrNl85Kvopf1l13eyC0Efuci5zOgX2jy5wSaKfpL8d8y8cvWtX4Rh/mwxnEE7nLpqlZ3DY3Lv/RN60YJBdYqOSqi8CwOS/tNvKpi44ATtlavf3lvGvAmYg9HQBxgLdMcneNCatFKZ8+haKZN3bmr9mpwwlrvU827b7BDmBebVbaGdScqmu9Kaiyq1ZIyoQc8tvIuoqmsAinq9Ea5C+pQZl2URN3Kcww4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB5872.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 538c8a46-f298-4663-d169-08d8217a8d78 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2020 07:02:31.5017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t+iAEJr2t1rX0/gumMzYZm9M9nJEERaMdDpF7VSCMyx3QNygbK1WUHFdgciYjsiyH76w9WDBsO1/h7KidB/Bfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3677 Subject: Re: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Sunday, July 5, 2020 11:24 PM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozliuk@gmail.com; harini.ramakrishnan@microsoft.com; > ocardona@microsoft.com; pallavi.kadam@intel.com; ranjit.menon@intel.com; > olivier.matz@6wind.com; arybchenko@solarflare.com; mdr@ashroe.eu; > nhorman@tuxdriver.com > Subject: Re: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning o= n > Windows >=20 > 05/07/2020 15:47, Fady Bader: > > Function versioning implementation is not supported by Windows. > > Function versioning was disabled on Windows. >=20 > was -> is >=20 > > Signed-off-by: Fady Bader > > --- > > lib/librte_eal/include/rte_function_versioning.h | 2 +- > > lib/meson.build | 5 +++++ > > 2 files changed, 6 insertions(+), 1 deletion(-) >=20 > As suggested by Ray, we should add a note in the documentation about the = ABI > compatibility. Because we have no function versioning, we cannot ensure A= BI > compatibility on Windows. >=20 > I recommend adding this text in doc/guides/windows_gsg/intro.rst under > "Limitations": > " > The :doc:`../contributing/abi_policy` cannot be respected for Windows. > Minor ABI versions may be incompatible > because function versioning is not supported on Windows. > " Ok, I'll send a new patch with the changes soon. >=20