From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C5AFA04A5; Tue, 16 Jun 2020 21:00:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 75B2C1BFA2; Tue, 16 Jun 2020 21:00:04 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2076.outbound.protection.outlook.com [40.107.21.76]) by dpdk.org (Postfix) with ESMTP id 6E8F51BFA1 for ; Tue, 16 Jun 2020 21:00:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NrAdVDHDhB1je2KOUuegOx7N7zWIdkz9hW6/XvbdJgkR9/qyH/OY+IwQASs/beZmaUXvyNcr0nlOdrKTcqoF10Oh/3wmrCh0hSP1qUheFNnWexH64Og32xKLVAG+ybucZmF8EyBDK3Kjv/nd054oEipca8A1t7iZvicrijmeJwgp8OADKdvQ7r1nTbZilzXAXMKMJ8WxmGJyXOs6lWLg/bjJrwEoy/hDBIcZvM3Y7XcyG8StcwIAZwNRsEah1odzs722XrC3Ot1wbPE7jA15GK4+GXjAMED2p+Xg4UN+hQlG2V91LvIrlxkX8LMSr0bkHVKp6gJ5tAxJWxWvKNpQWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UuWDfU06Qhc9xM8L8TD6FlGG9IFUMs965XFl9uIuwWI=; b=mW7qp6l8RJpZta1KdUSiUlAEZx1TQCWkMk4Yw9qyKj0se9BTg8vGs1kbWRbFyuia5CUyXGwnBo5Zn8ESPGupZxQs/ZfDT3D7gh3uWsErVKDFmYddvD2W9TKPhSe8X4K4dGr7bPougCVzKPbzeYZPI/VhxNxfx3ajOWzHfE/70BDJ0aX9VzjjVb+04znoRzQnXRk7y+gx/8ajmF4oGccs2JFyNYEDdIw5bPBeMFo37mUIDsuiCFaxYHSgSiUtpeQliCYR2sLrZC1HUNsucf4q68scOA3AkugpIx9v3qBa3DB0z10KNE6kryhokfXkJYqmPflosmIdohjTYPRMTQu4fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UuWDfU06Qhc9xM8L8TD6FlGG9IFUMs965XFl9uIuwWI=; b=KviWWALNh8jd9JvD2Kpo2BxeeXvEzYfiNHDJsxJbxzoLpL4i9QnGm5NxHCrbC+Q70CtX2v5tpyWmEmrCjUWQA9UjE8o/pHxIu7DWpmmcngxpPI8I9geqKb21U0IHwKdpu5+J+xbP5SgfmGeQrOuOhIu9itZiIkRLzREZQ60n2EY= Received: from VI1PR05MB6128.eurprd05.prod.outlook.com (2603:10a6:803:ec::26) by VI1PR05MB5517.eurprd05.prod.outlook.com (2603:10a6:803:8e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.22; Tue, 16 Jun 2020 19:00:01 +0000 Received: from VI1PR05MB6128.eurprd05.prod.outlook.com ([fe80::e98d:c6c9:be41:86e1]) by VI1PR05MB6128.eurprd05.prod.outlook.com ([fe80::e98d:c6c9:be41:86e1%3]) with mapi id 15.20.3088.029; Tue, 16 Jun 2020 19:00:01 +0000 From: Tasnim Bashar To: Thomas Monjalon CC: "dev@dpdk.org" , "harini.ramakrishnan@microsoft.com" , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "ocardona@microsoft.com" , "navasile@linux.microsoft.com" , "dmitry.kozliuk@gmail.com" , Tal Shnaiderman , Fady Bader , Ophir Munk Thread-Topic: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle Thread-Index: AQHWOIG0Frjhw4BpeUSqtQMYBkbQ0KjZgXAAgAIsVlA= Date: Tue, 16 Jun 2020 19:00:01 +0000 Message-ID: References: <20200522001112.48932-1-tbashar@mellanox.com> <20200602020052.4540-1-tbashar@mellanox.com> <13269652.10yzYP2DCA@thomas> In-Reply-To: <13269652.10yzYP2DCA@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [2601:600:8680:3880:9d7f:8ce4:10ca:cdb4] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ea314e83-27f5-4bf6-586d-08d8122778cd x-ms-traffictypediagnostic: VI1PR05MB5517: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1002; x-forefront-prvs: 04362AC73B x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2nt8T5tcgRf0cQaGuTYasXuhw/8FvS6lEJN1dm+oHA21n1FIzmxvBlMiSib6Uz2gQcQNA5oCwETlOXY+Ww4cozhGECpvCqDHwMhVQMQoXG600CW1kkT6/7dq475/pfhXdXv2ycNY/2w6aMUpkobm57wf9PXhN+IaYXwwEq5ZJz7yWjWYIzQt3dnvld8bbNwZ0IOGQdfpowmnCbX0Kp4H9rkhVl8ZNwhQBP7Shv1zYUEf4VCYWARZ4m4eptYAOZtL8OvR3tQHHXUjQOb+YLfMbzs1N1OxvaGfhuw0Av6/UsnCs1HuyYSfqkPQtNHIr8+XEJTILkeyrBTl2sOeSTITjQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB6128.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(7696005)(9686003)(71200400001)(54906003)(55016002)(86362001)(107886003)(6506007)(4326008)(66946007)(33656002)(76116006)(186003)(52536014)(2906002)(66446008)(5660300002)(8936002)(8676002)(498600001)(6916009)(64756008)(66556008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 2ZnZLWiyf84iRJGMWGJmpjJ7xB6+jI9/uTjG4PV0km6qbVZFKp2bmSy6TyZXb8H0QvVMcrah0HdJBNTTCowellMEeLfaZkQiAP0GW5e4cVPVNmD+8A2s6A+dofsfLv9SbShZdfXezwDoqxJYHJvtuaToypm9iauUO/8VTDOa7JtMn+FJe5njixgghAGnARnwvQTKi2FA+3uTY+vs6HXeWiZb+B5mQ0PYt1yqqpky+gc+hwYiOs+O+I/53v6rfovQCscwGccfnt/VUc1FjxC2ybFdwOTOqYrR2cDYND7KLPqJ+ft91YZXwzDYTyEzF1E2g96P9Xt3qEhef1PHXnqBOsTrWF0rixJ2YqL2XkcHhL3Pn2LUvLE2bL7NCQ/t+UT3NPP8eZBo7foQG7AJ1KaS0LnLRn1Np2qieC5jabbAiVKNsAAk+8IAC83s7mmTnRd74XL34PHnmi/aupdgjV39I8lEFVw+CAGajQvMBe1L+V4NMARNWEzrLYSxCEebGdIgeKMsHv0ZQXPCmVhp4hTc4GvV/uTgoZPaFDyP2fskNczLjOZ9lWwp3SMpo1K6TD7C Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea314e83-27f5-4bf6-586d-08d8122778cd X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2020 19:00:01.1823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0II0mui9tyBPxi5cmMV98pU4KJnSsrCp0RkNKOOWhBXS8T54+lx+HB6pnfbMGgZMzgRQur672zoC04Bbs0JmAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5517 Subject: Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Thomas Monjalon > 02/06/2020 04:00, Tasnim Bashar: > > #define pthread_setaffinity_np(thread, size, cpuset) \ > > - eal_set_thread_affinity_mask(thread, (unsigned long *) cpuset) > > + eal_set_thread_affinity_mask(thread, cpuset) > > #define pthread_getaffinity_np(thread, size, cpuset) \ > > - eal_get_thread_affinity_mask(thread, (unsigned long *) cpuset) > > + eal_get_thread_affinity_mask(thread, cpuset) > > #define pthread_create(threadid, threadattr, threadfunc, args) \ > > eal_create_thread(threadid, threadfunc, args) > > > > static inline int > > -eal_set_thread_affinity_mask(pthread_t threadid, unsigned long *cpuset= ) > > +eal_set_thread_affinity_mask(pthread_t threadid, rte_cpuset_t *cpuset) > [...] > > static inline int > > -eal_get_thread_affinity_mask(pthread_t threadid, unsigned long *cpuset= ) > > +eal_get_thread_affinity_mask(pthread_t threadid, rte_cpuset_t *cpuset) >=20 > I don't understand the need for the #define. > Why not naming the functions with the final pthread standard name? Some functions take more inputs and some take less, that's why we used #def= ine. But it is possible to implement them without #define, naming the functions = with the final pthread standard name. However, it will be better to change it in a different commit.