From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52A2FA04A3; Sun, 14 Jun 2020 12:29:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FB184CA6; Sun, 14 Jun 2020 12:29:24 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150071.outbound.protection.outlook.com [40.107.15.71]) by dpdk.org (Postfix) with ESMTP id 6B7B849E0 for ; Sun, 14 Jun 2020 12:29:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GiFzQbEUyTgYEYrU+tMfC1Pft3oLkOKlnvAU+ibGvAPsTvY2+Mz0JejdvmLejDPFrVSud5ikLS/Im22TQEp07kxfg2QsyRltoIX6wIkcP9wZ2wjE+mlkcMXhLtVnhZy3CVKFMGnkm13jR8jQqO1qYxvtVwFDoX7d+I1VQQgR+X2uXlh7smcXOrWhIlGuxDnsKrJBDihG+/xK0wGwNxt8bKwGuXfZjfehGuGGSAW5dkk2hbB/nFowV5R5nTN6Y55DKxx272B/utsHC71W3RClEDVmwloJfGs7fgAncvRMObHYA1I47Cikracy0sD+S7opsqpZ6gA3RFv9YOMoCWZtQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=luvwSX0ome32mcUayD15PsLvHZLRrrE3gd9al5VgKSk=; b=fqvhNzmFaJh25fbp4T3hM6q6rfgwB7qnAfiDcUtRDHHXS1au5UnQn2jbol67d6yNUETB7IEll3/4oCFs5s+0SDlE+VJxqk/QpCZIjczDlAg217oHSws8/1iip/waXR+ZnUbt13mIW6dhzJ4L4jQ59Lh98LPQgp5z73zAUhOocnLblkw4Kmz42jcbhiBdBkgpYVUEVBvhp/L4JaxH1BowgjLmn2cMWn/i8A7bUPQbBpozR7L3iiYuCSojlDxFqKShRxdUFs4rRUD10OAHxp6G0cvXn2Os+7uFjxqEzTDwXbU+NZlLDgfl4uHApL9HWe8+143uv6WtgUgvqqGxD+fm2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=luvwSX0ome32mcUayD15PsLvHZLRrrE3gd9al5VgKSk=; b=nQB/fg1/e0JUAHsb+uCGyCjMZ3CZmH2SF7gc2/86njqqR/378/fJ0usje4kxnJdCWUd/+b/K0GqIu0f0fEpzIheav0/t6bNYWA8PSX9pVaqIkv6etL4iwLLAjs7wwEjr5TGFhYi2VU8c7h/pBUKYSb0qtg8MGMs0P9uyND6jwTk= Received: from VI1PR05MB6718.eurprd05.prod.outlook.com (2603:10a6:800:13b::9) by VI1PR05MB6063.eurprd05.prod.outlook.com (2603:10a6:803:ed::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.20; Sun, 14 Jun 2020 10:29:21 +0000 Received: from VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::bc68:25c4:b452:f24d]) by VI1PR05MB6718.eurprd05.prod.outlook.com ([fe80::bc68:25c4:b452:f24d%9]) with mapi id 15.20.3088.028; Sun, 14 Jun 2020 10:29:21 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: move GTP mask define to correct location Thread-Index: AQHWPyrgPjEuwLO9MEC4JRJuXvrOFKjX7u5g Date: Sun, 14 Jun 2020 10:29:21 +0000 Message-ID: References: <6dd4f7a13e375c743e77555a6360e7bfa9b9aba5.1591795480.git.dekelp@mellanox.com> In-Reply-To: <6dd4f7a13e375c743e77555a6360e7bfa9b9aba5.1591795480.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.242.49.134] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: be34faa7-c3ff-434f-433f-08d8104dcd42 x-ms-traffictypediagnostic: VI1PR05MB6063: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 04347F8039 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SQNgcNX5suCWh4gF20Iukmc7UuWjiGfv0iRtSxDrJ9xtiSPeicniXMp9Ny7YmRvpHo6qxA3UAi28VWunKB6SaOuHCea5lQsI1f4Gd6qVxu3N91k/9iL0XT2hlf1ClVh3geyllBwqJWT4cT4j/Z6eLc8vQEk3RV/psrjtxotjlGeUZCVrZkCdELj0vBVgJvk1J1rHp2S4kR90SFflO/rYHBTiFXmsGenGq+gvVUmaAUyDHRl9lW936uKUHQbgYNc0DrYAMgjP6+4vfHSm1HsqlHok9l+nmHPJ4t/iGCAIdTyAPBD3bLBCGpV7ij+hUgW8+wcMA3X+JN4G3ILLoFIOqg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB6718.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(136003)(39860400002)(366004)(346002)(396003)(52536014)(5660300002)(71200400001)(53546011)(6506007)(26005)(6636002)(186003)(7696005)(316002)(33656002)(110136005)(86362001)(76116006)(66446008)(64756008)(66476007)(66556008)(66946007)(2906002)(8936002)(8676002)(55016002)(9686003)(83380400001)(4326008)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: pS9gebJXmzFVGkA6UjUOo/ea8K4zfPqZk5iGblZy3o+TBEsh+nxRdt7z8NOv4MvpF3XzuQT3EI5E4214fkT86sZmcv7x+FN5zMZ3oox7XtWGjO2GcrG12vEpPrpdgTJCRZhdOSkCoOcW7ZF5K9UwrOOBzhHAg8KRRQ6qpIHzprbohEQk6r15abCcF0vzKpE34t7ufy9cRuO/l9CxngGOcjVzu+hITVa9Fcgm1qehBeujyM0R/ZLrFIgJtkLGa8pglVx8NqBQxiVusRwrvP1u0aJu7o4z6xRUxD3wIrLmmoP9NFlR3XxoTctejaNVPv2dVm6ncCkAPkvHlpdmbsFGqhV+BlBiLWpdlQRKvLmwKhwkACebbENwpz6Wql4ryO5hOq/eTzgz2WBzg0MsFzOhfrPbnFKFl+6HK5r0UVVGX6Wdr0TAWE+tSo0DzyKi+jULHbHNevobTh3/lx0b0sfhspA4gHrIwEivHyHugU1hV2clCdDOYBcSial0cOwp6tSh Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: be34faa7-c3ff-434f-433f-08d8104dcd42 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2020 10:29:21.3490 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 64UisMGT+6hM41hGa+nGTYbFOmcxIcXilVxwxb267ogYqWS2FeV4uQuDgGEYpt7nXC5LcQEgsEAS/AVT/0LFAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6063 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: move GTP mask define to correct location X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, June 10, 2020 4:25 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: move GTP mask define to correct location >=20 > Recent patch [1] added definition of mask MLX5_GTP_FLAGS_MASK, just > above function flow_dv_validate_item_gtp(), where it is used. >=20 > Patch was applied together with other patches which modified the same > file, so the mask was located further away from the function it is > used in. >=20 > This patch moves the mask definition to the proper location. >=20 > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad >=20 > [1] Commit 563ac307a46b ("net/mlx5: support match on GTP flags") > --- > drivers/net/mlx5/mlx5_flow_dv.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 81f5bd4..d645d2d 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1639,18 +1639,6 @@ struct field_modify_info modify_tcp[] =3D { > return 0; > } >=20 > -/* > - * GTP flags are contained in 1 byte of the format: > - * ------------------------------------------- > - * | bit | 0 - 2 | 3 | 4 | 5 | 6 | 7 | > - * |-----------------------------------------| > - * | value | Version | PT | Res | E | S | PN | > - * ------------------------------------------- > - * > - * Matching is supported only for GTP flags E, S, PN. > - */ > -#define MLX5_GTP_FLAGS_MASK 0x07 > - > /** > * Validate VLAN item. > * > @@ -1724,6 +1712,18 @@ struct field_modify_info modify_tcp[] =3D { > return 0; > } >=20 > +/* > + * GTP flags are contained in 1 byte of the format: > + * ------------------------------------------- > + * | bit | 0 - 2 | 3 | 4 | 5 | 6 | 7 | > + * |-----------------------------------------| > + * | value | Version | PT | Res | E | S | PN | > + * ------------------------------------------- > + * > + * Matching is supported only for GTP flags E, S, PN. > + */ > +#define MLX5_GTP_FLAGS_MASK 0x07 > + > /** > * Validate GTP item. > * > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh