From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Ziyang Xuan <xuanziyang2@huawei.com>,
Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
Guoyang Zhou <zhouguoyang@huawei.com>,
Ciara Power <ciara.power@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>, nd <nd@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] net/hinic: restore vectorised code
Date: Mon, 18 Jan 2021 08:26:00 +0000 [thread overview]
Message-ID: <VI1PR0802MB2351174E2B9BEFA7F0A275729EA40@VI1PR0802MB2351.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xM3kLXT=+6tBfq-g2Jge97KiTnt5_2fvUKZiDdsiC04w@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, January 18, 2021 4:18 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: dev@dpdk.org; ferruh.yigit@intel.com; stable@dpdk.org; Ziyang Xuan
> <xuanziyang2@huawei.com>; Xiaoyun Wang
> <cloud.wangxiaoyun@huawei.com>; Guoyang Zhou
> <zhouguoyang@huawei.com>; Ciara Power <ciara.power@intel.com>;
> thomas@monjalon.net; nd <nd@arm.com>
> Subject: Re: [PATCH 1/3] net/hinic: restore vectorised code
>
> On Sat, Jan 16, 2021 at 3:39 PM Ruifeng Wang <Ruifeng.Wang@arm.com>
> wrote:
> > > Subject: [PATCH 1/3] net/hinic: restore vectorised code
> > >
> > > Following make support removal, the vectorised code is not built
> > > anymore, fix the build flag check.
> > >
> > > Fixes: 3cc6ecfdfe85 ("build: remove makefiles")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > > drivers/net/hinic/hinic_pmd_rx.c | 6 +++---
> > > drivers/net/hinic/hinic_pmd_tx.c | 10 +++++-----
> > > 2 files changed, 8 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/net/hinic/hinic_pmd_rx.c
> > > b/drivers/net/hinic/hinic_pmd_rx.c
> > > index a49769a863..842399cc4c 100644
> > > --- a/drivers/net/hinic/hinic_pmd_rx.c
> > > +++ b/drivers/net/hinic/hinic_pmd_rx.c
> > > @@ -4,7 +4,7 @@
> > >
> > > #include <rte_ether.h>
> > > #include <rte_mbuf.h>
> > > -#ifdef __ARM64_NEON__
> > > +#ifdef RTE_ARCH_ARM64
> >
> > We can test '__ARM_NEON' which will be defined by compilers.
> > https://developer.arm.com/documentation/ihi0053/latest/
>
> On the principle, I agree, but this was not what was tested before.
>
> The activation was only gated by checking for the arm architecture.
> See:
> https://git.dpdk.org/dpdk/tree/drivers/net/hinic/Makefile?id=05b6eee7bda
> bf7c17ed69c44515e0cd7d6e1da23#n14
> So I restored the test as it was before make removal.
>
> What you propose can be done in a followup from the hinic developers, but
> the minimal fix is still this current patch.
I'm OK with this.
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>
>
> --
> David Marchand
next prev parent reply other threads:[~2021-01-18 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 13:40 [dpdk-dev] [PATCH 0/3] net build fixes David Marchand
2021-01-15 13:40 ` [dpdk-dev] [PATCH 1/3] net/hinic: restore vectorised code David Marchand
2021-01-16 14:38 ` Ruifeng Wang
2021-01-18 8:18 ` David Marchand
2021-01-18 8:26 ` Ruifeng Wang [this message]
2021-01-15 13:40 ` [dpdk-dev] [PATCH 2/3] net/i40e: remove vector config David Marchand
2021-01-15 15:36 ` Ferruh Yigit
2021-01-15 13:40 ` [dpdk-dev] [PATCH 3/3] net/fm10k: " David Marchand
2021-01-15 15:36 ` Ferruh Yigit
2021-01-18 14:40 ` [dpdk-dev] [PATCH 0/3] net build fixes Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0802MB2351174E2B9BEFA7F0A275729EA40@VI1PR0802MB2351.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=ciara.power@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xuanziyang2@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).