From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0D696A04BC;
	Sun, 27 Sep 2020 05:28:11 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5F2561D952;
	Sun, 27 Sep 2020 05:28:09 +0200 (CEST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2051.outbound.protection.outlook.com [40.107.21.51])
 by dpdk.org (Postfix) with ESMTP id 123691B6D7
 for <dev@dpdk.org>; Sun, 27 Sep 2020 05:28:08 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; 
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5dV8ht8KIzlWKq/sn1uOOQVHnW96BEc7DwtuyJxGJwQ=;
 b=n2oyDPUVqlcJjXB+fBwM8VSJ5/gcQxQmq/covmD+l+gsHdMjwjK6iv/lKorXUX4doAbFQLX58PwnbOY8889732Di8mpjSO/O7Bglp+7OFQDJzkaesOay4E7qf7+v/a7m+WuQ3LGoGguhOE+US5/Go/tw81qdAHlRqDgGinTcfEE=
Received: from AM6P191CA0041.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::18)
 by AM4PR08MB2850.eurprd08.prod.outlook.com (2603:10a6:205:3::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22; Sun, 27 Sep
 2020 03:28:06 +0000
Received: from AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:7f:cafe::20) by AM6P191CA0041.outlook.office365.com
 (2603:10a6:209:7f::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20 via Frontend
 Transport; Sun, 27 Sep 2020 03:28:06 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT048.mail.protection.outlook.com (10.152.17.177) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.3412.21 via Frontend Transport; Sun, 27 Sep 2020 03:28:05 +0000
Received: ("Tessian outbound 34b830c8a0ef:v64");
 Sun, 27 Sep 2020 03:28:05 +0000
X-CR-MTA-TID: 64aa7808
Received: from 67b30c03480b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C5E3F37F-D805-4F66-BB22-D252A57184E7.1; 
 Sun, 27 Sep 2020 03:28:00 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 67b30c03480b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sun, 27 Sep 2020 03:28:00 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=chFgd8kx9dETGtZ1fmrAW3hyJ/cv4dG1yTJPTqRHIZlZw5qCN5Wjv70dMYk7QBJRQD0PRGAKiBrlgmv+PEgOIYCSuyC7YUXj8Re28Z0ChQa1FjX9Flv74tH7y2N8XesByNoFcDNFfz32RuI/eY5U4GGbrm20rAJV9CxtYOXhVQ41yplPwYkheVfa39QgPjNLQ3nxkbHn+C4RlNyX/d/5G67ShsY1/LTXSpCFVK1c58tJtM9EiCaoBS0YMSc6YvCj4nM6/lt9erAdDYfDhw/OeYoQgg1NsbvHBSBkvezQGp+eV4YUBNCW5vTN+Kbyqc4np2iK/yxQRiGXhZ7Zs8MQ2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5dV8ht8KIzlWKq/sn1uOOQVHnW96BEc7DwtuyJxGJwQ=;
 b=lYfd8qG8mEjNk9raebY3kxnL+zCOoFW0UVrBoDm34bh9c8/Y/MCrVD+gI9Q9vODx1eiWiAGvvgVyti7A7F7MYkzaevN5ZdxDcLtVV5G4Cj3VFDkRAP+XutCAyrAlxE2pU9Hl108LnONUSluWOuQGONf08ey0/8ujM7vSmWNr+ASarOLIl5pHukgYWLqh/ljZfzmxAInG+f0qGYuTFg0EX2DmZiHI2+2Y74TtykwNG8xU5Lo5SlaUwubbI3j5iDkrhejwp+T97glpuVHtEssa8b9rY+8OnAEJNhFp4xhEi/MGh1pURC3N9TMn+NdaU0dQjQx13xppLHxncHaKfNr0CQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; 
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5dV8ht8KIzlWKq/sn1uOOQVHnW96BEc7DwtuyJxGJwQ=;
 b=n2oyDPUVqlcJjXB+fBwM8VSJ5/gcQxQmq/covmD+l+gsHdMjwjK6iv/lKorXUX4doAbFQLX58PwnbOY8889732Di8mpjSO/O7Bglp+7OFQDJzkaesOay4E7qf7+v/a7m+WuQ3LGoGguhOE+US5/Go/tw81qdAHlRqDgGinTcfEE=
Received: from VI1PR0802MB2351.eurprd08.prod.outlook.com
 (2603:10a6:800:a0::10) by VI1PR0801MB1725.eurprd08.prod.outlook.com
 (2603:10a6:800:5c::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21; Sun, 27 Sep
 2020 03:27:57 +0000
Received: from VI1PR0802MB2351.eurprd08.prod.outlook.com
 ([fe80::14d4:6ade:368a:204b]) by VI1PR0802MB2351.eurprd08.prod.outlook.com
 ([fe80::14d4:6ade:368a:204b%3]) with mapi id 15.20.3412.026; Sun, 27 Sep 2020
 03:27:56 +0000
From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
CC: "jerinj@marvell.com" <jerinj@marvell.com>, "vladimir.medvedkin@intel.com"
 <vladimir.medvedkin@intel.com>, nd <nd@arm.com>
Thread-Topic: [PATCH v2 03/12] acl: remove of unused enum value
Thread-Index: AQHWi4B66pPoFATCY0q/0QjOu6RTgql75Q/g
Date: Sun, 27 Sep 2020 03:27:56 +0000
Message-ID: <VI1PR0802MB235125B1B9E0FB06C8FA6BBA9E340@VI1PR0802MB2351.eurprd08.prod.outlook.com>
References: <20200807162829.11690-1-konstantin.ananyev@intel.com>
 <20200915165025.543-1-konstantin.ananyev@intel.com>
 <20200915165025.543-4-konstantin.ananyev@intel.com>
In-Reply-To: <20200915165025.543-4-konstantin.ananyev@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ts-tracking-id: 437D3BE1C1BA5A4D97AF76D94355452E.0
x-checkrecipientchecked: true
Authentication-Results-Original: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=arm.com;
x-originating-ip: [203.126.0.113]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 96e4a633-932a-4373-28b5-08d86295593d
x-ms-traffictypediagnostic: VI1PR0801MB1725:|AM4PR08MB2850:
x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr
X-Microsoft-Antispam-PRVS: <AM4PR08MB285095BD096E31E4D5F32F429E340@AM4PR08MB2850.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:1303;OLM:1303;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: EgMO22BjjsHZr0+75J0K/p5CSokGMziByNYXfjh6g+0R06hXK2sWPweoTzpYZPE02Xp10SOTnRWZRajZa3WCOQkEdG0HWNAnrj36G0G/JfNjAbYTUgPJLe2Eqmm5CoNO6OXPFntWZi7FGyKgbFwyOeTfHnSPDvDAPflbTeQ/mJidgdLX0gt0KRqaT497ObHn4ceuwGvsyFBJCOaFS324Fw+vPCWISzhxTjdfKe1Y7pDSlV+SqecmAyjHEPZW1geAN/NNQy1pgSp6q2svMOYotop+erC+sdw0a+iX+buPdBLSSz7uwzR7IeG2R3lRDyuKTyfVCwUNsUyNw/RCMMsf59SRwNpBtamVyC+2KqOdcGTeLTR97KTVDKHFStUIU/2f2J9uBpCMk1KXDLG53a0aaMZ5FYAnKhZeW/f+sUUm6sEoGCBfpewIrCWqHKA5foqHZLAkxXAxY39/b/VmsZ0qoQ==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en;
 SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0802MB2351.eurprd08.prod.outlook.com;
 PTR:; CAT:NONE;
 SFS:(4636009)(39850400004)(136003)(366004)(346002)(376002)(396003)(110136005)(4326008)(52536014)(8936002)(55016002)(966005)(8676002)(71200400001)(2906002)(9686003)(66446008)(64756008)(26005)(86362001)(7696005)(53546011)(6506007)(76116006)(66946007)(83380400001)(33656002)(478600001)(54906003)(5660300002)(316002)(186003)(66556008)(66476007);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: Rs+29Uihi1ufXfIB0AtKC6obeocND5G4mDKEGoo/fkeAtVWf5VXzcfLL+rSrE+3Cky9Mr8MuJwX8Uny+L74tFr6XMjdN1ayuwd7AjfDNaNZsGx+xFqFW7I0wwNNLfw1dXd/3u64x7jsvvZcyxDwx2E6zaJndp6e+TVN09Bqv3qOn0YbrliCnnjHNwlRBYoEa17yajaBpFouFr5WoLgrbnmpKSIyPe0pOwBa66G/wDSI88LfVUiqIqda6uGuuKogazu+pWrDd7xkkRBm+q6GAhGMultm155fIf7nJaFf+MkDBQm269KI96+qd/ixH5T1apkUtUhpiisTptNRX33ZKh7BlF/U5wCxhWXxICB0oj9OmhoWB/FyizQaPGudfMJ7c4qC1dT0I8MdIypml7KXE6gvzw60Sh+sgArGTPoRFkCxvkchGRhUZ8F/mrYNJ8P4KGd46GDLASjcKlx85Ht0x6Adh/SiKiN+fVisoUIgozWpGMLELJBk+DgiZ9pcbaEnYH6R7aHztkQrhsB2DkNMfsB3Tc7y5C1tspaxKiRWV24YDUUbhzF8oXTvw77qzQidAk4KhnfE+0ose2d6nDpyPMGRP9RDp7A29sauiGiFyULzribQEQvac8+U10XHjrEjyZxE9Wp1pDOGcczmAJqGz8Q==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1725
Original-Authentication-Results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: fd61fa53-3a4a-45eb-4b94-08d8629553df
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: t66bT/sB3Km/Six0MZ7EUz1e8XyDM36Fju+gmThzXj4N7qCaC57LHRk+YSVsSxW8BfZJef2pudOki136P0PJJCQiKowi3y146Bez4RGI5TvNfaBX6x6Dl2fiulwUKpedTy50a9vmA3VTIg8/f85NR28MqsRN+iO/QY1gOctcZHxSSkkToMp/YynH50DbjnDqxbc+JILJSCk7e1gpPCy07q676+iwLghgz8Ivj4ltD8GJUG4jd8pLaiMuBQkPcAHCW8b2/F8fmsjdVLgZoZM+ygSfKU9zlaouXLSDmS67x/K++WxLITkLgQDWE51LfJurpq9SL5rkq9JG0yzEF7ODUtQt6SevIMMd7u9Qiu8oNB7C1P4Ql/yFFq7gBFWn5GqeIxopOpwr8ZORJATXeCrRJWRxckMGCNiw4/SvrZo0sfXprekIzo5S8FJvTWp/jE/03IfOUsvROI6H3igf9aYbLWWE2jVEWOqUBalQBLndQwZr/Jqbu1NmaWFpt5zbuPcgaIg/qajqB/gyLIfsvuHieA==
X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;
 IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;
 PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE;
 SFS:(4636009)(39850400004)(396003)(136003)(346002)(376002)(46966005)(6506007)(356005)(53546011)(33656002)(81166007)(55016002)(82740400003)(26005)(54906003)(110136005)(316002)(8936002)(186003)(83380400001)(7696005)(47076004)(70586007)(70206006)(5660300002)(36906005)(82310400003)(8676002)(478600001)(336012)(966005)(9686003)(2906002)(52536014)(4326008)(86362001);
 DIR:OUT; SFP:1101; 
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2020 03:28:05.9204 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 96e4a633-932a-4373-28b5-08d86295593d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];
 Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2850
Subject: Re: [dpdk-dev] [PATCH v2 03/12] acl: remove of unused enum value
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Sent: Wednesday, September 16, 2020 12:50 AM
> To: dev@dpdk.org
> Cc: jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> vladimir.medvedkin@intel.com; Konstantin Ananyev
> <konstantin.ananyev@intel.com>
> Subject: [PATCH v2 03/12] acl: remove of unused enum value
>=20
> Removal of unused enum value (RTE_ACL_CLASSIFY_NUM).
> This enum value is not used inside DPDK, while it prevents to add new
> classify algorithms without causing an ABI breakage.
>=20
> Note that this change introduce a formal ABI incompatibility with previou=
s
> versions of ACL library.
>=20
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst   | 4 ----
>  doc/guides/rel_notes/release_20_11.rst | 4 ++++
>  lib/librte_acl/rte_acl.h               | 1 -
>  3 files changed, 4 insertions(+), 5 deletions(-)
>=20
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 52168f775..3279a01ef 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -288,10 +288,6 @@ Deprecation Notices
>    - https://patches.dpdk.org/patch/71457/
>    - https://patches.dpdk.org/patch/71456/
>=20
> -* acl: ``RTE_ACL_CLASSIFY_NUM`` enum value will be removed.
> -  This enum value is not used inside DPDK, while it prevents to add new
> -  classify algorithms without causing an ABI breakage.
> -
>  * sched: To allow more traffic classes, flexible mapping of pipe queues =
to
>    traffic classes, and subport level configuration of pipes and queues
>    changes will be made to macros, data structures and API functions defi=
ned
> diff --git a/doc/guides/rel_notes/release_20_11.rst
> b/doc/guides/rel_notes/release_20_11.rst
> index b729bdf20..a9a1b0305 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -97,6 +97,10 @@ API Changes
>    and the function ``rte_rawdev_queue_conf_get()``
>    from ``void`` to ``int`` allowing the return of error codes from drive=
rs.
>=20
> +* acl: ``RTE_ACL_CLASSIFY_NUM`` enum value has been removed.
> +  This enum value was not used inside DPDK, while it prevented to add
> +new
> +  classify algorithms without causing an ABI breakage.
> +
>=20
>  ABI Changes
>  -----------
> diff --git a/lib/librte_acl/rte_acl.h b/lib/librte_acl/rte_acl.h index
> aa22e70c6..b814423a6 100644
> --- a/lib/librte_acl/rte_acl.h
> +++ b/lib/librte_acl/rte_acl.h
> @@ -241,7 +241,6 @@ enum rte_acl_classify_alg {
>  	RTE_ACL_CLASSIFY_AVX2 =3D 3,    /**< requires AVX2 support. */
>  	RTE_ACL_CLASSIFY_NEON =3D 4,    /**< requires NEON support. */
>  	RTE_ACL_CLASSIFY_ALTIVEC =3D 5,    /**< requires ALTIVEC support. */
> -	RTE_ACL_CLASSIFY_NUM          /* should always be the last one. */
>  };
>=20
>  /**
> --
> 2.17.1

Looks good from ABI perspective.
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>