From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B27AA04B7; Wed, 14 Oct 2020 03:55:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E609C1DA90; Wed, 14 Oct 2020 03:55:45 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50064.outbound.protection.outlook.com [40.107.5.64]) by dpdk.org (Postfix) with ESMTP id 54E441D559 for ; Wed, 14 Oct 2020 03:55:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+LN/xUCQAfw4S+X5AdLzQzyPtYQvcYDLMUgCBWWOkRI=; b=6rSDm6jMgfEprNVcGTmLHrRBbiELxbT3OUu0oeJqCqRdV/S+nQK9frA0+U75fOOmUAPOClqSCuV8HDH0duPt3+ndZAZdyvmrJPOfJKxEmC/vk8PUsuiMzNZu+2sU8PepAtUBrAzc90dmMueD1OKKyvKE3hiPahTVzzKbHRCjhpM= Received: from AM5P194CA0006.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::16) by HE1PR0801MB1738.eurprd08.prod.outlook.com (2603:10a6:3:87::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Wed, 14 Oct 2020 01:55:41 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::48) by AM5P194CA0006.outlook.office365.com (2603:10a6:203:8f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20 via Frontend Transport; Wed, 14 Oct 2020 01:55:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Wed, 14 Oct 2020 01:55:40 +0000 Received: ("Tessian outbound 7c188528bfe0:v64"); Wed, 14 Oct 2020 01:55:39 +0000 X-CR-MTA-TID: 64aa7808 Received: from 6e4d4061b41f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 68E159C7-9744-4624-A2FA-9A82D8676A11.1; Wed, 14 Oct 2020 01:55:34 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6e4d4061b41f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 14 Oct 2020 01:55:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=adV7aJUhmc9i49CfkJRH1A9l3HIA8bdsBHOuRxmgZN/yr99M85KsGH403hgxGtMnuoPLKtSP0sbbqwBqA9ZD+gG8HNMqYgsI5BkFP4xHa6QOlQxeAipjkCWOUzkKczLKcKNZS5DSLb5JVAMLJWOmvs4psrhx3LwgpJ4Wpo6E3gmIIrmioLY0pO7SJYsIJIASqC1gyfdItlOXWeZ339Epd3yoPixS14tQraB2RVZ9KZ/uUu7k19bUIOWiupUNkZtD1DakwZJ8Ef4syvtDHCnCQ3arOp40GM60x0ImWZ9ZzVaCQ4D9aZcjoUirDBlTnUs0GeusgWDltt4x2ECdBWdAmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+LN/xUCQAfw4S+X5AdLzQzyPtYQvcYDLMUgCBWWOkRI=; b=El/Nw88XFZLdliysbGk7gKww8qwvu2a/MfO2UZxLDedqU93iWT1CkUiCz/bamL5OXMF2yF1wVLeiQwqR0TM01aClmY18cP8eWqwDmm++K0K+H/WXqjH5Lxo7i7A9NW/gJO9u72RpVc4yYFyP8PN7ucRzW+jbhAfpLCUEVjNkFtfhlga416A50+pPpxNczEa6+OU/GdsbGMBL4y+hmQNfVDSzVl4vO9+5y4bB1r7/3TTXZBI2yuUhZDNx3tPzv6iUjH3D9ssUO61J6IGHjlhj3GPDNck31kibRjEIrFww9ezKWUsVldUCnqgbfJRy3g12i+JR/z9UMoxjbHeRE68crg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+LN/xUCQAfw4S+X5AdLzQzyPtYQvcYDLMUgCBWWOkRI=; b=6rSDm6jMgfEprNVcGTmLHrRBbiELxbT3OUu0oeJqCqRdV/S+nQK9frA0+U75fOOmUAPOClqSCuV8HDH0duPt3+ndZAZdyvmrJPOfJKxEmC/vk8PUsuiMzNZu+2sU8PepAtUBrAzc90dmMueD1OKKyvKE3hiPahTVzzKbHRCjhpM= Received: from VI1PR0802MB2351.eurprd08.prod.outlook.com (2603:10a6:800:a0::10) by VE1PR08MB5727.eurprd08.prod.outlook.com (2603:10a6:800:1a5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Wed, 14 Oct 2020 01:55:29 +0000 Received: from VI1PR0802MB2351.eurprd08.prod.outlook.com ([fe80::14d4:6ade:368a:204b]) by VI1PR0802MB2351.eurprd08.prod.outlook.com ([fe80::14d4:6ade:368a:204b%3]) with mapi id 15.20.3455.031; Wed, 14 Oct 2020 01:55:29 +0000 From: Ruifeng Wang To: Bruce Richardson CC: Omkar Maslekar , "dev@dpdk.org" , "ciara.loftus@intel.com" , "drc@linux.vnet.ibm.com" , "jerinj@marvell.com" , Honnappa Nagarahalli , nd , "david.marchand@redhat.com" , nd Thread-Topic: [PATCH v6] eal: add cache-line demote support Thread-Index: AQHWoLxhQkz3a+t+DU2KlBuVFpwfzKmU1POggADjC4CAAJ4owA== Date: Wed, 14 Oct 2020 01:55:29 +0000 Message-ID: References: <1599700614-22809-1-git-send-email-omkar.maslekar@intel.com> <1602497980-20680-1-git-send-email-omkar.maslekar@intel.com> <1602497980-20680-2-git-send-email-omkar.maslekar@intel.com> <20201013162015.GF1496@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201013162015.GF1496@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5B34F650B3BAE448A4E9520BD4D3D032.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 09dbe2b3-022a-4965-1fee-08d86fe440fb x-ms-traffictypediagnostic: VE1PR08MB5727:|HE1PR0801MB1738: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Wo/ikx+uUZdvyXudHHWn82/ZMWTW40vZrHqwxluDjhfrdR8zp4iwjUYDIZVLDJD44tTk/bWsMBFhAZSGzxm3ErH23PUL2ZXZrHgdhXDt651Li11rQ5S89BA7i3Ys6RKgigLgiFPqqUtMES1uj2X3wCRWaokpwWByb81gMtcXLsPAIr/rCC52r3MRm9iywlfHdSPhbE5IeeO7P16a1ZZphjsR6pw9GSQuwEd8zXX4/rNUCKig/2GHM4Rg4xITBMOEEUFm4pxJFL1N0wIklleKVyelii1ah/L1QVotWvxffCU7ON4U9ug7BJzwlFGqTj9XlEeDKBtZNF5Eo8w+6dri0oLyoOy05mdpmOFsaY8AWMRXEFrcq+5U41uNdlBiK1/rgWCdoGxtmIME3sxh/1WSLg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0802MB2351.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(64756008)(66446008)(66476007)(76116006)(66946007)(2906002)(4326008)(86362001)(966005)(52536014)(71200400001)(7696005)(55016002)(83380400001)(26005)(83080400001)(33656002)(186003)(66556008)(6506007)(53546011)(9686003)(8676002)(54906003)(316002)(478600001)(8936002)(6916009)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: iEWULBx66QnwLmxofdlsfTbQ1WYSmD8L7fjOkKA3bw4LIXWTqJJy77btN/h6XOAdehEm214IumVO/5aEIjEJKOeH6FOIxRnUKz6+m5DBbqukAoDViRdXCCKp9MAOvDdVd/XSUF8wzpcDnyCLxKjCmkLDko9gJFkq9PpOjYftAVGkJThFRoAa9PbDaz+yaeLZxqcsdz6onZSsoZI31VAsAVQBo6WoRkYjyCfklGyBZsYBWxGRBxmluiCEzjGeNTgg9XugvytpRLNF6q1rpVEtUcEmpgccCzBm5E960Kd22EyCwXdoVEa/BMqqTL6KOBde0JR9VQmn3bBPwD3urZS8PVFjt7XP7/0DY5YbZh/BUVlctZvje3VeMaxosqDdnGi/gYWd2up507Ud+bQa7nYsgHNPHQLJKsPOGzTs8FplxSZu8HRI2wKhYWyhwtARuokwL2f5tWq0AXToqDTe7Q2y7oryX9VyHe4UbMoAkIIOkIwt75m/NYYCddrcu1pv84nvMs6bfpRENoD9rZQuhqP3keEnsmPs6ur7CNdyS9Ut2Szmh5Y7xfjsQ9MnVWabVBjVMWNWLiDu/k+SOkNXqwqWunFQ32kJ88OxddScXHpPD5kFrjMriAIM6LsLU1hvS+qnMSgCOJFPnjS6iW2py/7nIw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5727 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: bf8faa7c-ace3-4b38-83e7-08d86fe43a35 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KuR9O4A+LuTdqYo2GU87uSCwdtk9ZYSWvYPjvaHt8KUuxePRcsdHV0hKlkRyziykf5PEg8j7z1MMSrNcreg+/q8w4YazHBHPYAYRXltrCdqsPucz6bnjiUKBL4nQAZTmJ+/ChlhBJkejfW0IThVboN73kq2iaQ/7zMq6C3w7DkPfvtfwKvzCKFefmvWGqK7B6FDYCVQHQY0ySop+03tTgtv51QJugkYiV+2fJS19/aNW/y78rDeWted9l+ao3Zezcc70efXrn8FKEWBUpxv3RU2ArAYfdbscj7agTrEwqaiKzfDbSbCLL8cQQWqPiZrF9PIvE36gWDOxIlHzEDzpN79aMEx8mu4Qm4tQwbkk1hxZ0YE2JeetTUxb9oOFzqi8u2IAfg5+lWXJCM9WBvrSLeBlKE2ELwipiMA5ymb/kJ1YXTShi0Asq9ycCd01xt8uCtdXSpbeMDywUBd/bygq6RaiCZTyFP7rQF1a+Vf8+J4= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(376002)(136003)(46966005)(83380400001)(82310400003)(7696005)(9686003)(8676002)(316002)(6862004)(54906003)(8936002)(82740400003)(81166007)(356005)(33656002)(83080400001)(47076004)(2906002)(52536014)(70206006)(70586007)(5660300002)(966005)(86362001)(478600001)(26005)(53546011)(6506007)(186003)(336012)(4326008)(55016002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2020 01:55:40.5221 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09dbe2b3-022a-4965-1fee-08d86fe440fb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1738 Subject: Re: [dpdk-dev] [PATCH v6] eal: add cache-line demote support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Wednesday, October 14, 2020 12:20 AM > To: Ruifeng Wang > Cc: Omkar Maslekar ; dev@dpdk.org; > ciara.loftus@intel.com; drc@linux.vnet.ibm.com; jerinj@marvell.com; > Honnappa Nagarahalli ; nd > Subject: Re: [PATCH v6] eal: add cache-line demote support >=20 > On Tue, Oct 13, 2020 at 02:59:24AM +0000, Ruifeng Wang wrote: > > > > > -----Original Message----- > > > From: Omkar Maslekar > > > Sent: Monday, October 12, 2020 6:20 PM > > > To: dev@dpdk.org > > > Cc: bruce.richardson@intel.com; ciara.loftus@intel.com; > > > omkar.maslekar@intel.com; drc@linux.vnet.ibm.com; > > > jerinj@marvell.com; Ruifeng Wang ; > Honnappa > > > Nagarahalli > > > Subject: [PATCH v6] eal: add cache-line demote support > > > > > > rte_cldemote is similar to a prefetch hint - in reverse. > > > cldemote(addr) enables software to hint to hardware that line is like= ly to > be shared. > > > Useful in core-to-core communications where cache-line is likely to > > > be shared. ARM and PPC implementation is provided with NOP and can > > > be added if any equivalent instructions could be used for > > > implementation on those architectures. > > > > > > Signed-off-by: Omkar Maslekar > > > Acked-by: Bruce Richardson > > > > > > --- > > > v6: marked rte_cldemote as experimental > > > added rte_cldemote call in existing app/test_prefetch.c > > > > > > v5: documentation updated > > > fixed formatting issue in release notes > > > added Acked-by: Bruce Richardson > > > * > > > v4: updated bold text for title and fixed margin in release notes > > > * > > > v3: fixed warning regarding whitespace > > > * > > > v2: documentation updated > > > --- > > > --- > > > > > > +/** > > > + * Demote a cache line to a more distant level of cache from the > processor. > > > + * > > > + * CLDEMOTE hints to hardware to move (demote) a cache line from > > > +the closest to > > > + * the processor to a level more distant from the processor. It is > > > +a hint and > > > + * not guarantee. rte_cldemote is intended to move the cache line > > > +to the more > > > + * remote cache, where it expects sharing to be efficient and to > > > +indicate that a > > > + * line may be accessed by a different core in the future. > > > + * > > > + * @param p > > > + * Address to demote > > > + */ > > > +static inline void > > > +__rte_experimental > > > > 1. Experimental tag is only needed in this file. Tags at other places c= an be > removed. >=20 > I'm not sure that is the case. The generic file is used when preparing th= e docs, > so the experimental tag needs to go there for the docs, but when actually > using the function in compiled code the "generic" version is unused. > Therefore we need the experimental tag there to trigger a build warning > about using the function if the appropriate ALLOW_EXPERIMENTAL_APIS flag > is not set. >=20 +David in cc. I learnt this from David's comment in thread: http://patches.dpdk.org/patch/61573/ "We only need it in the function prototype" Hi David, Can you comment if my understanding of experimental tag usage is correct? /Ruifeng > /Bruce