From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87B54A04B7; Wed, 14 Oct 2020 11:30:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72A191DDB7; Wed, 14 Oct 2020 11:30:36 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2087.outbound.protection.outlook.com [40.107.20.87]) by dpdk.org (Postfix) with ESMTP id 3BADF1DD9D for ; Wed, 14 Oct 2020 11:30:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VLQ4rLz/UcEH77zj41/y3xPUzeLG0Cn6OplZ1VwPaCc=; b=nhsIFyUpnMNMGRSj66d6w4hJxE7SDVYj5FJV1LveEekT7BT1c86LI3oV7sN29KbWm0tKW6qODUQrvsFW4AUOs10IGQ+0Jn2rX/xICqQ1s6NyMYv+5RHyLMdRsE9hcEfbjUC12YN6FSE/EsMm77f/8jRiosjau7HwzAmQeRYum1o= Received: from AM6P195CA0094.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::35) by HE1PR0802MB2523.eurprd08.prod.outlook.com (2603:10a6:3:e1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.28; Wed, 14 Oct 2020 09:30:33 +0000 Received: from AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::cf) by AM6P195CA0094.outlook.office365.com (2603:10a6:209:86::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Wed, 14 Oct 2020 09:30:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT058.mail.protection.outlook.com (10.152.17.48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Wed, 14 Oct 2020 09:30:33 +0000 Received: ("Tessian outbound c579d876a324:v64"); Wed, 14 Oct 2020 09:30:32 +0000 X-CR-MTA-TID: 64aa7808 Received: from e26972efb226.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5F76F199-238D-4BD0-952B-A3A6A6F2374B.1; Wed, 14 Oct 2020 09:30:27 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e26972efb226.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 14 Oct 2020 09:30:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GUnmNzWz55QYhzH0es6T5eVv+uk4DORll+zDAUpPS/EzY9eM8nPj42aEP6PJxVW5CeFAJMy7a9cJIXiaHLXUZO6XRyluqent/ui4Dd8Y/4w/qUMFpJk/LZCdZFDsqPt2G4mXL7fckmFYJ27axA7lgFb04H+WIKBAv2/Kd5BLkPWzOj/3Po0ycZR1bfVx9qUCdSNKrVAhfeW3LVll/b/+ox14OgB5vCDu8EgZROWExSbtSvQm437IInCDAg+K6dJjN6afzw8a6ATjC7ShWzNvMiQDMApSxp80aquH1bQ8/x1vGsA/v7imcPUoVPATUloFtRLtLi4oeXYu/UqZRLN72A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VLQ4rLz/UcEH77zj41/y3xPUzeLG0Cn6OplZ1VwPaCc=; b=MZJNYbTAfQdw+SxEkE6bcRuZ5tNToyMIDExfqWG+25+6zWFkHXjYfyZPjaaYn8CG/ua2FuFKalRm4vVCBZsVH4pqeYwPzCYddli1mxT/Gti7hsFGNFSr8mY6AKhFkuEPJIDyjcZ9KABrEFVqzDltVtZsi1yiqvWgLZMzKErqIAKQl0ckwB3JUAKrF8C+gfPdK+wRimQHae1hdf668xpS9lMuhH/T2LgahDEkE36nR0UZtJzAiAktztqdu5bbVwU7ktnBvl4XSNGaeH3HxSXpreX5RyG7CRaksteRi66f+CQ3Pdi4/kOKC8jjHGUlUHjtNetQv6WG9K8RR3VwkNhrUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VLQ4rLz/UcEH77zj41/y3xPUzeLG0Cn6OplZ1VwPaCc=; b=nhsIFyUpnMNMGRSj66d6w4hJxE7SDVYj5FJV1LveEekT7BT1c86LI3oV7sN29KbWm0tKW6qODUQrvsFW4AUOs10IGQ+0Jn2rX/xICqQ1s6NyMYv+5RHyLMdRsE9hcEfbjUC12YN6FSE/EsMm77f/8jRiosjau7HwzAmQeRYum1o= Received: from VI1PR0802MB2351.eurprd08.prod.outlook.com (2603:10a6:800:a0::10) by VI1PR0802MB2574.eurprd08.prod.outlook.com (2603:10a6:800:ae::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.28; Wed, 14 Oct 2020 09:30:26 +0000 Received: from VI1PR0802MB2351.eurprd08.prod.outlook.com ([fe80::14d4:6ade:368a:204b]) by VI1PR0802MB2351.eurprd08.prod.outlook.com ([fe80::14d4:6ade:368a:204b%3]) with mapi id 15.20.3455.031; Wed, 14 Oct 2020 09:30:26 +0000 From: Ruifeng Wang To: David Marchand , "dev@dpdk.org" , "radu.nicolau@intel.com" CC: "jerinj@marvell.com" , Jan Viktorin , Bruce Richardson , Konstantin Ananyev , nd Thread-Topic: [PATCH] eal: add experimental tags for write combining store Thread-Index: AQHWogI47obEVUxTa0qszuCCmQ+lU6mW1RyA Date: Wed, 14 Oct 2020 09:30:26 +0000 Message-ID: References: <20201014081430.31349-1-david.marchand@redhat.com> In-Reply-To: <20201014081430.31349-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 728EF20F2A4F4248BEB3FD6CDA09126B.0 x-checkrecipientchecked: true Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 09f1e895-efae-4757-e5b4-08d87023cc99 x-ms-traffictypediagnostic: VI1PR0802MB2574:|HE1PR0802MB2523: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5236;OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BesUntZrfUjumggt3WQwrAmf2+sRyWbcOye+MeHtt9XHcP3V9Jylp5x/4orCWTph4D3ogJJETksoB6uMI5Qv4RQ4wtkgVAlzww2DVFOAZPbmuMpgteN4x/YJZ15R2++4oFqPHMza3Dw/1IQ7F8JDE81mtlfxOUl0PqMQpO3Pwy39ZF8O288OQRe9XaFC+EaSgk1H6fQdcF1wgYaKwTy+xMb/tQbfSu/k6ywOOuWVteZAaDFuR3TMlcW+BX9N/nyp3WAd1LpOnaP9DROQexNb1BWhO+FqHEOCTlWTa5+D1e+2Prsx+dLfqUeROYHLNu73 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0802MB2351.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(316002)(53546011)(6506007)(8936002)(86362001)(4326008)(33656002)(83380400001)(186003)(478600001)(110136005)(26005)(2906002)(54906003)(66476007)(66556008)(9686003)(64756008)(52536014)(5660300002)(66446008)(8676002)(66946007)(76116006)(71200400001)(55016002)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: c/fStcM0/6bsWylJjeA/6jaoByOKpTrw1jl/SN6t8h1HgxRfR7CyHst/E3p2mtHRfilvhOf5psz1amQS4GhO0UdsczllK9nBAmZoRLUOnvIM7HyZTmKMce1Li+xBVLR8YlxfXL3sGgZBwX0O8H5hEnTIqNuyZBOr2YCQ6OHvUN4SkT7vhNLtVPaK68a1XxK0Z2RU+unkL/MMyAlDB+zQI8+xKeuR3F/nuQ7W5fD2uPZ8e10e3pE2JgowWQ2zxmnooIS3JtJfzuSoAiHAiBqybf3BVR/+BZJAH26RBpudN4i3pS5T8DTcxZb24WNK7UWIvOVQDVYN30oLVr9IX+ZEgSm8aLNSDG9IVoX/3H+UxTV+LQI3bq2FbMw/+L7auYAQ1xvzcKzIOSXX/HL0eS4V4p65zExJctNA9te6Nq5GT6SO91XzZ+93xpM99GnaQh5p9vqgsoFGL0Mg/5/U9o3NP7hWCKaqUY+hylmO0VUsveGHLfXqF7FvsNBZfsGU0/7jou2N/gmSqt5+6/fVuClv0FBGHj8tfKh6qjU3ipQcD/WA+7YuhwQGQEB2ZF7giD2ZpvuhT7l3jeIKwRthIRyj0XC9NS7Q3WiN/CJzUNFTGDWerYGZd3RLvniqaV6dKYEOfuOV2pJUSgJ4a2UqxEXyKA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2574 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 24e83dc8-cf7a-4162-870f-08d87023c87e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZgPXkgaYX6LG4LKVXZ9NpBZpg12Zhxp3vKIm10pMEjUbGCUTFGL2VKKiqv+I5m+uJTUp673xmE/mUo04UON/TKp6lsYSZt/s/Xfhz5PiwsCS7N5+buHfZsT8Qmi2aZHEdYYGUZ8AgmP89OudszsnIUK94N/j1dkTut0S7RPt5uJbUYdAsHo0h5adLhjSGF9+FEYeuP/vE+HuNEW/iR2fJW7Ami4i2ewLSH8mEvWPZBcUrkESP/aBM2OaoXlRq2QCZeLDjBt3P3txu2yiyjd6Km2cwaphLGQ/Fh0RknuIC/soozrn/A0b6wwObc3FD5hYFcnuMgO4NZX45x5OjC8FJmVNrHt2gttqkeT+AOPTV6Vqo57+0q9fQcrLFnL/lB31ZoAxM8PzmcxZr2agZT8xug== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(346002)(376002)(46966005)(55016002)(5660300002)(70586007)(86362001)(47076004)(316002)(356005)(82310400003)(478600001)(8676002)(83380400001)(336012)(186003)(82740400003)(7696005)(81166007)(33656002)(36906005)(110136005)(54906003)(53546011)(52536014)(9686003)(26005)(70206006)(4326008)(8936002)(2906002)(6506007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2020 09:30:33.1115 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09f1e895-efae-4757-e5b4-08d87023cc99 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2523 Subject: Re: [dpdk-dev] [PATCH] eal: add experimental tags for write combining store X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: David Marchand > Sent: Wednesday, October 14, 2020 4:14 PM > To: dev@dpdk.org; radu.nicolau@intel.com > Cc: jerinj@marvell.com; Ruifeng Wang ; Jan > Viktorin ; Bruce Richardson > ; Konstantin Ananyev > > Subject: [PATCH] eal: add experimental tags for write combining store >=20 > Only marking the doxygen declarations is not enough. > Arch specific implementations must be tagged as well since there is no > common declaration of those inlines. >=20 > Fixes: 8a00dfc738fe ("eal: add write combining store") >=20 > Signed-off-by: David Marchand > --- > lib/librte_eal/arm/include/rte_io_64.h | 2 ++ > lib/librte_eal/x86/include/rte_io.h | 9 +++++++++ > 2 files changed, 11 insertions(+) >=20 > diff --git a/lib/librte_eal/arm/include/rte_io_64.h > b/lib/librte_eal/arm/include/rte_io_64.h > index d07d9cb226..f9a1f10ce7 100644 > --- a/lib/librte_eal/arm/include/rte_io_64.h > +++ b/lib/librte_eal/arm/include/rte_io_64.h > @@ -164,12 +164,14 @@ rte_write64(uint64_t value, volatile void *addr) > rte_write64_relaxed(value, addr); > } >=20 > +__rte_experimental > static __rte_always_inline void > rte_write32_wc(uint32_t value, volatile void *addr) { > rte_write32(value, addr); > } >=20 > +__rte_experimental > static __rte_always_inline void > rte_write32_wc_relaxed(uint32_t value, volatile void *addr) { diff --gi= t > a/lib/librte_eal/x86/include/rte_io.h b/lib/librte_eal/x86/include/rte_io= .h > index c035eecc6a..730f958758 100644 > --- a/lib/librte_eal/x86/include/rte_io.h > +++ b/lib/librte_eal/x86/include/rte_io.h > @@ -28,6 +28,7 @@ __rte_x86_movdiri(uint32_t value, volatile void *addr) > : "a" (value), "d" (addr)); > } >=20 > +__rte_experimental > static __rte_always_inline void > rte_write32_wc_relaxed(uint32_t value, volatile void *addr) { @@ -47,11 > +48,19 @@ rte_write32_wc_relaxed(uint32_t value, volatile void *addr) > } > } >=20 > +__rte_experimental > static __rte_always_inline void > rte_write32_wc(uint32_t value, volatile void *addr) { > + /* gcc complains about calling this experimental function even > + * when not using it. Hide it with ALLOW_EXPERIMENTAL_API. > + */ > +#ifdef ALLOW_EXPERIMENTAL_API > rte_wmb(); > rte_write32_wc_relaxed(value, addr); > +#else > + rte_write32(value, addr); > +#endif > } >=20 > #ifdef __cplusplus > -- > 2.23.0 Reviewed-by: Ruifeng Wang