From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build
Date: Fri, 6 Nov 2020 01:40:46 +0000 [thread overview]
Message-ID: <VI1PR0802MB2351D428857C4995B90B47179EED0@VI1PR0802MB2351.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20201105153316.27918-1-dharmik.thakkar@arm.com>
> -----Original Message-----
> From: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Sent: Thursday, November 5, 2020 11:33 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; Dharmik Thakkar
> <Dharmik.Thakkar@arm.com>
> Subject: [PATCH 1/2] crypto/armv8: update meson build
>
> With pkg-config support available within AArch64crypto library, meson option
> 'armv8_crypto_dir' can be removed.
> PKG_CONFIG_PATH environment variable should be set appropriately to use
> the crypto library.
>
> Refer [1] for build instructions.
>
> [1]
> https://doc.dpdk.org/guides/cryptodevs/armv8.html
>
> Suggested-by: Thomas Monjalon <thomas@monjalon.net>
> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> drivers/crypto/armv8/meson.build | 19 ++++---------------
> meson_options.txt | 2 --
> 2 files changed, 4 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/crypto/armv8/meson.build
> b/drivers/crypto/armv8/meson.build
> index c445c5bd3dfd..3289a2adcac5 100644
> --- a/drivers/crypto/armv8/meson.build
> +++ b/drivers/crypto/armv8/meson.build
> @@ -1,24 +1,13 @@
> # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Arm Limited
>
> -path = get_option('armv8_crypto_dir')
> -if path == ''
> +dep = dependency('libAArch64crypto', required: false) if not
> +dep.found()
> build = false
> - reason = 'missing dependency, "armv8_crypto"'
> + reason = 'missing dependency, "libAArch64crypto"'
> subdir_done()
> endif
>
> -inc_dir = path
> -
> -lib = cc.find_library('libAArch64crypto', dirs: [path], required: false) -if not
> lib.found()
> - build = false
> - reason = 'missing dependency, "AArch64crypto"'
> - subdir_done()
> -else
> - ext_deps += lib
> - includes += include_directories(inc_dir)
> -endif
> -
> +ext_deps += dep
> deps += ['bus_vdev']
> sources = files('rte_armv8_pmd.c', 'rte_armv8_pmd_ops.c') diff --git
> a/meson_options.txt b/meson_options.txt index
> 9bf18ab6b1c9..e384e6dbb29e 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -1,7 +1,5 @@
> # Please keep these options sorted alphabetically.
>
> -option('armv8_crypto_dir', type: 'string', value: '',
> - description: 'path to the armv8_crypto library installation directory')
> option('disable_drivers', type: 'string', value: '',
> description: 'Comma-separated list of drivers to explicitly disable.')
> option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
> --
> 2.17.1
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
prev parent reply other threads:[~2020-11-06 1:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:33 Dharmik Thakkar
2020-11-05 15:33 ` [dpdk-dev] [PATCH 2/2] doc: update build guide for armv8 crypto PMD Dharmik Thakkar
2020-11-06 1:39 ` Ruifeng Wang
2020-11-05 16:11 ` [dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build Bruce Richardson
2020-11-13 9:29 ` Thomas Monjalon
2020-11-13 9:39 ` Thomas Monjalon
2020-11-06 1:40 ` Ruifeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0802MB2351D428857C4995B90B47179EED0@VI1PR0802MB2351.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=Dharmik.Thakkar@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).