From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E641DA00E6 for ; Fri, 12 Jul 2019 11:32:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 061891B9C7; Fri, 12 Jul 2019 11:32:43 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20082.outbound.protection.outlook.com [40.107.2.82]) by dpdk.org (Postfix) with ESMTP id 80AB31B9C6; Fri, 12 Jul 2019 11:32:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bTtF8HnVPRBDt+9KvInE6C7iPc4P0MWfSihBBf/Hk7WNrF6V049YBkDBzMR+UyYbm195f4VZtEuqY/8LHpNDXngmSUOnQRIsjR2+Ltbqx0mWE8Qs67bGOjBIsiYK/jieL8QcmwiesKE3gXMsdDzd1pCY5MiJDWHZd6K3ucIZmz1+IAbvniitHxlFwLPbBQrQIeY+ThqlsbByUAN417tnNZHS0jgWO5ql1Lu4xXmhc/seFK/1sG4SQ6SzAfloEMRnw/cdGsqlBfy6JLt6SUy9zJU6FFpaVr256/JH36tl3Ns1o5Wndoh59Tot+toXOznnILn5Mlri3ORHqgb1LYy5zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wx+qUtDKsvZtBSCeDtJFOh42pJkl20zk+A90l/Kpf9U=; b=WchGSDA3V+0u64Q0bYqCNLmsxn3dIv43DhF0IXtTck13nH6U2UTUSYkkuPHnGMjK2QV1LNJkiJ8ch7hwmOj4/Fxfo0OFDoGxeGr3sC//ns+LRek3soNRhfey2FIQN5iOirr29DE6RbbqWQW55RnRCz6Zo7fyjCWYjPAYYUn1/OEpjpiFUM56SHtM73jtzDWP/OvdkvumWBQu/fT3+kcx3946bfS7pY+NjWt6k1/3R6wZv7JKu7Mz7eQAVD9os1M4JyFTcHXbJjzH3B/hVSdHuNQ6HO7Bm4JzVgAiaws11HO6VIuW9TXnihP903JBrN5qO/IgCiUVd6C8UFpN7oftZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wx+qUtDKsvZtBSCeDtJFOh42pJkl20zk+A90l/Kpf9U=; b=y3EOEcNnKD7P1FzQiFwOMD/Sb9rCfZ2tnTomlSLQlytmR0ev08aQ4wU//5NyyPM0KWLZ3sFVI8E1eKwSkdkv7kHcylUwvjWO+vwHjvY/wqknvPuJ2eWqz8z56Zffip1X2oeUxwtFv//DCdt+TwbTWvcM3fAksMviqq0Bx4DKJp8= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB4560.eurprd08.prod.outlook.com (20.179.28.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Fri, 12 Jul 2019 09:32:39 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::5c6f:a70a:a1d7:5d65]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::5c6f:a70a:a1d7:5d65%5]) with mapi id 15.20.2052.020; Fri, 12 Jul 2019 09:32:39 +0000 From: "Gavin Hu (Arm Technology China)" To: "thomas@monjalon.net" CC: "dev@dpdk.org" , Olivier Matz , nd , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "Nipun.gupta@nxp.com" , Honnappa Nagarahalli , "i.maximets@samsung.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use Thread-Index: AQHU2t/X3hxWBTBOakC52QaVFHDc4Ka7N7AZgAw7AzA= Date: Fri, 12 Jul 2019 09:32:39 +0000 Message-ID: References: <20181212062404.30243-1-gavin.hu@arm.com> <1552620686-10347-2-git-send-email-gavin.hu@arm.com> <20190329141755.ziopuvhepdi372aa@platinum> <2965897.HCpMyYeHc3@xps> In-Reply-To: <2965897.HCpMyYeHc3@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: e1b377e7-26a4-4f4f-850f-cf15a406ca25.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2132528d-279e-41b1-2bbd-08d706abe1e4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB4560; x-ms-traffictypediagnostic: VI1PR08MB4560: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 00963989E5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(199004)(189003)(13464003)(256004)(6916009)(229853002)(14454004)(68736007)(25786009)(76116006)(5660300002)(74316002)(71200400001)(66946007)(64756008)(66556008)(66446008)(52536014)(66476007)(486006)(71190400001)(478600001)(2501003)(86362001)(6246003)(53936002)(7736002)(305945005)(186003)(4326008)(1730700003)(8676002)(53546011)(6506007)(9686003)(5640700003)(55236004)(102836004)(6436002)(55016002)(66066001)(476003)(316002)(446003)(33656002)(11346002)(81156014)(99286004)(8936002)(81166006)(26005)(76176011)(2906002)(3846002)(6116002)(2351001)(54906003)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4560; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: yU0JqJaW9Hbwp5niyOhAJxViYfKSlPokN5p3wxDaLHTQPXFRcUHCNDN5EC6lsChi3hCM12a1i5kfvbxrMT149X0HCBn0fOr2enJtbhG/lDVz/YaiBR9Y3KORBi/Nvw60riNPfBxv1+VWc9bpIqKDVFx//Bu+HgNYCoD3YNuQY4F664US7o8yiPGpsyoI6yB9gTMJsEOr9uMRojIl/tmtQ2Mtok/m+8H7K3L9kNstBc8vmn9DUcPZn36/d/A94uDBsV4rVolxsJAgtE4xpd6x0T1x/joWkuqPylkqsHWMyUGbz9lz4kaUoPyjwdEWTi59D/U9/j/6hLiua+gRTE8eVpC4N9HREQF8diJZGtq7fO2xDhj7ObLgSYkvPRx8TSE7wFQ2ExGnpE9KxAjKwITCCID0IETsCh6lF4gxTw6NvTQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2132528d-279e-41b1-2bbd-08d706abe1e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2019 09:32:39.1997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gavin.Hu@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4560 Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Olivier and Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, July 4, 2019 10:42 PM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; Olivier Matz ; nd > ; jerinj@marvell.com; hemant.agrawal@nxp.com; > Nipun.gupta@nxp.com; Honnappa Nagarahalli > ; i.maximets@samsung.com; > stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the r= ing > when not in use >=20 > 29/03/2019 15:17, Olivier Matz: > > Hi, > > > > On Fri, Mar 15, 2019 at 11:31:25AM +0800, Gavin Hu wrote: > > > Currently, the flush is done by dequeuing the ring in a while loop. I= t is > > > much simpler to flush the queue by resetting the head and tail indice= s. > > > > > > Fixes: af75078fece3 ("first public release") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Gavin Hu > > > Reviewed-by: Ruifeng Wang > > > Reviewed-by: Honnappa Nagarahalli > > > --- > > > --- a/lib/librte_ring/rte_ring_version.map > > > +++ b/lib/librte_ring/rte_ring_version.map > > > @@ -17,3 +17,10 @@ DPDK_2.2 { > > > rte_ring_free; > > > > > > } DPDK_2.0; > > > + > > > +EXPERIMENTAL { > > > + global: > > > + > > > + rte_ring_reset; > > > + > > > +}; > > > > To me, a static inline function does not need to be added in > > rte_ring_version.map (or is it due to a check script checking the > > __rte_experimental tag ?). I found at least one commit where it > > is not the case: > > c277b34c1b3b ("mbuf: add function returning buffer address") > > > > There are 2 options: > > 1- remove the rte_ring_version.map part of the patch. > > 2- change the static inline function into a standard function. > > > > I would prefer 2-, because it allows to keep an api/abi compat > > layer in the future. >=20 > There are no news about this patch. > I classify it as changes requested. >=20 Sorry for missed your comments for long time, I just submitted v8. I took the first option as it is in the data path and to keep consistent to= its neighboring functions.=20