From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92B20A318B for ; Fri, 18 Oct 2019 11:01:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 634391C10C; Fri, 18 Oct 2019 11:01:47 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30084.outbound.protection.outlook.com [40.107.3.84]) by dpdk.org (Postfix) with ESMTP id E2BD11C0CB for ; Fri, 18 Oct 2019 11:01:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Koe3GWASczMztE29t05Eqerm02n6zoPb8ls1ZGndlQ=; b=sy92Wcy/lcuNcZtunQ33V5yw+zsc6QaHgdl4JG366oS9nQ/vRkE9Yz//QXu0ZMymO0f1JuDxs0a6Fo+7DNiszEslz7fvkK+3/YazUN7Dd0WvVRm8ngY2D6cL3EX8tk9ekRU3O0dXPzrnWf5IoCFH6lR7oWWTJFHCSSCupn2MLXI= Received: from VI1PR0801CA0081.eurprd08.prod.outlook.com (2603:10a6:800:7d::25) by VI1PR08MB4573.eurprd08.prod.outlook.com (2603:10a6:803:e3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Fri, 18 Oct 2019 09:01:42 +0000 Received: from DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::209) by VI1PR0801CA0081.outlook.office365.com (2603:10a6:800:7d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2347.16 via Frontend Transport; Fri, 18 Oct 2019 09:01:40 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT054.mail.protection.outlook.com (10.152.20.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Fri, 18 Oct 2019 09:01:39 +0000 Received: ("Tessian outbound 851a1162fca7:v33"); Fri, 18 Oct 2019 09:01:32 +0000 X-CR-MTA-TID: 64aa7808 Received: from cbc05a3b535d.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.10.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id C302A96F-65FE-4D26-BF6C-E14977D6117E.1; Fri, 18 Oct 2019 09:01:27 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2053.outbound.protection.outlook.com [104.47.10.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cbc05a3b535d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 18 Oct 2019 09:01:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FfHgSib7evDOtfvp8xncSs3KLLLmeO95vwVQPGr0o2b1/6PF5k7Fw8Gu798jkNFtEvIByr1+d52paBqCQ/1JA/j8XHTaAT6M1560F4nA86h5HnuvvVi7aaQh6og49SM19t0sUqW0MSN6YZ2k9CW7Yd3Q1ye17y48sy0aWaFSP1n7o4tWmRHaZsR6IPPs7dn7ME2Zim2qsY0b96uRezzH1Pv5r8QmuFw32xOzpD8u149wowTa+oc+W7ZgFa8iN/B4vDx5eS9e3Zd2S+xfa4eQs9r9MUDQZ2btVwAF3VnjtSNxDZG2DXnRaH6Uvu02skiSctxxrK6RYN0EnkmYH9yjug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Koe3GWASczMztE29t05Eqerm02n6zoPb8ls1ZGndlQ=; b=CRjzdly34fl+p1AlUhNMj/DLQuWf8oiRGFuZqrpnVnxkbnNqyG43b/48jOYyVqu7+IDE4JAKs+GdFva2agViM8Qp2jZyj7mjp924fKOWrOGZuh1nXbUe4Y8JFf7mu9Pl+kAn21YOdmHXVOxh28yKRNODIb6eCXWqHv9eLT/rs9skrNF3m9nxW4yQD8UB0lRE7jB7LNrOvXvlwAMmTx9Dw51JDrbQmv9yUymcJxeSnkb14cvKisMt35307z9LChQlb7OyWWCpziG98SidTUUT7i+p2LgWjx850WgL3ZrR1xxMj+80QYy21WYn1boCe72ozqOmL8u4dAS5rnD/LPWeTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Koe3GWASczMztE29t05Eqerm02n6zoPb8ls1ZGndlQ=; b=sy92Wcy/lcuNcZtunQ33V5yw+zsc6QaHgdl4JG366oS9nQ/vRkE9Yz//QXu0ZMymO0f1JuDxs0a6Fo+7DNiszEslz7fvkK+3/YazUN7Dd0WvVRm8ngY2D6cL3EX8tk9ekRU3O0dXPzrnWf5IoCFH6lR7oWWTJFHCSSCupn2MLXI= Received: from VI1PR08MB3981.eurprd08.prod.outlook.com (20.178.126.10) by VI1PR08MB4334.eurprd08.prod.outlook.com (20.179.27.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.21; Fri, 18 Oct 2019 09:01:24 +0000 Received: from VI1PR08MB3981.eurprd08.prod.outlook.com ([fe80::6054:666f:997c:1a68]) by VI1PR08MB3981.eurprd08.prod.outlook.com ([fe80::6054:666f:997c:1a68%5]) with mapi id 15.20.2347.024; Fri, 18 Oct 2019 09:01:24 +0000 From: "Joyce Kong (Arm Technology China)" To: Stephen Hemminger CC: "dev@dpdk.org" , nd , "thomas@monjalon.net" , "jerinj@marvell.com" , "ravi1.kumar@amd.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" Thread-Topic: [dpdk-dev] [PATCH v1 0/5] implement common rte bit operation APIs in PMDs Thread-Index: AQHVg3jjauwczYP1fEuIvYEFGAothadgHhjg Date: Fri, 18 Oct 2019 09:01:24 +0000 Message-ID: References: <1571125801-45773-1-git-send-email-joyce.kong@arm.com> <20191015095113.7b25eb80@hermes.lan> In-Reply-To: <20191015095113.7b25eb80@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: cf167a86-70fb-4ac1-ba0c-c79ab93ce8db.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Joyce.Kong@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 4a98a7d4-a43f-4e9a-707d-08d753a9c9c6 X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VI1PR08MB4334:|VI1PR08MB4334:|VI1PR08MB4573: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1247;OLM:1247; x-forefront-prvs: 01949FE337 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(346002)(396003)(39860400002)(376002)(13464003)(199004)(189003)(54906003)(64756008)(26005)(76116006)(102836004)(66066001)(8676002)(7416002)(7736002)(4326008)(66946007)(71200400001)(71190400001)(74316002)(66476007)(9686003)(229853002)(256004)(478600001)(55236004)(2906002)(66556008)(86362001)(66446008)(5660300002)(6506007)(52536014)(53546011)(6916009)(11346002)(7696005)(446003)(186003)(14454004)(25786009)(76176011)(33656002)(3846002)(55016002)(99286004)(8936002)(6246003)(305945005)(6436002)(316002)(81156014)(6116002)(486006)(81166006)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4334; H:VI1PR08MB3981.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: w8rNhrel46f54iHUZ0e3pUSCnStTYMBgkdBOQE9ZH3utiKCIe22wmRGgJZS6jP3IZ+QvaZLSKuoux0zD6qGdXBT6uAoLeLKeS8p4mirOnsJLuUEuKRZBLuggfAPTnwlh+moe5Eg6Oj7C5KBLJEGZmGEwlQNOYG/23PGHs+h9lCmfbnK+nSpMmk7f3ZDtmcwAfqYqABjLpINPTp3ydNhhSBuhpk8eIJsAjSoREqGfk6nJ2sGfskxFfDhsJIzqGUVXfo7aagK9Jon611D46u7BAbLJaISw6KJZ/lNKCuk3DCLnOGyXu9XSg/4BWE9G8TPqi9L7DrcIqyVv0BchzUs6P0yofQqRAqKROt0lYghq1SPTUHs9+KAHHDRuDcmNsJznRMsX9KE7pmCtYlu+875fQq3NcpHNAleDRNsbDbKjXik= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4334 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Joyce.Kong@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(396003)(39860400002)(136003)(13464003)(189003)(199004)(50466002)(55016002)(74316002)(7736002)(66066001)(47776003)(6862004)(336012)(9686003)(22756006)(305945005)(46406003)(76130400001)(70206006)(25786009)(4326008)(33656002)(229853002)(70586007)(23726003)(76176011)(486006)(2906002)(478600001)(476003)(8746002)(97756001)(126002)(6116002)(3846002)(81166006)(356004)(8676002)(99286004)(7696005)(81156014)(11346002)(14454004)(26005)(446003)(86362001)(54906003)(186003)(63350400001)(6246003)(8936002)(5660300002)(6506007)(53546011)(102836004)(316002)(52536014)(26826003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4573; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: db888b73-1ffb-4145-3435-08d753a9c0cb NoDisclaimer: True X-Forefront-PRVS: 01949FE337 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aV8K3BZet4SWNuj/CaQEg6acDohfja94/fEPwWFeOm0b4YgHPsjoJmi/2Y+BCkCShlgk6rOjRKW0kLYrf2ad7NeVuWsTkeMVV+mvmXvqzEF/rTjmAeDtstetYy2mXfAe20tEtvGQnzmyjyrxIGajqnuHUXnSWieKZ1+4/Omu6N4iqCbL2mMKfcXS/hADKgW1NVbow3oDfISe6eXWKiAHPD/NsiDH3yKB0w3PKI2gME1Zhs6SUDiUG4ulmIt7uZi59+31F2qPy/Y78lIpv1mbCuYKQPU+PeSGw3v/UqxZssAieBkoFaiSdj1iPctpMynU4w8fC816ch3vKyQ61OATQ1Ia7gafWaoFEHUwl6oVd1AWbLxiMIa2wZto6Uyo9P1zCsf3f3BuX2otH4jR512Z7b2dWc1f2geG5p0/MqIpGSM= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2019 09:01:39.5457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a98a7d4-a43f-4e9a-707d-08d753a9c9c6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4573 Subject: Re: [dpdk-dev] [PATCH v1 0/5] implement common rte bit operation APIs in PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, October 16, 2019 12:51 AM > To: Joyce Kong (Arm Technology China) > Cc: dev@dpdk.org; nd ; thomas@monjalon.net; > jerinj@marvell.com; ravi1.kumar@amd.com; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; > rmody@marvell.com; shshaikh@marvell.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > > Subject: Re: [dpdk-dev] [PATCH v1 0/5] implement common rte bit operation > APIs in PMDs >=20 > On Tue, 15 Oct 2019 15:49:56 +0800 > Joyce Kong wrote: >=20 > > There are a lot functions of bit operations scattered in PMDs, > > consolidate them into a common API family and applied in different > > PMDs to reduce code duplication. > > > > Joyce Kong (5): > > lib/eal: implement the family of rte bit operation APIs > > net/axgbe: use common rte bit operation APIs instead > > net/bnx2x: use common rte bit operation APIs instead > > net/hinic: use common rte bit operation APIs instead > > net/qede: use common rte bit operation APIs instead > > > > drivers/net/axgbe/axgbe_common.h | 29 +---- > > drivers/net/axgbe/axgbe_ethdev.c | 14 +- > > drivers/net/axgbe/axgbe_mdio.c | 14 +- > > drivers/net/bnx2x/bnx2x.c | 202 +++++++++++++--------= -------- > > drivers/net/bnx2x/bnx2x.h | 5 +- > > drivers/net/bnx2x/ecore_sp.h | 8 +- > > drivers/net/hinic/base/hinic_compat.h | 35 +---- > > drivers/net/hinic/hinic_pmd_ethdev.c | 16 +-- > > drivers/net/qede/base/bcm_osal.c | 20 --- > > drivers/net/qede/base/bcm_osal.h | 10 +- > > lib/librte_eal/common/Makefile | 1 + > > lib/librte_eal/common/include/rte_bitops.h | 56 ++++++++ > > lib/librte_eal/common/meson.build | 1 + > > 13 files changed, 180 insertions(+), 231 deletions(-) create mode > > 100644 lib/librte_eal/common/include/rte_bitops.h > > >=20 >=20 > This is a really good idea, and should have been done long ago. > Could you add tests for these as well? Yes. Will add some tests for these APIs in next version.