From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39FD6A0562; Thu, 2 Apr 2020 09:20:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A15781BEA6; Thu, 2 Apr 2020 09:20:52 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70071.outbound.protection.outlook.com [40.107.7.71]) by dpdk.org (Postfix) with ESMTP id CBE441BE99 for ; Thu, 2 Apr 2020 09:20:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eEICPkDvuzZlbR13O15w58GbrzfQe4upUQdbo9Zi5/g=; b=GPmPti/mDDSBvYByGK8ZKYUCKNaZQiIUC/s5Em2Tq0sUKFB8GfmSlooodzzRzZ3QIg4NvuP59eu7rEbDiAmiK5KvduA34lYFgfMWwxDa0Xq8W/iFIxgf6H5WAGkXpU4spnwhCJycpgOJC+TlcohQSoYPduPpXiHWbWI0ClCSIPw= Received: from DBBPR09CA0034.eurprd09.prod.outlook.com (2603:10a6:10:d4::22) by AM0PR08MB3555.eurprd08.prod.outlook.com (2603:10a6:208:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Thu, 2 Apr 2020 07:20:44 +0000 Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:d4:cafe::fe) by DBBPR09CA0034.outlook.office365.com (2603:10a6:10:d4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15 via Frontend Transport; Thu, 2 Apr 2020 07:20:44 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Thu, 2 Apr 2020 07:20:44 +0000 Received: ("Tessian outbound eadf07c3b4bb:v50"); Thu, 02 Apr 2020 07:20:43 +0000 X-CR-MTA-TID: 64aa7808 Received: from a2d6c8dbf081.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FE5EC1D6-9911-4BD2-9057-605814D1C69A.1; Thu, 02 Apr 2020 07:20:38 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a2d6c8dbf081.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Apr 2020 07:20:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1Q/bIdTC536YR1ZvuDggcgNRZSmCx7ZEovKrvMLKIIZyDkaQ5PMCaxAjE1AySH1TA4pn5NzdSt+oLHBu3KOujj9VultRR+uMhpJf3ij2jS2YTOarSKaLi96/fElXKm/6YMmxTWK/htE4/2isICmqcuvwSoFwUXniaBVn/2VNWHqSYQ1nU4PJYwoVLgwoyeNWuBfGEGAn3xLL1YFAAPa0m5G6zIXKmIKabSK4XXvbyQCx4Z3nmSbcNKS98Zywuk52eh1Pu1nzVSwM0UKUi/Y7GArff9TRxN9i0Qoihp9tOf5bAkfII3pbFmGRxf6EgNiPPTJHW4YfR7tO9WKiRfoQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eEICPkDvuzZlbR13O15w58GbrzfQe4upUQdbo9Zi5/g=; b=PYtT81zIliIJ7g8M9kZ2LJFLta0FpOo9fTgqG2i0AY3xRGw8pZpxIHpSWwxCHwOW2PgPJwRUi/4LvyQ081VgCSFPT92abFLDk8NPJfOIbYyt5CN0oXiSQitIfU36+6m8+EeeAYtSKKnHAqoCQlBvDkTLERgK07FyUwODUCZpuHl0eW6zpPGlmGFleTj3tLAkrfCftPwe4F0MD4hBhHJJ1/UyH6X3D5wga0uIXeL/BEmzMEObPd4maDqmJhQNwgKlcah95lPE1u2cHuzZgR4jtrrGJV+/9Bq6DdtYFjJz9wGbJkstevQP/zpBDkYLaD9cOdB+MCQemE77zOt4/mdb4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eEICPkDvuzZlbR13O15w58GbrzfQe4upUQdbo9Zi5/g=; b=GPmPti/mDDSBvYByGK8ZKYUCKNaZQiIUC/s5Em2Tq0sUKFB8GfmSlooodzzRzZ3QIg4NvuP59eu7rEbDiAmiK5KvduA34lYFgfMWwxDa0Xq8W/iFIxgf6H5WAGkXpU4spnwhCJycpgOJC+TlcohQSoYPduPpXiHWbWI0ClCSIPw= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (10.255.196.79) by VI1PR08MB2813.eurprd08.prod.outlook.com (10.170.237.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Thu, 2 Apr 2020 07:20:35 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::a0e2:2a9f:be7b:4b15]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::a0e2:2a9f:be7b:4b15%3]) with mapi id 15.20.2878.016; Thu, 2 Apr 2020 07:20:35 +0000 From: Gavin Hu To: "thomas@monjalon.net" , Joyce Kong CC: "stephen@networkplumber.org" , "david.marchand@redhat.com" , "mb@smartsharesystems.com" , "jerinj@marvell.com" , "bruce.richardson@intel.com" , "ravi1.kumar@amd.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , Honnappa Nagarahalli , Phil Yang , nd , "dev@dpdk.org" , nd , nd Thread-Topic: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs Thread-Index: AQHV9fjDQIVqneGA9UyvXJPk6tDlY6hjbXwAgACh/ACAABkfgIABaCug Date: Thu, 2 Apr 2020 07:20:35 +0000 Message-ID: References: <20200309095410.28983-1-joyce.kong@arm.com> <1650352.esFFXGZ24q@xps> <1989157.0RtB02Ng89@xps> In-Reply-To: <1989157.0RtB02Ng89@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 582ab65b-fb5c-40b1-8ed6-c480af3d4034.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4004fef8-30d2-401b-6ddd-08d7d6d65b6c x-ms-traffictypediagnostic: VI1PR08MB2813:|VI1PR08MB2813:|AM0PR08MB3555: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 0361212EA8 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB5376.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(52536014)(64756008)(76116006)(966005)(71200400001)(7416002)(54906003)(110136005)(316002)(5660300002)(2906002)(8676002)(66446008)(86362001)(81156014)(66476007)(66556008)(55236004)(45080400002)(186003)(8936002)(6506007)(7696005)(33656002)(55016002)(26005)(53546011)(478600001)(66946007)(4326008)(6636002)(81166006)(9686003); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AMAVUs69gOa/OqWDI6b9YY07jw3wRE4Q4QIuRc6IduTBY0sY7QFgArISajvpNFbxBdAp9Q191wgcAjljM23cHQU0rcu7bKmqxXZzwRFTNmOTwy59nxP0gRxnMTqoUc1M/TFDs1k2WHhylcmpV18obzq9p+cvmwnZ1jq+yanQRmK9n3aN5UnfBVbmSQO19afyAEtw8Wd4wFXYRjEx7z5SvHJFhQAOKQlfFw1Yi8OWLJad+aUukdHK9ZKahvIKCVua57GrXvJiM9PFVy+OlZRLMaLKhKbd/l9JLP7w+h4QS2mCu3CWtX04hUtu0fIq3A53yv9HsimClIPDU8D7T96pqbIe/7vt4RT63Fz5t99dQo2cGtlEduxakhQJQEYt1Le4mIGG4g7ZnrFd4W6ClkyHpI22SHKc4O3nXZWMArGn2KOTDdIqSnCZVqy9yfFVVVDVU43qETOkM23GJXFcxTnprGtrEs88ExHkYwbS0get82gBVbOfCyYfjrxH0QbKQ6ZwuBnLBMCrs9zjv5Lacsonow== x-ms-exchange-antispam-messagedata: uTaPLXSW1BztNLueMZzZXCLV5sbOAOj5ldmuNq3bSdIQ0Ofx8IRiIA5rQNCIh5418V4bYB+ObgEHnZTtAOgXoYE/+DaxW+sfYnyJrWqNo42kHYhgLTia+rCXcovweEltb5sJi79bhIZZ4+GeL+RpcA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2813 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(346002)(136003)(39860400002)(376002)(396003)(46966005)(186003)(336012)(33656002)(4326008)(6506007)(7696005)(54906003)(356004)(316002)(53546011)(2906002)(110136005)(81166006)(26005)(478600001)(55016002)(5660300002)(70586007)(52536014)(26826003)(8676002)(8936002)(81156014)(9686003)(45080400002)(966005)(82740400003)(70206006)(86362001)(47076004)(6636002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: bc380989-57c1-4d44-e48f-08d7d6d6563b X-Forefront-PRVS: 0361212EA8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VWfJd3oWvQCpRnCBG1FGTEkcLRSMFtPRj4Byse+qx+0XpF0yErJBX7j3pf/FNZY3hAAGnaRXKYRhNKGNpyyWWr574g53HN7jHwjwGv8kl6brrgCNhLjzhX10AIh8CgdJ8TPbwuaR68D71DcDDvqReJGEfCsXGzScpMJjlOzUpmSGYOzlIhRkR/Bt8tNT22piFLdVT3fzWMe2pNLGVYwvCUIfeT0amwuFL2pbd/dng1aVkI6eOTtM+XMMO6f8pPpNftp8hIUC2K0WX2FxsUvm0bzS++zdY6mThigyDnZHj3k2JY9nNEXMg/w6OVs2Doggl6MVHO5RoFlpPLAyEdBAI++lTn5LKbantNa9d8e5cV28jn6Ez01A61tfCAZhM5NECjiKWcmWhMPBaoFK+evg6+ePK+a0Uubf/Ra7EnNUxV4HLdCEEzSMSMF8sbMCLxIruox0Ag76iofuDHt4w0vpedI841DKQW1Io7Ugx2BEGK/vPIUI6/pCrxaRgA+RQTlPKdInG45lH2v1qwfPPaERnyRSkCyLfHDtb1HtKav9/HpvV3cSJGG/cmCMfLbduLq05FI+e+stUEM4k5w4Tm8k4w== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2020 07:20:44.1322 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4004fef8-30d2-401b-6ddd-08d7d6d65b6c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3555 Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, April 1, 2020 5:45 PM > To: Joyce Kong ; Gavin Hu > Cc: stephen@networkplumber.org; david.marchand@redhat.com; > mb@smartsharesystems.com; jerinj@marvell.com; > bruce.richardson@intel.com; ravi1.kumar@amd.com; rmody@marvell.com; > shshaikh@marvell.com; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Honnappa > Nagarahalli ; Phil Yang > ; nd ; dev@dpdk.org; nd > > Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of P= MD > bit operation APIs >=20 > 01/04/2020 10:27, Gavin Hu: > > Hi Thomas, > > > > From: Thomas Monjalon > > > > > > Hi, > > > > > > 09/03/2020 10:54, Joyce Kong: > > > > Bitwise operation APIs are defined and used in a lot of PMDs, > > > > which caused a huge code duplication. > > > > > > Statistics of the series: 653 insertions(+), 326 deletions(-) > > > I would not say it is a huge duplication. > > We did not include all PMDs, just a few for piloting and seeking opinio= ns. > > It is a huge duplication when counting all the PMDs. > > > > > > > To reduce duplication, > > > > this patch consolidates them into a common API family. > > > [...] > > > > +PMD Bitops > > > > +M: Joyce Kong > > > > +F: lib/librte_eal/common/include/rte_pmd_bitops.h > > > > > > Why is it called PMD bitops and not simply bitops? > > > > The scope of these APIs are decreased to PMD use only, for > libraries/applications, it is recommended to use C11 directly as there ar= e > complications of more ordering models involved. >=20 > OK, but PMD means nothing, except this is where it is used *now*. > Please describe and name the API with memory ordering words. Will remove 'PMD' in v8. The APIs were already named with a '_relaxed' suffix, for example 'rte_get_= bit64_relaxed'.=20 According to Honnappa, this patch set just address PMD's requirement, and t= he current PMDs are not using C11, so only '_relaxed' version is offered. http://inbox.dpdk.org/dev/VE1PR08MB514983C3200859B27F166EBB983F0@VE1PR08MB5= 149.eurprd08.prod.outlook.com/