From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91825A046B for ; Wed, 24 Jul 2019 20:00:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFEE11B949; Wed, 24 Jul 2019 20:00:04 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40058.outbound.protection.outlook.com [40.107.4.58]) by dpdk.org (Postfix) with ESMTP id 9344B160 for ; Wed, 24 Jul 2019 20:00:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nz0f41+FrifE+VoPXeHNdAX6pBJ2VMr7KUtOVV+wIABhvuQeVdPkDZiewY9JEWaPB9fhUI5ezg0r4ofKoetkW48Odq6QWUcKU5COd1C1VNeFwoDySuaL8y4zVOlYdrvlaWOhCKoWz4Z+LBIpr9Exrqh8JRw2x3+0rm7YOv8C8T+beoe4AchHK8tdBaEnyu+xT1Fx94DjoblHXct7K3ZscctKzoe+hAcqVvarA0vjHWLK2AHm+Oj1CTqVtYpT8CSC0mn+S4gR+ZAJveN7u7ExV1gVjmXbnQYE6tVTxubIsj9/SqMjm+UQvdhHII4ED89JigfC08jcWrCYxEPxzm7fXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ent3bdMRa0sGwT+50zq2uf+Sfy5FMrM2Ik6bJfycwu4=; b=VJ/ssjLeLhyju98uRKGGbiMcd4BY8Wdbc4b86QxQ6WDQAVc9H5DGzWMKhK0RrBCgF77WUI3P8TC8GK766EANgGPuV2m4ENkIF2XiJmvZqew9jJ2G+ApOlXe2jHaoguGGtdVnQdiNUVNfKhTEFGMgL5RnPQg9SpBGr55ptitZJdmMlAlsE3As/5V9E4bfSuH2SR5i2fg0ejg7XBtarCyrC6kYlDtaKSEGi9ZU40oUXpRg7kEZ+kEXEJ2tk46J2Cbx0SQmXb/1xDEvtGUfOTUs2fGeHk4TfA/ylSwFxI3Cev7thqS1NAdjkyPyfLgek485EEiOGEp15SO7hoZObYIJKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ent3bdMRa0sGwT+50zq2uf+Sfy5FMrM2Ik6bJfycwu4=; b=9in6u7FF8uh2hx5CxHOb25cgaADliozKoImldzm4NH3eoujzNegIDIc29ZSwRMhwz4xoFjIR8BglWAcNh50uq+waFe0rTgZCQPVC8SiAJN9m9RrzfWMkOza4Vq2IKqpXDFBDiForZGgUb+nik/n9B4JM81zD/nlhg44Jib4cVig= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB2893.eurprd08.prod.outlook.com (10.170.239.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Wed, 24 Jul 2019 17:59:59 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::8130:867e:2371:9c0]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::8130:867e:2371:9c0%2]) with mapi id 15.20.2094.017; Wed, 24 Jul 2019 17:59:59 +0000 From: "Gavin Hu (Arm Technology China)" To: Honnappa Nagarahalli , Stephen Hemminger CC: "dev@dpdk.org" , nd , "thomas@monjalon.net" , "jerinj@marvell.com" , "pbhagavatula@marvell.com" , nd Thread-Topic: [PATCH v3 5/5] config: add WFE config entry for aarch64 Thread-Index: AQHVQW14oKlr6A95L0iQkuJWpOQlv6bYf3gAgAASIICAAXzWoA== Date: Wed, 24 Jul 2019 17:59:59 +0000 Message-ID: References: <1563896626-44862-1-git-send-email-gavin.hu@arm.com> <1563896626-44862-6-git-send-email-gavin.hu@arm.com> <20190723110508.1b68c1a9@hermes.lan> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: f96e1717-bdd3-47e5-8732-654526f59c3d.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9baaa8b4-8083-4d39-1401-08d71060bec3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB2893; x-ms-traffictypediagnostic: VI1PR08MB2893: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(366004)(346002)(136003)(39860400002)(13464003)(199004)(189003)(66476007)(14454004)(55016002)(86362001)(7696005)(66556008)(66446008)(64756008)(66946007)(25786009)(52536014)(76176011)(71200400001)(74316002)(76116006)(71190400001)(53936002)(99286004)(102836004)(33656002)(55236004)(6506007)(4326008)(26005)(53546011)(6436002)(446003)(8676002)(478600001)(305945005)(81156014)(6116002)(3846002)(110136005)(229853002)(11346002)(14444005)(186003)(256004)(7736002)(316002)(2906002)(68736007)(66066001)(81166006)(5660300002)(476003)(8936002)(9686003)(6246003)(486006)(54906003)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB2893; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: MdCOCCq+PTbBBSddUMPBDvYDrQqJRsMyHwPUkwKpEi0Iz1x2qnDJ8d4JnnhS7y2nkCfosY94WZds1UWlyjtRctp08YJDNfyKHkeXQOwibEwt+zpCM9BHBiopZ/JLYnaRJftI2mrPFlQCd8lRcCtZG6MaPFdGjJGN9BblvxeHlC2pJFisdSKR/TnaTcb7hnJwIkg6JRaUYnOTmOIE5m6s+4jp84fYf3CcX2r6S51ZfncAqqRjzlmOYiwWdKgxdpWQRhJqdtOFvz6apshM1/TVDXGtaWUJ8P3Fg+35ZxPdwgJ/PgYhjfB8HhX2n8emJuT3OBQMqpPPYlkQSdXgF2iezf7xpKcMdYanJijfPLrzw6CnnhzpTCotJvo9xiG0LGGXgnfL/Afh4crRTLr+7h5GfTNsjqY+Rq0ibgWrGJbB3G4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9baaa8b4-8083-4d39-1401-08d71060bec3 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 17:59:59.7893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gavin.Hu@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2893 Subject: Re: [dpdk-dev] [PATCH v3 5/5] config: add WFE config entry for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Wednesday, July 24, 2019 3:10 AM > To: Stephen Hemminger ; Gavin Hu (Arm > Technology China) > Cc: dev@dpdk.org; nd ; thomas@monjalon.net; > jerinj@marvell.com; pbhagavatula@marvell.com; Honnappa Nagarahalli > ; nd > Subject: RE: [PATCH v3 5/5] config: add WFE config entry for aarch64 >=20 > > > > On Tue, 23 Jul 2019 23:43:46 +0800 > > Gavin Hu wrote: > > > > > Add the RTE_USE_WFE configuration entry for aarch64, disabled by > default. > > > It can be enabled selectively based on the performance benchmarking. > > > > > > Signed-off-by: Gavin Hu > > > Reviewed-by: Ruifeng Wang > > > Reviewed-by: Steve Capper > > > Reviewed-by: Honnappa Nagarahalli > > > Acked-by: Pavan Nikhilesh > > > --- > > > config/arm/meson.build | 1 + > > > config/common_armv8a_linux | 6 ++++++ > > > 2 files changed, 7 insertions(+) > > > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > > > 979018e..496813a 100644 > > > --- a/config/arm/meson.build > > > +++ b/config/arm/meson.build > > > @@ -116,6 +116,7 @@ impl_dpaa =3D ['NXP DPAA', flags_dpaa, > > > machine_args_generic] > > > impl_dpaa2 =3D ['NXP DPAA2', flags_dpaa2, machine_args_generic] > > > > > > dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) > > > +dpdk_conf.set('RTE_USE_WFE', 0) > > > > > > if not dpdk_conf.get('RTE_ARCH_64') > > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) diff --git > > > a/config/common_armv8a_linux b/config/common_armv8a_linux index > > > 481712e..48c7ab5 100644 > > > --- a/config/common_armv8a_linux > > > +++ b/config/common_armv8a_linux > > > @@ -12,6 +12,12 @@ CONFIG_RTE_ARCH_64=3Dy > > > > > > CONFIG_RTE_FORCE_INTRINSICS=3Dy > > > > > > +# Use WFE instructions to implement the rte_wait_for_equal_xxx APIs, > > > +# calling these APIs put the cores enter low power state while > > > +waiting # for the memory address to be become equal to the expected > value. > > > +# This is supported only by aarch64. > > > +CONFIG_RTE_USE_WFE=3Dn > > > + > > > # Maximum available cache line size in arm64 implementations. > > > # Setting to maximum available cache line size in generic config # > > > to address minimum DMA alignment across all arm64 implementations. > > > > Introducing config options is a maintenance nightmare. > > How are distributions supposed to ship a package? > > Does full regression test get done on both options? > > > > The user should not be able to change this. > Agree with these concerns here. In our tests, we are finding that this pa= tch > does not result in performance improvements on all micro-architectures. > May be these micro-architectures will evolve in the future knowing that > WFE is being used in DPDK. But at this point, it does not make sense to > enable this by default. This means additional testing/regression with the= flag > enabled. We could add this to Travis build (Travis yml file). >=20 > Currently, this patch will address use cases where the target > hardware/environment is known during compilation. In our testing, like running testpmd and packet_ordering(for WFE ring bench= marking), it showed no improvements nor degradation in performance.=20 For some micro-benchmarking, it showed slight improvements sometimes, no de= gradation were seen. The added benefit of the patch set is power saving, but it is not a primary= concern in DPDK and we are short of measurement ways to benchmark that.