From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: nd <nd@arm.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
Date: Fri, 13 Sep 2019 15:28:10 +0000 [thread overview]
Message-ID: <VI1PR08MB53766640DD2F4A58E508D5298FB30@VI1PR08MB5376.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <VE1PR08MB51491E714E9BE01F4E6D712098B00@VE1PR08MB5149.eurprd08.prod.outlook.com>
Hi Honnappa,
> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Thursday, September 12, 2019 10:43 PM
> To: jerinj@marvell.com; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>; dev@dpdk.org
> Cc: nd <nd@arm.com>; thomas@monjalon.net; hemant.agrawal@nxp.com;
> Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; stable@dpdk.org;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: RE: [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
>
> <snip>
>
> > > Subject: [EXT] [PATCH v2 1/3] test/rcu: fix the compiling error for
> > > armv8.2
> > >
> > > With "-march=armv8.2-a" specified, a compiling error generated:
> > > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> > > expressions of different signedness: ‘unsigned int’ and ‘int’
> > > [-Werror=sign-compare]
> > >
> > > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > > Reviewed-by: Steve Capper <steve.capper@arm.com>
> >
> >
> > Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> This should be fixed already due to commit 104dbec2081.
> Gavin, can you please verify? If yes, we can skip this patch.
No, just ran and the issue persisted with the above commit in place.
I see the above commit was to fix a limited range of data type issue, this commit is to fix a signedness issue.
~/dpdk/app/test/test_rcu_qsbr.c: In function ‘test_rcu_qsbr_thread_unregister’:
~/dpdk/app/test/test_rcu_qsbr.c:233:10: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare]
if (i == (RTE_MAX_LCORE - 10))
>
> >
> >
> > > ---
> > > app/test/test_rcu_qsbr.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> > > 1d273e3..b008c9d 100644
> > > --- a/app/test/test_rcu_qsbr.c
> > > +++ b/app/test/test_rcu_qsbr.c
> > > @@ -231,7 +231,7 @@ test_rcu_qsbr_thread_unregister(void)
> > > /* Update quiescent state counter */
> > > for (i = 0; i < num_threads[j]; i++) {
> > > /* Skip one update */
> > > -if (i == (RTE_MAX_LCORE - 10))
> > > +if (i == (unsigned int)(RTE_MAX_LCORE - 10))
> > > continue;
> > > rte_rcu_qsbr_quiescent(t[0],
> > > (j == 2) ? (RTE_MAX_LCORE - 1) : i);
> > > --
> > > 2.7.4
>
next prev parent reply other threads:[~2019-09-13 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 10:38 Jerin Jacob Kollanukkaran
2019-09-12 14:42 ` Honnappa Nagarahalli
2019-09-13 15:28 ` Gavin Hu (Arm Technology China) [this message]
2019-09-13 15:36 ` Honnappa Nagarahalli
-- strict thread matches above, loose matches on Subject: below --
2019-07-31 23:48 [dpdk-dev] [PATCH v2 0/3] add arm neoverse N1 SDP configuration Gavin Hu
2019-07-31 23:32 ` [dpdk-dev] [PATCH 1/2] test/rcu: fix the compiling error for armv8.2 Gavin Hu
2019-07-31 23:48 ` [dpdk-dev] [PATCH v2 1/3] " Gavin Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB53766640DD2F4A58E508D5298FB30@VI1PR08MB5376.eurprd08.prod.outlook.com \
--to=gavin.hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).