From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F697A00BE; Wed, 30 Oct 2019 10:55:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 99C721BFA9; Wed, 30 Oct 2019 10:55:24 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40076.outbound.protection.outlook.com [40.107.4.76]) by dpdk.org (Postfix) with ESMTP id ECBC81BF9F for ; Wed, 30 Oct 2019 10:55:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CaOwzxfM/iQn3ZOaQVjzSzOxq+MZTn9H6FEKnGB80p8=; b=GfEoEzdYxc3SnWPFJUZ88Yshh+Tuik8EYDj9risJxbeHF95Q3KoLsXtHaK9RxizdZEcHAvhl60zoUnhdCf39CuhXhmdKSW5ajE4yp+DoAwRFITnnODAW2oSggoTekckUlFh3V10kZ4WGoFd41op6n09OziD2V5RcnUHqFKIlVK4= Received: from VE1PR08CA0013.eurprd08.prod.outlook.com (2603:10a6:803:104::26) by DB7PR08MB2985.eurprd08.prod.outlook.com (2603:10a6:5:20::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20; Wed, 30 Oct 2019 09:55:21 +0000 Received: from AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::209) by VE1PR08CA0013.outlook.office365.com (2603:10a6:803:104::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.19 via Frontend Transport; Wed, 30 Oct 2019 09:55:21 +0000 Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT063.mail.protection.outlook.com (10.152.16.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20 via Frontend Transport; Wed, 30 Oct 2019 09:55:20 +0000 Received: ("Tessian outbound 0939a6bab6b1:v33"); Wed, 30 Oct 2019 09:55:20 +0000 X-CR-MTA-TID: 64aa7808 Received: from 32bc13dc88ef.2 (cr-mta-lb-1.cr-mta-net [104.47.10.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 66D60074-0031-40B5-86EB-711D839F58BC.1; Wed, 30 Oct 2019 09:55:15 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2056.outbound.protection.outlook.com [104.47.10.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32bc13dc88ef.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 30 Oct 2019 09:55:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NV3hA16JIae3OBUYs8PZ5ZZW+sypyAn7AKTMsCb3OWW55MZ9r4P5tMxStyx45imD2vdnWeJUIrd5U8fTkoigmXDw5bL0JR/uXa9123j6Wcw+C3i7LNAbaTwjTbxr8k82llIRWCKcKkRdDatuPmk1YWfbXZnhXidPz1UFSWIhe3ugTMTvjVND4instuVCF9Mbobhjq85qidiSWM/ZQeeTwX+joJHgGvq6fvM5e+rYGh+7thY1Ae7toGFwy5In5kDvujjBfdNVZD4QyqWbMa7QqcCWHP9Cxwq94+xqZJSSO5hheDe4V/aSG7ITQNl733qSs24MM51I0PglnEMinmf4Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CaOwzxfM/iQn3ZOaQVjzSzOxq+MZTn9H6FEKnGB80p8=; b=AuF7TQNK6qYKO+ZUgeKxpNvRcgLAVt/LdsqY8qIjsHNxKhQg7u0hoyyjuXvE80w0iimI4JuhgESi7b6FMITPv7ew/vQK6AocE740DvL01huEkvVW/zeA8oWMkqFfBDECQYjcJHswmWIUPGrvhMlTyff0Jpw1bEh3aOf4/Y28N5qyK/EP9/mZRNQ6ZDE8peL1gkgyEKU/P34J06XLvfQPZLmEPmJTQaN/jVzIIQ0rggI0cBZyB3xQvaT0+wfgylnQ1x3EUotiOcMxO3aRV3eoo9y9/y1sUMfFOQLi1y6asduSDBJQpSKkjTJcWaON3hS66GJEStvr6a5MJHgvhaV+JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CaOwzxfM/iQn3ZOaQVjzSzOxq+MZTn9H6FEKnGB80p8=; b=GfEoEzdYxc3SnWPFJUZ88Yshh+Tuik8EYDj9risJxbeHF95Q3KoLsXtHaK9RxizdZEcHAvhl60zoUnhdCf39CuhXhmdKSW5ajE4yp+DoAwRFITnnODAW2oSggoTekckUlFh3V10kZ4WGoFd41op6n09OziD2V5RcnUHqFKIlVK4= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (10.255.196.79) by VI1PR08MB4208.eurprd08.prod.outlook.com (20.178.205.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.22; Wed, 30 Oct 2019 09:55:12 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::709e:c2c9:139d:9df3]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::709e:c2c9:139d:9df3%4]) with mapi id 15.20.2408.019; Wed, 30 Oct 2019 09:55:12 +0000 From: "Gavin Hu (Arm Technology China)" To: "thomas@monjalon.net" , "Joyce Kong (Arm Technology China)" CC: "dev@dpdk.org" , nd , "jerinj@marvell.com" , "stephen@networkplumber.org" , "mb@smartsharesystems.com" , Honnappa Nagarahalli , "ravi1.kumar@amd.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "adrien.mazarguil@6wind.com" , nd Thread-Topic: [dpdk-dev] [PATCH v2 0/6] implement common rte bit operation APIs in PMDs Thread-Index: AQHViU1UM0uj6oNhQ0q+uQCkGAZqladx3SOAgAEax7A= Date: Wed, 30 Oct 2019 09:55:11 +0000 Message-ID: References: <1571125801-45773-1-git-send-email-joyce.kong@arm.com> <1571799298-18873-1-git-send-email-joyce.kong@arm.com> <2670371.SxHcXEKB0j@xps> In-Reply-To: <2670371.SxHcXEKB0j@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: eee13993-181a-4c7a-a391-9f217a5de0dd.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8542e7e9-c9e2-481d-803a-08d75d1f46b6 X-MS-TrafficTypeDiagnostic: VI1PR08MB4208:|VI1PR08MB4208:|DB7PR08MB2985: X-MS-Exchange-PUrlCount: 2 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:4502;OLM:4502; x-forefront-prvs: 02065A9E77 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(136003)(346002)(39860400002)(376002)(13464003)(189003)(199004)(86362001)(33656002)(2501003)(7416002)(7736002)(11346002)(6636002)(305945005)(476003)(2906002)(6306002)(446003)(6116002)(3846002)(14454004)(256004)(6436002)(229853002)(55016002)(486006)(9686003)(4326008)(74316002)(6246003)(102836004)(52536014)(64756008)(66446008)(7696005)(110136005)(53546011)(76176011)(55236004)(6506007)(99286004)(966005)(316002)(66556008)(66476007)(54906003)(76116006)(66946007)(25786009)(5660300002)(26005)(186003)(71190400001)(66066001)(81166006)(71200400001)(478600001)(8676002)(81156014)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4208; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JMazycTwHo0SrEsTN36iSZcnxvOEFEmz+9rMLpDlNx5vJRdMhA6WsF7FzwPvrrbIvPL2eHncKWRjxQheF+8jt9Occ+rRj/vDhtYmCcSTx9ABhlkgVP4lEEQQ43FzVmgY9H0gIbO+Ib/qzQCqAyNDoXIMin0EG/AgZWAUocuyg0hQi7nmkYHGuVzWQ9E6Fl+E6B0TsUdXOeq9/ADbjJxmfX2aSUhd6pu4qY+EsYMNahsKg5Zy/vKzgwM38L+smvlAGQc9E1VqyGAuFbatBG33AKeuw7G5Vef14fUIXe9f7YOaifNjrDTFgsP8t8yPsdJgx4oBAjF42vWi+8HckqLi7ZEhP1HfMlcjcBIXn0kKhnbGxiyteCO/Weli9VoZayN5GejfFzI3an1Ej4qqBQ5MO0KFvVFyXBTJyOZZlq4XZwWQzihDo/QvC5Xl/D+oY+CQ2/mKkKqQkBCwRpCs1svmEPAguQ1X8LPgzpA+b2vgnjA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4208 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(346002)(136003)(376002)(1110001)(339900001)(13464003)(189003)(199004)(336012)(7736002)(76130400001)(70206006)(70586007)(486006)(66066001)(26005)(25786009)(33656002)(74316002)(305945005)(2906002)(86362001)(186003)(476003)(446003)(11346002)(126002)(22756006)(105606002)(3846002)(110136005)(54906003)(23726003)(6116002)(316002)(36906005)(50466002)(99286004)(2501003)(6506007)(14454004)(6636002)(97756001)(46406003)(81166006)(102836004)(53546011)(9686003)(966005)(6246003)(6306002)(5660300002)(55016002)(7696005)(229853002)(76176011)(81156014)(8676002)(47776003)(356004)(8746002)(478600001)(4326008)(26826003)(52536014)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB2985; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 771ac019-bfde-4be4-7e89-08d75d1f4188 NoDisclaimer: True X-Forefront-PRVS: 02065A9E77 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YIj7tRPfNhRXAcP702Mi1SCRPEcupcr6ZkjYUvxnOQ/n3iSUGGPINuXsqhFQrY59seie24jT2E9NzhO/bRxP/TNLkaqIOteYtYXHDM7ft5DulR4SY6D/1xiboCvhYo/9licc+4LaZWCOR6JX78HveN4RJAa1ps39sjA1XAU894Q61TPF/y9Me32jdBffrg5Vdfgp/0kWPzfQGsDeLdr7xlEqrJo7N9eatJhWPff3QKA7lmkzN18iEIZk9LnI7QMBAsaTlPqgx9rSz6Jov7Dzsz5c07ArncVaqlvWEW69R9ZCZmtXAJPXPv1lDGAW+jnyVixwFIE7VbltPSV5wpgH/bZP3W2E4hic2R6AwVBn1z4G9LjxY+LxztX2wSY2jrwFHtnZzCiLC4G2SKZFI/E6Io0lCQmN6Ondgc/361aDQ6DTHjhX1smgkZ9F0Q9Djm4z2e2e7toymno2NsrAhV8XaMOrA5w72h6KORF10ge35bg= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2019 09:55:20.7368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8542e7e9-c9e2-481d-803a-08d75d1f46b6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2985 Subject: Re: [dpdk-dev] [PATCH v2 0/6] implement common rte bit operation APIs in PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, October 30, 2019 12:43 AM > To: Joyce Kong (Arm Technology China) > Cc: dev@dpdk.org; nd ; jerinj@marvell.com; > stephen@networkplumber.org; mb@smartsharesystems.com; Honnappa > Nagarahalli ; Gavin Hu (Arm Technology > China) ; ravi1.kumar@amd.com; rmody@marvell.com; > shshaikh@marvell.com; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; > adrien.mazarguil@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2 0/6] implement common rte bit operation > APIs in PMDs >=20 > 23/10/2019 04:54, Joyce Kong: > > There are a lot functions of bit operations scattered in PMDs, > > consolidate them into a common API family and applied in different > > PMDs to reduce code duplication. >=20 > Please, could you look at what Adrien did in the Mellanox PMD? >=20 > http://code.dpdk.org/dpdk/latest/source/drivers/net/mlx5/mlx5_utils.h#L28 The code has less duplication, but it requires a less natural declaration o= f variables http://code.dpdk.org/dpdk/latest/source/drivers/net/mlx5/mlx5.h#L607=20 Should we take this way? /Gavin >=20 >=20