From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7083A054E; Sat, 15 Feb 2020 06:57:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BECDF72; Sat, 15 Feb 2020 06:57:22 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2087.outbound.protection.outlook.com [40.107.21.87]) by dpdk.org (Postfix) with ESMTP id 197EADE3 for ; Sat, 15 Feb 2020 06:57:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1rdewoXqCDr6Q0Le8DeKiMdqujSujPudXwbKfqo7VCQ=; b=1PP/O25HXD6kwUJ2n8GjltYTUwcGBouXAvZYVDx/+Y2r1GysHIeJ07CjJt531H7tR+8o0uhg4V1YwHwh20+r1FwSmoCKCY3xc06IWHTCYlseQQ/fzdB00hGhSFauQDaYw5VbwG7T4oUwipH3MFVhM4xyjEXmfJFbYE4dMJeicp4= Received: from VI1PR08CA0220.eurprd08.prod.outlook.com (2603:10a6:802:15::29) by DB7PR08MB4587.eurprd08.prod.outlook.com (2603:10a6:10:30::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Sat, 15 Feb 2020 05:57:18 +0000 Received: from AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::203) by VI1PR08CA0220.outlook.office365.com (2603:10a6:802:15::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22 via Frontend Transport; Sat, 15 Feb 2020 05:57:17 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT029.mail.protection.outlook.com (10.152.16.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.18 via Frontend Transport; Sat, 15 Feb 2020 05:57:13 +0000 Received: ("Tessian outbound da94dc68d1bb:v42"); Sat, 15 Feb 2020 05:57:01 +0000 X-CR-MTA-TID: 64aa7808 Received: from bf62e598aa96.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 12ADAE79-B150-4023-A80E-D3C08D28F0C6.1; Sat, 15 Feb 2020 05:56:56 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bf62e598aa96.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 15 Feb 2020 05:56:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jf617pTJbYmm7BRQQbmnWF7kUri81u3PB3cCOW85klHKt3wIXWdM+itzYkjeCOTPnyzqqlo+McbCnYdvvPLfOVdvdGAGA8nCIi7iKm1s69gBE4vRHRVODbsQYYoLx995u0lB3o8iFm+uUQDL9XkvCmRDJKLDclQmQUin0iChFwGi8dKwTz666hkh7viwFS1u5n6Q4b41YHjEP2nyjvbpJUPiPuR8wX53CDoKG2LTaf6RNfRbQma9AitqgBK2RXAtPNrl6iZ6/ZBnF1x79mD1NlsqE73b5PQD9fe/Kx9/XUTcjNLjHFj+E2mm0Cn8NgivWjBmiIh9MMmolrJhaONi6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1rdewoXqCDr6Q0Le8DeKiMdqujSujPudXwbKfqo7VCQ=; b=foemxOE5N2/YNKCFMYS1hhf1X6ncQFEua98EL7siYH46VAUo/DG8VZyrUU3Hqb+WvraRqX8VAPwJgPieGiTcMWv8VYxm7++XzMaazW8p6gp4ESNilk4175WruFOtwegB4Y+60CrvoyXjVit207hbnXyumTqjQbZiEPTNO1b0Za9PVjtBOOecJtEud4ImXGZ2MICbcJIDh5rFBNy8K0LaZcLGze9cvxIdbFxv3f6lrWdNK8bDl9Ln0UPJs3om+ItMMuJalAm0ZQohxP+3cIiPsl3V9tG1H2//glWGhGfUdMhjl3cxaGD35FsFMuf2eGd/NA2LgGiud3KQp/RVU+eh8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1rdewoXqCDr6Q0Le8DeKiMdqujSujPudXwbKfqo7VCQ=; b=1PP/O25HXD6kwUJ2n8GjltYTUwcGBouXAvZYVDx/+Y2r1GysHIeJ07CjJt531H7tR+8o0uhg4V1YwHwh20+r1FwSmoCKCY3xc06IWHTCYlseQQ/fzdB00hGhSFauQDaYw5VbwG7T4oUwipH3MFVhM4xyjEXmfJFbYE4dMJeicp4= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (10.255.196.79) by VI1PR08MB2911.eurprd08.prod.outlook.com (10.170.239.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22; Sat, 15 Feb 2020 05:56:53 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::e080:9698:5896:6837]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::e080:9698:5896:6837%5]) with mapi id 15.20.2729.025; Sat, 15 Feb 2020 05:56:52 +0000 From: Gavin Hu To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" CC: "dev@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH] event/octeontx2: remove WFE from dualslot dequeue Thread-Index: AQHV4wJfsXOhdvXgzEuebgOcrx56Z6gbwZ6w Date: Sat, 15 Feb 2020 05:56:52 +0000 Message-ID: References: <20200214064525.1895-1-pbhagavatula@marvell.com> In-Reply-To: <20200214064525.1895-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: c2a26d84-1a6b-424c-8d25-0381667cf58d.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6c51df49-31c8-4f18-7858-08d7b1dbe7b2 X-MS-TrafficTypeDiagnostic: VI1PR08MB2911:|DB7PR08MB4587: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1332;OLM:1332; x-forefront-prvs: 03142412E2 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(396003)(376002)(366004)(39860400002)(199004)(189003)(5660300002)(66446008)(33656002)(66476007)(7696005)(4326008)(64756008)(8936002)(55236004)(53546011)(6506007)(186003)(66556008)(26005)(2906002)(66946007)(76116006)(71200400001)(110136005)(9686003)(54906003)(316002)(81156014)(8676002)(52536014)(86362001)(81166006)(55016002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB2911; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: o6MJhofLjUecHzzDwgvyVUmE6B4M0dfsOBIfQydO4/2lqliw0/sHuWngVMlvnRkFen1mZpaZkwlVMKfihDDhMdUXcDcVwQLoZF365JwGEsRMYz5awTg1FQGtLD1hSwinizbc7Aeu2Q6lxGV4WELV8JGaPIaJSnHyfwLjR6wYd6UaUJV+VAUO7ORtkHX7DhDTUK+kni8UTNUzJoFlhllregBwxZVQmRidbZzuKncu/N6Q084uYBzsRdyOi+nFG2wz8CjCeotuj7P0CIMYxEkSeY9WEFx1/Be7bbRzksxUi9PY7kucZvPOC5Hfw642zucOcNwxFQhub0Pt1JxKI6WLftKrRSauJNnGawQUkHiDuSQkH7A5RNvAKIEgG00R8EMmWAMBXKCXGHXZS9Ep/jwzH9T40NK7IJg/o2IVlzVNpwKvJEL8dsRee9xx7lM1jILL x-ms-exchange-antispam-messagedata: 1AdqKPi7t7YgCmjUGUCtUnubl8pYm2ikNIXq4QjH6y0Am5IBZp0KunzBWGI/WnrEmpuD4bDcGmFbcLF6eVFbg4k9T/K7xf14bJq5sO7oEW4iOuk5oa+B2SWxsz1zyKcGvDLt2vcWPinr+Rtkn6TD/w== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2911 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(346002)(39840400004)(396003)(136003)(376002)(199004)(189003)(356004)(336012)(55016002)(186003)(52536014)(8936002)(5660300002)(81156014)(316002)(86362001)(70206006)(2906002)(4326008)(110136005)(6506007)(26005)(9686003)(53546011)(7696005)(81166006)(8676002)(478600001)(26826003)(33656002)(70586007)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB4587; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Pass; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 7e8b8dc7-19b8-4e18-81c4-08d7b1dbdb31 X-Forefront-PRVS: 03142412E2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: czPeccdweA3jOtMH8ncXxtXbs1TRd6jSqK6b1yqPJrDd6S0k6d/6z08VhXJzCmYXiN1lrNg/pAsiDYNy/55at9F5S51OtTKMAG0C01Ia21tICX3p58b0HuXb6uFbWjgAT7G0yBeijaXkiZf9xkORi3VcwD7s0mxIZ1gsyrdQE46GrxT29fNSRZNdbhYQKs0z4GSgmu5D0FQvjT4dDUTiZTtfE/l5csMV/2sglaAwh9H8o7o93akPn5uNK3HAfpsmmyrkvN4r/KzwsSUBh7WEiE/yohYM10wCW/ZA+U+nx11KrCOckrTkHHrxiR9S/PrVt7gW4QYF3GE8SbWK+xSQZDZXfhzjiWLEaUtwPAl0MMqPbHjNkh5nREvC40t/9uxsnRNLyXkZqqSMA+KyGAvO6KUnW6YzgLJECJ9kutlhvrQdcH+Zv2zX/Wu4RAqbO8kN X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2020 05:57:13.6209 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c51df49-31c8-4f18-7858-08d7b1dbe7b2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4587 Subject: Re: [dpdk-dev] [PATCH] event/octeontx2: remove WFE from dualslot dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pavan, > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Friday, February 14, 2020 2:45 PM > To: jerinj@marvell.com; Pavan Nikhilesh > Cc: Gavin Hu ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] event/octeontx2: remove WFE from dualslot > dequeue >=20 > From: Pavan Nikhilesh >=20 > Each workslot is always bound to a specific lcore there is no multi-core > contention to cause cache trashing as a result it is safe to remove the > WFE. Also, in dual workslot dequeue work will mostlikely be available on > the pair workslot making WFE impractical. Does SSO still signal EVENTI to exit from WFE? Then the core ignore it? Can this be disabled as WFE is removed? =20 >=20 > Signed-off-by: Pavan Nikhilesh > --- >=20 > Also, this in-turn reduces the branch misses >=20 > Before: > 0 > arm_spe_0/ts_enable=3D1,pct_enable=3D1,pa_enable=3D1,branch_filter=3D1,ji= tter=3D1, > min_latency=3D0/ > 0 dummy:u > 0 llc-miss > 0 tlb-miss > 853 branch-miss > 0 remote-access > 0 l1d-miss >=20 > After: > 0 > arm_spe_0/ts_enable=3D1,pct_enable=3D1,pa_enable=3D1,branch_filter=3D1,ji= tter=3D1, > min_latency=3D0/ > 0 dummy:u > 0 llc-miss > 0 tlb-miss > 250 branch-miss > 0 remote-access > 0 l1d-miss >=20 > WFE Data: >=20 > 0x4C40 - WFI_WFE_WAIT_CYCLES - Number of cycles waiting at a WFI or > WFE instruction. >=20 > - WFE Cycles before the patch for Dual workslot > #perf stat -C 20 -e r4C40 sleep 1 > Performance counter stats for 'CPU(s) 20': >=20 > 264 r4C40 > 1.002494168 seconds time elapsed >=20 > - WFE Cycles for single workslot > #perf stat -C 20 -e r4C40 sleep 1 > Performance counter stats for 'CPU(s) 20': >=20 > 908,778,351 r4C40 > 1.002598253 seconds time elapsed >=20 > drivers/event/octeontx2/otx2_worker_dual.h | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/drivers/event/octeontx2/otx2_worker_dual.h > b/drivers/event/octeontx2/otx2_worker_dual.h > index 5134e3d52..c88420eb4 100644 > --- a/drivers/event/octeontx2/otx2_worker_dual.h > +++ b/drivers/event/octeontx2/otx2_worker_dual.h > @@ -29,11 +29,7 @@ otx2_ssogws_dual_get_work(struct > otx2_ssogws_state *ws, > rte_prefetch_non_temporal(lookup_mem); > #ifdef RTE_ARCH_ARM64 > asm volatile( > - " ldr %[tag], [%[tag_loc]] \n" > - " ldr %[wqp], [%[wqp_loc]] \n" > - " tbz %[tag], 63, done%=3D \n" > - " sevl \n" > - "rty%=3D: wfe \n" > + "rty%=3D: \n" > " ldr %[tag], [%[tag_loc]] \n" > " ldr %[wqp], [%[wqp_loc]] \n" > " tbnz %[tag], 63, rty%=3D \n" > -- > 2.17.1