From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70719A0613 for ; Fri, 30 Aug 2019 10:51:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B57F51E8B3; Fri, 30 Aug 2019 10:51:51 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30076.outbound.protection.outlook.com [40.107.3.76]) by dpdk.org (Postfix) with ESMTP id 6E6711E89E; Fri, 30 Aug 2019 10:51:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQeXHdXEwYTI4Nper+XfGW/K6hPEnWEH04/uZwv21b8=; b=c8GWPKgMAYOUIxioRbJdzcg2xUPm8btZtXArrz9UPMFuOZdR9kmckq5jHZ27LBakNfr8vwSTNDroKBkpiNZNiwk6od3+TIYTZPpK300QCYf1IFQ8y21YAM1OoquvwULg1iQn4y8BN7toapn+VtZcLxd0EKbVvED1MBtLeLZzguU= Received: from DB6PR0802CA0039.eurprd08.prod.outlook.com (2603:10a6:4:a3::25) by AM6PR08MB4951.eurprd08.prod.outlook.com (2603:10a6:20b:eb::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19; Fri, 30 Aug 2019 08:51:47 +0000 Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::209) by DB6PR0802CA0039.outlook.office365.com (2603:10a6:4:a3::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19 via Frontend Transport; Fri, 30 Aug 2019 08:51:47 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.16 via Frontend Transport; Fri, 30 Aug 2019 08:51:45 +0000 Received: ("Tessian outbound ea3fc1501f20:v27"); Fri, 30 Aug 2019 08:51:45 +0000 X-CR-MTA-TID: 64aa7808 Received: from d5ba696d7fb6.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.10.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3E3A687F-5AFD-4633-86E3-933D2A60A270.1; Fri, 30 Aug 2019 08:51:40 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d5ba696d7fb6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Aug 2019 08:51:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BszlWIRvvCTkr1JmICx8npvl7PBd7PYhtKB1W5eMmQJ7LLZuS4aVXIMob2gAKftz22JzCG2vgKz27gFj8+WdrbomD+tKnqaEG7bk59vuU8+pcug3ObOnbRsWPc3yPuIuf6TxPE+hSftnx+VmilZ4aCwSFBZ+LW2uAwCJ8VSb4bd+Cj0e5/uveXh0lxvoPwnAumbC6wFrn3b57Vpx1im7Gu1oHe6ISr/1rJQLlFfZQjQ77j4aXrmhJ2eVDKmOKmkXUseOjU8yV+ueA4gJD0/ix0KBXRr6WLTJV93juUvmq4eOynAdqHYn2liIKt7bGF7Qak2tr8SnWwsJd47pQi8EWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQeXHdXEwYTI4Nper+XfGW/K6hPEnWEH04/uZwv21b8=; b=YCyAsM0ItA95LBc4n6utxtwRj74Rx2S8T6TSn+mwGkqPtvPbYbwdDTxsZqiApYL8F/mTvkMNoHin1MKHbVBnIHPvuNSjl1FZhWO3oY6sdCWghAUL3q3KMex/xApMHbghEq4A0VFwwVbggtuqL3G0dCjMXBtdJ8YBs6HN9gWU7VpKywXzqjMMG+FMzYsdlspnM+k6XGUNiuXomqdJHCeJZwqJmnKAT1o8tC7xE8P6Qzaq/g18dT7WjM6kMM90p9dbZ7ksotMjmAr0Y1HnCRgDFHHsb7X1vFclamH0bsb9iT5nGj7CbtvCcUNbq0aTMRL+qgjyJ6ngFpMQjIENiryiUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQeXHdXEwYTI4Nper+XfGW/K6hPEnWEH04/uZwv21b8=; b=c8GWPKgMAYOUIxioRbJdzcg2xUPm8btZtXArrz9UPMFuOZdR9kmckq5jHZ27LBakNfr8vwSTNDroKBkpiNZNiwk6od3+TIYTZPpK300QCYf1IFQ8y21YAM1OoquvwULg1iQn4y8BN7toapn+VtZcLxd0EKbVvED1MBtLeLZzguU= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB2847.eurprd08.prod.outlook.com (10.170.236.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19; Fri, 30 Aug 2019 08:51:38 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::dc84:8edf:ba9f:faeb]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::dc84:8edf:ba9f:faeb%2]) with mapi id 15.20.2220.013; Fri, 30 Aug 2019 08:51:38 +0000 From: "Gavin Hu (Arm Technology China)" To: Honnappa Nagarahalli , "dev@dpdk.org" CC: nd , "thomas@monjalon.net" , "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "qi.z.zhang@intel.com" , "bruce.richardson@intel.com" , "stable@dpdk.org" , nd Thread-Topic: [PATCH 2/2] net/i40e: remove compiler barrier for aarch64 Thread-Index: AQHVXfK9jOP+zyaRDkCzTVNjfNG/R6cTX55Q Date: Fri, 30 Aug 2019 08:51:38 +0000 Message-ID: References: <1565693011-33998-1-git-send-email-gavin.hu@arm.com> <1565693011-33998-3-git-send-email-gavin.hu@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: c7b8e133-b4b7-4cd8-8ae7-5dcccb990eda.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 3ea6e51e-8915-48a6-8883-08d72d274988 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB2847; X-MS-TrafficTypeDiagnostic: VI1PR08MB2847:|VI1PR08MB2847:|AM6PR08MB4951: X-MS-Exchange-PUrlCount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; x-forefront-prvs: 0145758B1D X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(396003)(376002)(366004)(39860400002)(13464003)(199004)(189003)(66446008)(66476007)(8936002)(6116002)(66066001)(6246003)(66556008)(25786009)(6436002)(4326008)(74316002)(54906003)(7736002)(316002)(305945005)(110136005)(99286004)(76116006)(8676002)(53936002)(33656002)(64756008)(81156014)(81166006)(66946007)(55016002)(6306002)(256004)(14444005)(5660300002)(6506007)(9686003)(86362001)(53546011)(966005)(52536014)(14454004)(55236004)(102836004)(71190400001)(71200400001)(2501003)(7696005)(478600001)(76176011)(26005)(486006)(476003)(229853002)(446003)(11346002)(2906002)(3846002)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB2847; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: e/vqh49YHiy39rAbpvX/tImVSa2opebMKeSpyqUaFEtuo1FEMgoFpGjhnwUfuVIkbo3yE6WXILLM2DXHXyHrQkTS/yjxH9NILpGwtUbIi09uryxCCcfiwRVUQvxv4tgl8bn48EOESv+cobiN8T6zLtnnxqMCiQ39rMcfRwSm+kFVhCwHyeTPQmFv6Fz6otA8IkKOdlIktYiTNUGU4P9OZFkz4cL1au4mv+V8LIYJM5Ftif1bNgGeDOkINVsc1d1dSr50AcfZ21D8NUAMkVQUL8tdeIoDE5arJubRC5VhyqH7eQ737aNLWpCu2Z4zyCQlPPTpssRXDYC/IEHxlruPQrLcSCsxaFWENtVqcmVx67V1e4F/GNvF0OziWNLX/cLCHb4K47GeQFc2GNmPmXQCdn0fYhxxah9K0bQhuxB3rd4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2847 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(396003)(136003)(346002)(2980300002)(199004)(189003)(13464003)(26826003)(70586007)(2501003)(356004)(52536014)(76130400001)(478600001)(26005)(76176011)(7696005)(14454004)(102836004)(46406003)(3846002)(6116002)(47776003)(186003)(486006)(336012)(476003)(126002)(63350400001)(2906002)(23726003)(63370400001)(22756006)(229853002)(446003)(11346002)(450100002)(4326008)(7736002)(97756001)(54906003)(305945005)(316002)(50466002)(6246003)(66066001)(8936002)(25786009)(8746002)(70206006)(5660300002)(53546011)(14444005)(9686003)(966005)(86362001)(6506007)(6306002)(99286004)(8676002)(33656002)(74316002)(110136005)(81166006)(55016002)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB4951; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 6b1a75ce-c07b-424c-d975-08d72d274562 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM6PR08MB4951; NoDisclaimer: True X-Forefront-PRVS: 0145758B1D X-Microsoft-Antispam-Message-Info: UVTdGloGs3LqiCe2aIqH2zRR9V0J0Y9/LovGy2HryLsdhyzwNVAtIYMFWWAS5zQ82WNPo8/quPZIkUSODgXH4iUndpCX6ygtuY1HjiPTVCQdQgQ33CpdY/POY7ou0RoPU/JNODDsMiPuK4QxnVPkHxmjH367AjI4ZfnYOUW2KR/d4x8OyOgvFDQC3Zh1J7SjZVX2LTS7pg0IvyInqMQSgY79LMB7PSN8Xm29C1YzrdzNTcroZgsbQtQzeSqNQxM1F+hnKDmHFyRN3gnR1pWM+kpD1mZ6k32Bm3j6x5C+nVHpUefdMotsJDCqnOFbwyaSxxUe//9t7RVuZWXVrnTFMyo5uA35NDAWzvxK4yPK+WimEo+LpIym6z/DuXrqERvVi59+q9IFQrHTQVm1AE9LJwq4HiAjzN03/j0Z0RJh4ds= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2019 08:51:45.6133 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ea6e51e-8915-48a6-8883-08d72d274988 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4951 Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e: remove compiler barrier for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Honnappa, > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Thursday, August 29, 2019 6:49 AM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; thomas@monjalon.net; jerinj@marvell.com; > pbhagavatula@marvell.com; qi.z.zhang@intel.com; > bruce.richardson@intel.com; stable@dpdk.org; Honnappa Nagarahalli > ; nd > Subject: RE: [PATCH 2/2] net/i40e: remove compiler barrier for aarch64 >=20 > > > > As packet length extraction code was simplified,the ordering was not > > necessary any more.[1] > IMO, there is no relationship between the compiler barrier and [1] at lea= st > on Arm platforms. I suggest we just say 'there is no reason for the compi= ler > barrier'. > I think this compiler barrier is not required for x86/PPC as well. The compiler barrier was ever really required for x86, as the two accesses = to the desc[] entry must be ordered.=20 After [1] was applied, the first access was removed, then there is no reaso= n for the compiler barrier. For aarch64, it borrows the barrier and does not change according to the ne= w code, so the barrier can be removed also. Hopefully I got the whole story across clearly and completely.=20 >=20 > > > > 2% performance gain was measured on Marvell ThunderX2. > > 4.3% performance gain was measure on Ampere eMAG80 > > > > [1] http://mails.dpdk.org/archives/dev/2016-April/037529.html > > > > Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Ruifeng Wang > > Reviewed-by: Steve Capper > > --- > > drivers/net/i40e/i40e_rxtx_vec_neon.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c > > b/drivers/net/i40e/i40e_rxtx_vec_neon.c > > index 5555e9b..864eb9a 100644 > > --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c > > +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c > > @@ -307,9 +307,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, > > struct rte_mbuf **rx_pkts, > > rte_mbuf_prefetch_part2(rx_pkts[pos + 3]); > > } > > > > - /* avoid compiler reorder optimization */ > > - rte_compiler_barrier(); > > - > > /* pkt 3,4 shift the pktlen field to be 16-bit aligned*/ > > uint32x4_t len3 =3D > > vshlq_u32(vreinterpretq_u32_u64(descs[3]), > > len_shl); > > -- > > 2.7.4