From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8385DA04F6; Tue, 7 Jan 2020 06:55:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55F281D924; Tue, 7 Jan 2020 06:55:44 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00076.outbound.protection.outlook.com [40.107.0.76]) by dpdk.org (Postfix) with ESMTP id C1CCB1D921 for ; Tue, 7 Jan 2020 06:55:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ReOoxbvGMTHY6jd3qqkx43BEB1m8xK9aMOLg/t84wew=; b=BpV2K/ktY8CX2oLPapL3hagVP2wvc07b9EqLaedk4PyKEbICle/KuGBaXAzZM6GAItJv+0bAo41LQsk63jac6b6sdnvkusdArmCxJx32Gm9y28XdbCLY3/MjN+HPnMUbGLC6YCDRjMpAo/q1t7MiF+ntjieepv8cUHzafw56uZo= Received: from VI1PR08CA0162.eurprd08.prod.outlook.com (2603:10a6:800:d1::16) by AM0PR08MB4610.eurprd08.prod.outlook.com (2603:10a6:208:104::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.10; Tue, 7 Jan 2020 05:55:41 +0000 Received: from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::203) by VI1PR08CA0162.outlook.office365.com (2603:10a6:800:d1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.10 via Frontend Transport; Tue, 7 Jan 2020 05:55:40 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.11 via Frontend Transport; Tue, 7 Jan 2020 05:55:40 +0000 Received: ("Tessian outbound ca1df68f3668:v40"); Tue, 07 Jan 2020 05:55:40 +0000 X-CR-MTA-TID: 64aa7808 Received: from 1ae03e950963.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F993D00B-4B59-4543-B4D6-67195F05A860.1; Tue, 07 Jan 2020 05:55:35 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1ae03e950963.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Jan 2020 05:55:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hhv/IJ1oKyS5DeP0D7ZqXwfx9gRUsMYrgyLgT0XtfCFzetWvuT9r1V6ZJVE+Q54xt+85sfZI2Ih6liPbjYBwDBqJrJMAQtWwBNDbvCyCP0cVgzYdZJeGhTMIa9sfy6oFZASRWnPBImDTUQPG5xQw+wsip8lbDJjctir3jltfrMH3qADwHJfHahJpz1V9cg5JYedS3dPb/XmcFAmtnavSTdGMx29vJr1Bi+6Xq1X/juB0xUfW7krUM+B/ViIbBbWebdTua8ElddnTxJJT2VZwlXjZBqzbZzcDWqFGroGV2IEOVeL+SXNNt+N9kRKOfWlVwvGIFDYtvx8aA0NsGINgig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ReOoxbvGMTHY6jd3qqkx43BEB1m8xK9aMOLg/t84wew=; b=c6dHygQYZVGpe1wua6F1hhMz15ZC8zutfQcbAyRJxQVPYaL4Gk1r9lKUYd+Da6e2MCCPxwqO3hlyRKHDgUrN9iV/pEG7xVdKXsAirFl9IZAHSKAcG66Vv4tmf/H8Cklw/knBjRcGCyVkHsENOTxOp4Fgh9bAR/Xu5GZcPVtxeUQ18cTmYr6pB7FDiGnm6UDmHjzyqdi0+TalD8MPlJmSnLRFKEZQzj0vDNOtKvtQB+vwFlMjbbMtIanc92OMd2Rf+OC/9JTBUaa31399MSzcCzc5RFZ4lAz+BlQpywG/3iRGMuR0n2Xl7mO6SSeDC25tsBhU44LJytjinvoKgm5F3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ReOoxbvGMTHY6jd3qqkx43BEB1m8xK9aMOLg/t84wew=; b=BpV2K/ktY8CX2oLPapL3hagVP2wvc07b9EqLaedk4PyKEbICle/KuGBaXAzZM6GAItJv+0bAo41LQsk63jac6b6sdnvkusdArmCxJx32Gm9y28XdbCLY3/MjN+HPnMUbGLC6YCDRjMpAo/q1t7MiF+ntjieepv8cUHzafw56uZo= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (10.255.196.79) by VI1PR08MB5504.eurprd08.prod.outlook.com (52.133.247.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.12; Tue, 7 Jan 2020 05:55:33 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::e080:9698:5896:6837]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::e080:9698:5896:6837%5]) with mapi id 15.20.2602.016; Tue, 7 Jan 2020 05:55:33 +0000 From: Gavin Hu To: Mahipal Challa , "dev@dpdk.org" , Honnappa Nagarahalli CC: "jerinj@marvell.com" , "pathreya@marvell.com" , "snilla@marvell.com" , "venkatn@marvell.com" , nd Thread-Topic: [dpdk-dev] [PATCH v3 4/6] raw/octeontx2_ep: add enqueue operation Thread-Index: AQHVxInrPXVFu5TSbEeHalU0NrH8LKfesalw Date: Tue, 7 Jan 2020 05:55:32 +0000 Message-ID: References: <1578312447-17277-1-git-send-email-mchalla@marvell.com> <1578312447-17277-5-git-send-email-mchalla@marvell.com> In-Reply-To: <1578312447-17277-5-git-send-email-mchalla@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1d0ff59e-e5f3-4580-9b28-6c68a7488e61.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 719a5f8d-0fd5-403f-d96e-08d793363a1a X-MS-TrafficTypeDiagnostic: VI1PR08MB5504:|VI1PR08MB5504:|AM0PR08MB4610: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; x-forefront-prvs: 027578BB13 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(189003)(199004)(13464003)(54906003)(478600001)(71200400001)(6506007)(7696005)(53546011)(55236004)(6636002)(4326008)(81156014)(81166006)(66476007)(66556008)(64756008)(66446008)(66946007)(9686003)(8676002)(26005)(52536014)(8936002)(86362001)(55016002)(2906002)(110136005)(186003)(33656002)(30864003)(5660300002)(316002)(76116006); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB5504; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wL+1UeoSs6uWWOv9FaAuh0w5PQORvcLBV7506jGhhTlf/rQuwn//BX3Cy9b+nCJmwczqqs4mqeLIkFIE/OpRaCz88oVm9qy2JGpvxqhj5uU/lGmT18BWcSIzfu/TV2qeFVjoXLtM5BeCzy9ScQssh2V5CTWr0MmjMoSbGo2GpOhCDCM/nKP7OW5zvE9vjgIzrtg/KsK4ljKqAZrIRHHQ3NV20TdPlo7kxZv5dNvszO+8Sy7l5LCJvkkNbSst3/KD+d800J7FTeXFB5hbclD5DJy0sm5Qc6h29Dt/IhR2YccHTpisjJF36QXcpIViOsXuzeomN3v8Ek4QoUDpcuSyPX6s3/xOyMWd8oIRbpPJANQaGFmsRpJyZluBPlNOWYO9ROdK7DqqOzu9aXPsomdPF2TQBCDktmUvthka90mkcw+6lmyDwlvZCIoz4ydSoQl99GP+e1BbMSxABCeLPfzpfwSK2c8/rVCYZu1+5fGAKIT4yFhmt1kgfx7mQrOjKW7l Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5504 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(376002)(346002)(396003)(13464003)(199004)(189003)(186003)(52536014)(6506007)(8676002)(110136005)(53546011)(55016002)(54906003)(7696005)(4326008)(356004)(86362001)(316002)(36906005)(5660300002)(30864003)(70586007)(26826003)(33656002)(81166006)(336012)(26005)(478600001)(2906002)(8936002)(81156014)(70206006)(9686003)(6636002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4610; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Pass; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 6f214614-1c46-48ba-68f2-08d79336357d NoDisclaimer: True X-Forefront-PRVS: 027578BB13 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JXaZf6IqxsfF8RIfanfpd+ZquFMnN3yUPc1ARSMNVku5B1Q4K8w5r1Uyt2E+V+hr3+6GIwUr2g2rJqQFFKyYKlbH9/bA+XZ6ob00938r2FCDEOT8ZbQ6FpInOEbMGrMXRagHzGAWVqICX72yWMex3OW+EffENb8wiUkBFP3WOIWMOTFv76kYALMiaTX7SNzQhT+LgtWIWesOT3vbNFGsHK4nd9YbB/I2a17DbTQcgF6lY2F6N9zNNRg0bm/hlWXAuJ83cnzEbgu26G8smh4HsYcXBTug/uBbvO080CgBsB2J1UGeEOvxTiyHIHVgicnyOoK2zAsntgn6z0rT9vENfuLg1obGr7nVikFtpc0UnT4sSKVvL0k9QRJBFuvcGf3fKSZOZPCFHsf9EnNJzUCIlU/3NrX6Lsca544zPnpPxj/H3YZfF50He0bomzi2modzeEarsc7tvnhaaGeQCuwaqwZ0Q9uDpCjkwM+evwKoOyDb+bU3LHVQnbqC+Pf9LMez X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2020 05:55:40.7138 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 719a5f8d-0fd5-403f-d96e-08d793363a1a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4610 Subject: Re: [dpdk-dev] [PATCH v3 4/6] raw/octeontx2_ep: add enqueue operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Mahipal, > -----Original Message----- > From: Mahipal Challa > Sent: Monday, January 6, 2020 8:07 PM > To: dev@dpdk.org > Cc: jerinj@marvell.com; pathreya@marvell.com; snilla@marvell.com; > venkatn@marvell.com; Gavin Hu > Subject: [dpdk-dev] [PATCH v3 4/6] raw/octeontx2_ep: add enqueue > operation >=20 > Add rawdev enqueue operation for SDP VF devices. >=20 > Signed-off-by: Mahipal Challa > --- > doc/guides/rawdevs/octeontx2_ep.rst | 6 + > drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 242 > ++++++++++++++++++++++++++++++ > drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h | 39 +++++ > drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 1 + > drivers/raw/octeontx2_ep/otx2_ep_rawdev.h | 20 +++ > drivers/raw/octeontx2_ep/otx2_ep_vf.c | 24 +++ > 6 files changed, 332 insertions(+) >=20 > diff --git a/doc/guides/rawdevs/octeontx2_ep.rst > b/doc/guides/rawdevs/octeontx2_ep.rst > index 2507fcf..39a7c29 100644 > --- a/doc/guides/rawdevs/octeontx2_ep.rst > +++ b/doc/guides/rawdevs/octeontx2_ep.rst > @@ -68,3 +68,9 @@ The following code shows how the device is configured >=20 > rte_rawdev_configure(dev_id, (rte_rawdev_obj_t)&rdev_info); >=20 > +Performing Data Transfer > +------------------------ > + > +To perform data transfer using SDP VF EP rawdev devices use standard > +``rte_rawdev_enqueue_buffers()`` and ``rte_rawdev_dequeue_buffers()`` > APIs. > + > diff --git a/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c > b/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c > index 584b818..6910f08 100644 > --- a/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c > +++ b/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c > @@ -403,3 +403,245 @@ > return -ENOMEM; > } >=20 > +static inline void > +sdp_iqreq_delete(struct sdp_device *sdpvf, > + struct sdp_instr_queue *iq, uint32_t idx) > +{ > + uint32_t reqtype; > + void *buf; > + > + buf =3D iq->req_list[idx].buf; > + reqtype =3D iq->req_list[idx].reqtype; > + > + switch (reqtype) { > + case SDP_REQTYPE_NORESP: > + rte_mempool_put(sdpvf->enqdeq_mpool, buf); > + otx2_sdp_dbg("IQ buffer freed at idx[%d]", idx); > + break; > + > + case SDP_REQTYPE_NORESP_GATHER: > + case SDP_REQTYPE_NONE: > + default: > + otx2_info("This iqreq mode is not supported:%d", reqtype); > + > + } > + > + /* Reset the request list at this index */ > + iq->req_list[idx].buf =3D NULL; > + iq->req_list[idx].reqtype =3D 0; > +} > + > +static inline void > +sdp_iqreq_add(struct sdp_instr_queue *iq, void *buf, > + uint32_t reqtype) > +{ > + iq->req_list[iq->host_write_index].buf =3D buf; > + iq->req_list[iq->host_write_index].reqtype =3D reqtype; > + > + otx2_sdp_dbg("IQ buffer added at idx[%d]", iq->host_write_index); > + > +} > + > +static void > +sdp_flush_iq(struct sdp_device *sdpvf, > + struct sdp_instr_queue *iq, > + uint32_t pending_thresh __rte_unused) > +{ > + uint32_t instr_processed =3D 0; > + > + rte_spinlock_lock(&iq->lock); > + > + iq->otx_read_index =3D sdpvf->fn_list.update_iq_read_idx(iq); > + while (iq->flush_index !=3D iq->otx_read_index) { > + /* Free the IQ data buffer to the pool */ > + sdp_iqreq_delete(sdpvf, iq, iq->flush_index); > + iq->flush_index =3D > + sdp_incr_index(iq->flush_index, 1, iq->nb_desc); > + > + instr_processed++; > + } > + > + iq->stats.instr_processed =3D instr_processed; > + rte_atomic64_sub(&iq->instr_pending, instr_processed); > + > + rte_spinlock_unlock(&iq->lock); > +} > + > +static inline void > +sdp_ring_doorbell(struct sdp_device *sdpvf __rte_unused, > + struct sdp_instr_queue *iq) > +{ > + otx2_write64(iq->fill_cnt, iq->doorbell_reg); > + > + /* Make sure doorbell write goes through */ > + rte_cio_wmb(); I think I commented this in v2. The barrier should be hoisted up in between the two memory accesses which y= ou want a definite ordering, by CPU or NIC or both.=20 I does not guarantee "going through" or completeness(maybe "dsb" can, as it= stalls execution until the preceding memory access instruction complete, b= ut that is from the point of CPU, not the memory. The early acknowledge mec= hanism will induce the CPU to think it is done but in reality it does mean = to arrive at the memory, especially the IO device registers).=20 Anyway I am not against the comments mentioning "completeness" for "dsb" ba= sed barriers, but for io and cio barriers, they are about observed ordering= , not about "completeness".=20 > + iq->fill_cnt =3D 0; > + > +} > + > +static inline int > +post_iqcmd(struct sdp_instr_queue *iq, uint8_t *iqcmd) > +{ > + uint8_t *iqptr, cmdsize; > + > + /* This ensures that the read index does not wrap around to > + * the same position if queue gets full before OCTEON TX2 could > + * fetch any instr. > + */ > + if (rte_atomic64_read(&iq->instr_pending) >=3D > + (int32_t)(iq->nb_desc - 1)) { > + otx2_err("IQ is full, pending:%ld", > + (long)rte_atomic64_read(&iq->instr_pending)); > + > + return SDP_IQ_SEND_FAILED; > + } > + > + /* Copy cmd into iq */ > + cmdsize =3D ((iq->iqcmd_64B) ? 64 : 32); > + iqptr =3D iq->base_addr + (cmdsize * iq->host_write_index); > + > + rte_memcpy(iqptr, iqcmd, cmdsize); > + > + otx2_sdp_dbg("IQ cmd posted @ index:%d", iq->host_write_index); > + > + /* Increment the host write index */ > + iq->host_write_index =3D > + sdp_incr_index(iq->host_write_index, 1, iq->nb_desc); > + > + iq->fill_cnt++; > + > + /* Flush the command into memory. We need to be sure the data > + * is in memory before indicating that the instruction is > + * pending. > + */ > + rte_io_wmb(); If both memory accesses are in normal memory, then rte_smp_wmb should be us= ed. > + rte_atomic64_inc(&iq->instr_pending); > + > + /* SDP_IQ_SEND_SUCCESS */ > + return 0; > +} > + > + > +static int > +sdp_send_data(struct sdp_device *sdpvf, > + struct sdp_instr_queue *iq, void *cmd) > +{ > + uint32_t ret; > + > + /* Lock this IQ command queue before posting instruction */ > + rte_spinlock_lock(&iq->post_lock); > + > + /* Submit IQ command */ > + ret =3D post_iqcmd(iq, cmd); > + > + if (ret =3D=3D SDP_IQ_SEND_SUCCESS) { > + sdp_ring_doorbell(sdpvf, iq); > + > + iq->stats.instr_posted++; > + otx2_sdp_dbg("Instr submit success posted: %ld\n", > + (long)iq->stats.instr_posted); > + > + } else { > + iq->stats.instr_dropped++; > + otx2_err("Instr submit failled, dropped: %ld\n", > + (long)iq->stats.instr_dropped); > + > + } > + > + rte_spinlock_unlock(&iq->post_lock); > + > + return ret; > +} > + > + > +/* Enqueue requests/packets to SDP IQ queue. > + * returns number of requests enqueued successfully > + */ > +int > +sdp_rawdev_enqueue(struct rte_rawdev *rawdev, > + struct rte_rawdev_buf **buffers __rte_unused, > + unsigned int count, rte_rawdev_obj_t context) > +{ > + struct sdp_instr_64B *iqcmd; > + struct sdp_instr_queue *iq; > + struct sdp_soft_instr *si; > + struct sdp_device *sdpvf; > + > + struct sdp_instr_ih ihx; > + > + sdpvf =3D (struct sdp_device *)rawdev->dev_private; > + si =3D (struct sdp_soft_instr *)context; > + > + iq =3D sdpvf->instr_queue[si->q_no]; > + > + if ((count > 1) || (count < 1)) { > + otx2_err("This mode not supported: req[%d]", count); > + goto enq_fail; > + } > + > + memset(&ihx, 0, sizeof(struct sdp_instr_ih)); > + > + iqcmd =3D &si->command; > + memset(iqcmd, 0, sizeof(struct sdp_instr_64B)); > + > + iqcmd->dptr =3D (uint64_t)si->dptr; > + > + /* Populate SDP IH */ > + ihx.pkind =3D sdpvf->pkind; > + ihx.fsz =3D si->ih.fsz + 8; /* 8B for NIX IH */ > + ihx.gather =3D si->ih.gather; > + > + /* Direct data instruction */ > + ihx.tlen =3D si->ih.tlen + ihx.fsz; > + > + switch (ihx.gather) { > + case 0: /* Direct data instr */ > + ihx.tlen =3D si->ih.tlen + ihx.fsz; > + break; > + > + default: /* Gather */ > + switch (si->ih.gsz) { > + case 0: /* Direct gather instr */ > + otx2_err("Direct Gather instr : not supported"); > + goto enq_fail; > + > + default: /* Indirect gather instr */ > + otx2_err("Indirect Gather instr : not supported"); > + goto enq_fail; > + } > + } > + > + rte_memcpy(&iqcmd->ih, &ihx, sizeof(uint64_t)); > + iqcmd->rptr =3D (uint64_t)si->rptr; > + rte_memcpy(&iqcmd->irh, &si->irh, sizeof(uint64_t)); > + > + /* Swap FSZ(front data) here, to avoid swapping on OCTEON TX2 side > */ > + sdp_swap_8B_data(&iqcmd->rptr, 1); > + sdp_swap_8B_data(&iqcmd->irh, 1); > + > + otx2_sdp_dbg("After swapping"); > + otx2_sdp_dbg("Word0 [dptr]: 0x%016lx", (unsigned long)iqcmd- > >dptr); > + otx2_sdp_dbg("Word1 [ihtx]: 0x%016lx", (unsigned long)iqcmd->ih); > + otx2_sdp_dbg("Word2 [rptr]: 0x%016lx", (unsigned long)iqcmd->rptr); > + otx2_sdp_dbg("Word3 [irh]: 0x%016lx", (unsigned long)iqcmd->irh); > + otx2_sdp_dbg("Word4 [exhdr[0]]: 0x%016lx", > + (unsigned long)iqcmd->exhdr[0]); > + > + sdp_iqreq_add(iq, si->dptr, si->reqtype); > + > + if (sdp_send_data(sdpvf, iq, iqcmd)) { > + otx2_err("Data send failled :"); > + sdp_iqreq_delete(sdpvf, iq, iq->host_write_index); > + goto enq_fail; > + } > + > + if (rte_atomic64_read(&iq->instr_pending) >=3D 1) > + sdp_flush_iq(sdpvf, iq, 1 /*(iq->nb_desc / 2)*/); > + > + /* Return no# of instructions posted successfully. */ > + return count; > + > +enq_fail: > + return SDP_IQ_SEND_FAILED; > +} > + > diff --git a/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h > b/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h > index 4c28283..b9b7c0b 100644 > --- a/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h > +++ b/drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h > @@ -8,4 +8,43 @@ > #include > #include "otx2_ep_rawdev.h" >=20 > +#define SDP_IQ_SEND_FAILED (-1) > +#define SDP_IQ_SEND_SUCCESS (0) > + > + > +static inline uint64_t > +sdp_endian_swap_8B(uint64_t _d) > +{ > + return ((((((uint64_t)(_d)) >> 0) & (uint64_t)0xff) << 56) | > + (((((uint64_t)(_d)) >> 8) & (uint64_t)0xff) << 48) | > + (((((uint64_t)(_d)) >> 16) & (uint64_t)0xff) << 40) | > + (((((uint64_t)(_d)) >> 24) & (uint64_t)0xff) << 32) | > + (((((uint64_t)(_d)) >> 32) & (uint64_t)0xff) << 24) | > + (((((uint64_t)(_d)) >> 40) & (uint64_t)0xff) << 16) | > + (((((uint64_t)(_d)) >> 48) & (uint64_t)0xff) << 8) | > + (((((uint64_t)(_d)) >> 56) & (uint64_t)0xff) << 0)); > +} > + > +static inline void > +sdp_swap_8B_data(uint64_t *data, uint32_t blocks) > +{ > + /* Swap 8B blocks */ > + while (blocks) { > + *data =3D sdp_endian_swap_8B(*data); > + blocks--; > + data++; > + } > +} > + > +static inline uint32_t > +sdp_incr_index(uint32_t index, uint32_t count, uint32_t max) > +{ > + if ((index + count) >=3D max) > + index =3D index + count - max; > + else > + index +=3D count; > + > + return index; > +} > + > #endif /* _OTX2_EP_ENQDEQ_H_ */ > diff --git a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c > b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c > index 3db5a74..22a6beb 100644 > --- a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c > +++ b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c > @@ -251,6 +251,7 @@ > .dev_start =3D sdp_rawdev_start, > .dev_stop =3D sdp_rawdev_stop, > .dev_close =3D sdp_rawdev_close, > + .enqueue_bufs =3D sdp_rawdev_enqueue, > }; >=20 > static int > diff --git a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.h > b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.h > index a01f48d..8fd06fb 100644 > --- a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.h > +++ b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.h > @@ -8,6 +8,10 @@ > #include > #include >=20 > +/* IQ instruction req types */ > +#define SDP_REQTYPE_NONE (0) > +#define SDP_REQTYPE_NORESP (1) > +#define SDP_REQTYPE_NORESP_GATHER (2) >=20 > /* Input Request Header format */ > struct sdp_instr_irh { > @@ -128,6 +132,13 @@ struct sdp_instr_list { > }; > #define SDP_IQREQ_LIST_SIZE (sizeof(struct sdp_instr_list)) >=20 > +/* Input Queue statistics. Each input queue has four stats fields. */ > +struct sdp_iq_stats { > + uint64_t instr_posted; /* Instructions posted to this queue. */ > + uint64_t instr_processed; /* Instructions processed in this queue. */ > + uint64_t instr_dropped; /* Instructions that could not be processed */ > +}; > + > /* Structure to define the configuration attributes for each Input queue= . */ > struct sdp_iq_config { > /* Max number of IQs available */ > @@ -195,6 +206,9 @@ struct sdp_instr_queue { > /* Number of instructions pending to be posted to OCTEON TX2. */ > uint32_t fill_cnt; >=20 > + /* Statistics for this input queue. */ > + struct sdp_iq_stats stats; > + > /* DMA mapped base address of the input descriptor ring. */ > uint64_t base_addr_dma; >=20 > @@ -380,6 +394,8 @@ struct sdp_fn_list { > void (*setup_oq_regs)(struct sdp_device *sdpvf, uint32_t q_no); >=20 > int (*setup_device_regs)(struct sdp_device *sdpvf); > + uint32_t (*update_iq_read_idx)(struct sdp_instr_queue *iq); > + > void (*enable_io_queues)(struct sdp_device *sdpvf); > void (*disable_io_queues)(struct sdp_device *sdpvf); >=20 > @@ -458,4 +474,8 @@ struct sdp_device { > int sdp_setup_oqs(struct sdp_device *sdpvf, uint32_t oq_no); > int sdp_delete_oqs(struct sdp_device *sdpvf, uint32_t oq_no); >=20 > +int sdp_rawdev_enqueue(struct rte_rawdev *dev, struct rte_rawdev_buf > **buffers, > + unsigned int count, rte_rawdev_obj_t context); > + > + > #endif /* _OTX2_EP_RAWDEV_H_ */ > diff --git a/drivers/raw/octeontx2_ep/otx2_ep_vf.c > b/drivers/raw/octeontx2_ep/otx2_ep_vf.c > index 8e79fe8..c5c0bc3 100644 > --- a/drivers/raw/octeontx2_ep/otx2_ep_vf.c > +++ b/drivers/raw/octeontx2_ep/otx2_ep_vf.c > @@ -409,6 +409,28 @@ > sdp_vf_disable_oq(sdpvf, q_no); > } >=20 > +static uint32_t > +sdp_vf_update_read_index(struct sdp_instr_queue *iq) > +{ > + uint32_t new_idx =3D rte_read32(iq->inst_cnt_reg); > + > + /* The new instr cnt reg is a 32-bit counter that can roll over. > + * We have noted the counter's initial value at init time into > + * reset_instr_cnt > + */ > + if (iq->reset_instr_cnt < new_idx) > + new_idx -=3D iq->reset_instr_cnt; > + else > + new_idx +=3D (0xffffffff - iq->reset_instr_cnt) + 1; > + > + /* Modulo of the new index with the IQ size will give us > + * the new index. > + */ > + new_idx %=3D iq->nb_desc; > + > + return new_idx; > +} > + > int > sdp_vf_setup_device(struct sdp_device *sdpvf) > { > @@ -436,6 +458,8 @@ > sdpvf->fn_list.setup_oq_regs =3D sdp_vf_setup_oq_regs; >=20 > sdpvf->fn_list.setup_device_regs =3D sdp_vf_setup_device_regs; > + sdpvf->fn_list.update_iq_read_idx =3D sdp_vf_update_read_index; > + > sdpvf->fn_list.enable_io_queues =3D sdp_vf_enable_io_queues; > sdpvf->fn_list.disable_io_queues =3D sdp_vf_disable_io_queues; >=20 > -- > 1.8.3.1