From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 993EFA04BA; Mon, 11 Nov 2019 06:06:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02AA92956; Mon, 11 Nov 2019 06:06:31 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70070.outbound.protection.outlook.com [40.107.7.70]) by dpdk.org (Postfix) with ESMTP id 4BF2A235 for ; Mon, 11 Nov 2019 06:06:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5o3pwqneP8xkbHABOfZ0NJVl8sBk3SvrrmNsufMia7Y=; b=04lwJuEeMmK2aoskLqZAbe8qgtkiOkbmXswtVx0enZqNToC4ZlXmCq3Z7C5c74zfih8NL+B/hcxZweei21scODSJhF3ND/ktGxAc+D3P1jvdiUGPM3AfEtRrxQaAQ9f6nSnDVICgftpn1COLydcCi+Ebg0rfP9m6EQj6ha63vL8= Received: from DB6PR0801CA0065.eurprd08.prod.outlook.com (2603:10a6:4:2b::33) by VE1PR08MB4960.eurprd08.prod.outlook.com (2603:10a6:803:112::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.25; Mon, 11 Nov 2019 05:06:26 +0000 Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::206) by DB6PR0801CA0065.outlook.office365.com (2603:10a6:4:2b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2430.20 via Frontend Transport; Mon, 11 Nov 2019 05:06:26 +0000 Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2430.21 via Frontend Transport; Mon, 11 Nov 2019 05:06:26 +0000 Received: ("Tessian outbound 3fba803f6da3:v33"); Mon, 11 Nov 2019 05:06:24 +0000 X-CR-MTA-TID: 64aa7808 Received: from c966aee82b19.1 (cr-mta-lb-1.cr-mta-net [104.47.9.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 460C9C81-DEFF-4628-B50D-EA3935E58FF5.1; Mon, 11 Nov 2019 05:06:19 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2057.outbound.protection.outlook.com [104.47.9.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c966aee82b19.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Nov 2019 05:06:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=irzqgexQ8GRYw8IyO6JhIkKvU4PP/PWUBZv5a9wmz3Jp8lmQNhRvQ1I/UKiie6Z6EZiNzw/0z7ts37/r/p5F+SOKrBTMjiAL49yoHHwNMcYEDoOMdbWN72lSeaPrdRnnP37vjTWBZy5kvZURdY4BN6V8/xL6lFcTm5Wglfs4c/253cmhV65vvzUammRNCfDXFrGV0i+ted0vuPIu8KgMfTUDN/0lgroyNlY6o3ORNlwBt31QxcnFDfZV0w5lAZcDJVAmkJfj3zPMgADVFRVJSzd58VFOpGPiuYdxwBcfvxATTFmlNKjNwOvin4kz9cq10s+DGygq9R8Plj6ljtyYEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5o3pwqneP8xkbHABOfZ0NJVl8sBk3SvrrmNsufMia7Y=; b=X+A0zYylvviR72W+7KUmEB3dyG1tx2XO8TGjb1QAaerZjWGU7hiZyZxu8TbrGI8WPzDQjnm8K/FoeRgbFqHw9cQnFmvK3iDpXL3d0ZhoYfXCGbnOmZ6IHSIvGeMcaINOaRvwLQzRS60URbeHmYfHMQEVlcbyv6PeCzTryTkD5S7gYbqdJAW+F1KA7NFJkWjFVnDK8olDDAaFfuQfJ+75SS8fUDSq2RaCyQeycKzb6aCYQz3shaD1Zov4qaSlGybAl8zc5SSDwEuYiYTeVwDTg9/QFt5uQdF7lEo6uKQz9C7WrcSVteTiDx396k5QPMY1DoAP1eHQBR8kwX+AxByRrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5o3pwqneP8xkbHABOfZ0NJVl8sBk3SvrrmNsufMia7Y=; b=04lwJuEeMmK2aoskLqZAbe8qgtkiOkbmXswtVx0enZqNToC4ZlXmCq3Z7C5c74zfih8NL+B/hcxZweei21scODSJhF3ND/ktGxAc+D3P1jvdiUGPM3AfEtRrxQaAQ9f6nSnDVICgftpn1COLydcCi+Ebg0rfP9m6EQj6ha63vL8= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (10.255.196.79) by VI1PR08MB3358.eurprd08.prod.outlook.com (52.133.15.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Mon, 11 Nov 2019 05:06:16 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::709e:c2c9:139d:9df3]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::709e:c2c9:139d:9df3%4]) with mapi id 15.20.2430.027; Mon, 11 Nov 2019 05:06:16 +0000 From: "Gavin Hu (Arm Technology China)" To: Honnappa Nagarahalli , "thomas@monjalon.net" CC: "dev@dpdk.org" , "pbhagavatula@marvell.com" , nd , "jerinj@marvell.com" , "bruce.richardson@intel.com" , nd Thread-Topic: [dpdk-dev] [PATCH v2 2/3] config: add arm neoverse N1 SDP configuration Thread-Index: AQHVhTjluauIbNJNU0m3swGzCmIgGKdf2tYAgAAkfoCABy+RgIAAhQ4AgAda0wCAAGUpAIAAV0aAgAFjB4CAFGD50A== Date: Mon, 11 Nov 2019 05:06:16 +0000 Message-ID: References: <1564615940-13183-1-git-send-email-gavin.hu@arm.com> <2227745.9fKeDGhzLh@xps> <42494108.RkbLAJnAIz@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: a6d63cb3-3b60-443f-b557-e31695000ae4.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 62153689-f12c-4481-0286-08d76664e766 X-MS-TrafficTypeDiagnostic: VI1PR08MB3358:|VI1PR08MB3358:|VE1PR08MB4960: X-MS-Exchange-PUrlCount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 0218A015FA X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(39860400002)(346002)(376002)(396003)(189003)(199004)(13464003)(5660300002)(54906003)(6306002)(8936002)(305945005)(256004)(2906002)(14444005)(2501003)(86362001)(7736002)(81156014)(81166006)(76116006)(66066001)(8676002)(110136005)(4326008)(6246003)(52536014)(55016002)(71200400001)(71190400001)(99286004)(9686003)(33656002)(478600001)(6116002)(3846002)(966005)(476003)(229853002)(11346002)(446003)(26005)(74316002)(486006)(186003)(102836004)(6436002)(76176011)(6506007)(25786009)(53546011)(14454004)(316002)(66946007)(66476007)(7696005)(55236004)(66556008)(64756008)(66446008)(473944003)(414714003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3358; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GL1ruwi3UfO3txTtocm9FZOkbBuwluxkFxOLK4ZPrcDWbuINzU3olb4ZbrQpsSXwdPNOtMXmI0JVLtAesP/dgt39nEPmmN9i9EoUipcc14VZ8EZEqN+yxj5pqhdEPm2JFEZKOk3y0Ff4cR0XErUuCkWKwAniX0nRl7hCch2URJnxHh0YpK6ZQs4fQThvDly7L8aoGzKAftO8l9lgbII/GdegOT6KwGdPgHtes0th0PkcU2X8sW48meH3vTUsYe8YCYJIAgqtlAiswYbDyonHPr1/J8EUYiOmt/xWr7xcO6m3WJNnPqbafVTrih0Orq035Rd6c3pV+H4WVRnngtEh0ehuYn6aJfEAnxMSJHC0/YzBlYxlalo+KjUBY229fo9jxT3PWMJQaZVKK7g6dj0oqLysZjalUkLru19ZOxCTkW/ChYhTTx0FMp0+vNFPKc5lUJaG5H1ANoh7ZxQzBh8mCA0jaNU14MvWWP0dlsgcX+4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3358 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(376002)(136003)(39860400002)(1110001)(339900001)(13464003)(189003)(199004)(8936002)(8746002)(336012)(446003)(11346002)(47776003)(8676002)(81156014)(81166006)(66066001)(126002)(486006)(476003)(33656002)(105606002)(186003)(2501003)(86362001)(54906003)(110136005)(305945005)(76130400001)(50466002)(74316002)(25786009)(7736002)(97756001)(14454004)(966005)(36906005)(316002)(356004)(478600001)(26826003)(70206006)(76176011)(229853002)(22756006)(7696005)(102836004)(26005)(70586007)(2906002)(6506007)(53546011)(23726003)(6116002)(3846002)(14444005)(5660300002)(4326008)(52536014)(55016002)(99286004)(9686003)(6306002)(46406003)(6246003)(414714003)(473944003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4960; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 6de760af-04b5-4d57-678f-08d76664e1df NoDisclaimer: True X-Forefront-PRVS: 0218A015FA X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NKLHnIUXin5bsgNsdoqAv8888jngo1naKfrfyQyHMDJP8pvLiz65y9vQ5pcTLMc2xXTxyWtnJ1WX2PUQltlssLrzzVf85rh8pto0Z9gOKJz/s5GbkvCzognXe/Idmi8hybD1OjdgYUrxSHQ9bygmoG4RcWuqkuATpOqAl7nv8mHsYkTzqCXAr22D0sgsjSyhJWvgEQTXRNA1At2aChdPd39LpmpUDZ8CuvXKbO42yGKbLGvJp6j4c/MSEYvkQ5GO+if6VCLunXEEwoDM6ZspbB4r47OXy9ds/kA/8Mv/yT725UKHVkVETAxZGP1zARD37db/RaJnInoDSPpM2shz6B5vPgsw2H+ZfQoFWANVDZT6ItWokswq8TfQDk9YlZ2yD92MtKEkLW4quD+1vmDF/+yxZY7aN106Mh/s8S7Z1jWbn86n1KfKr1jf1H3yxLIAGclaDYu9GJ2V7pV8lxsrbcQsA8y0AlgF9by2tjTBXaM= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2019 05:06:26.0130 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62153689-f12c-4481-0286-08d76664e766 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4960 Subject: Re: [dpdk-dev] [PATCH v2 2/3] config: add arm neoverse N1 SDP configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Honnappa, > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Tuesday, October 29, 2019 1:47 PM > To: thomas@monjalon.net > Cc: Jerin Jacob ; Ola Liljedahl > ; Gavin Hu (Arm Technology China) > ; dev@dpdk.org; pbhagavatula@marvell.com; nd > ; jerinj@marvell.com; hemant.agrawal@nxp.com; > bruce.richardson@intel.com; Honnappa Nagarahalli > ; nd > Subject: RE: [dpdk-dev] [PATCH v2 2/3] config: add arm neoverse N1 SDP > configuration >=20 > >=20 > > > > 28/10/2019 04:24, Honnappa Nagarahalli: > > > > 23/10/2019 07:03, Jerin Jacob: > > > > > On Wed, Oct 23, 2019 at 2:37 AM Honnappa Nagarahalli > > > > > wrote: > > > > > > > > > On Thu, 2019-08-01 at 07:48 +0800, Gavin Hu wrote: > > > > > > > > > > Arm N1 SDP is an infrastructure segment development > > > > > > > > > > platform based on armv8.2-a Neoverse N1 CPU. For more > > > > > > > > > > information, refer > > > > to: > > > > > > > > > > https://community.arm.com/developer/tools-software/oss- > p > > > > > > > > > > latf > > > > > > > > > > orms/w > > > > > > > > > > / > > > > > > > > > > docs/440/neoverse-n1-sdp > > > > > > > > > > > > > > > > > > > > Signed-off-by: Gavin Hu > > > > > > > > > > Reviewed-by: Honnappa Nagarahalli > > > > > > > > > > > > > > > > > > > > Reviewed-by: Steve Capper > > > > > > > > > > --- > > > > > > > > > > +CONFIG_RTE_MACHINE=3D"neoversen1" > > > > > > > > > This should probably be "n1sdp" as this is the name of th= e > > > > > > > > > platform that matches the below configuration. > > > > > > > > A clear definition of RTE_MACHINE is required. Jerin? > > > > > > > > > > > > > > I think, In the existing scheme of things, RTE_MACHINE > > > > > > > defines, where to take the MACHINE_CFLAGS > > > > > > > mk/machine/xxxx/rte.vars.mk > > > > > > Ok, thank you > > > > > > > > > > > > > > > > > > > > Considering the fact that there will be a lot of reusable > > > > > > > IPs(for > > > > > > > CPU) from ARM for armv8, I think, it would make sense to > > > > > > > introduce RTE_MICRO_ARCH to avoid a lot of code duplications > > > > > > > and > > > > confusion. > > > > > > > > > > > > > > RTE_ARCH example: "x86" or "arm64= " > I see that there are already RTE_ARCH_X86, RTE_ARCH_ARM, > RTE_ARCH_ARM64, RTE_ARCH_PPC_64 etc. I believe they should be > sufficient. >=20 > > > > > > > RTE_MICRO_ARCH example: "a72" or "thunderx3" - > defines > > > > > > > mcpu and armv8 verion arch etc > Are you suggesting this just for Arm platforms? > My understanding is your intention was to clean up the > config/arm/meson.build file. >=20 > > > > > > > RTE_MACHINE example: "bluefield" or "th= underx3" > > > > > > > - defines, number of cores, NUMA or not? etc > > > > > > Looking at mk/machine/ directory, looks like RTE_MACHINE seems > > > > > > to be > > > > defining micro-architecture for Intel. For ex: hsw, nhm, wsm. I see > > > > the same for Arm as well. > > > > > > Are you suggesting that we use RTE_MICRO_ARCH to pick > mk/micro- > > > > arch/xxxx/rte.vars.mk? and RTE_MACHINE would pick > > > > mk/machine/xxxx/rte.vars.mk, but contain NUMA, #of cores etc? > > > > > > > > > > Yes for Make build. I think, it is deprecated soon, so we need a > > > > > similar solution for meson. > > > > > > > > Yes I would prefer we clean the mess in Meson, instead of talking > > > > about the makefile system. > > > > And honestly, N1 is not needed in the legacy makefile system. > > > Unfortunately, most of the guys I talk to are still on makefile. > > > > You need to help them to switch. > > Adding new targets in meson-only can be a good motivation :) > > > > > When is makefile system getting removed? > > > > It must be clearly decided and announced. > > The previous techboard discussions were about making makefile hardly > > usable during 2020, i.e. very soon. > > > > > > So focusing on config/arm/meson.build, I think RTE_MACHINE is > > > > defined only for API compatibility with makefile. > > > > However, I doubt this value is used by any application. > > > > I think we can try to remove RTE_MACHINE from meson builds in > DPDK > > > > 19.11, or use RTE_MACHINE as micro-arch (my preference). > > > 'MACHINE' means different things to different people, which is the ro= ot > > cause of this discussion. > > > 'MICRO-ARCH' has a very clear meaning. Do you see any problem going > > with MICRO-ARCH instead? > > > > Some applications may use RTE_MACHINE for this purpose. > > It is part of the API since the befinning of DPDK. > > I don't see a real motivation to break this API now. > The suggestions are not clear to me. The original suggestion was to > introduce RTE_MICRO_ARCH and contain all the micro-architecture related > compiler flags in that. > Now, the suggestion is to use RTE_MACHINE to contain micro-architecture > related compiler flags. Will it contain NUMA, number of cores as well (as > suggested earlier)? If yes, I do not see it changing anything. >=20 > I am not a meson expert. However, I looked at various meson.build files. = I > have few questions/concerns. > 1) Are these suggestions are for all the platforms? IMO, these need to be= the > same across all the architectures. > 2) I am looking at config/meson.build. Here RTE_MACHINE is defined to > indicate Architecture for Arm (armv7-a, aarchxx) and micro-architecture f= or > x86 (corei7?). Is the understanding correct? IMO, this should this have a > common meaning across all the platforms? > 3) If the changes are for all the platforms, is the risk high for 19.11 r= elease? > 4) The N1 config patch as such conforms to the current conventions. What = is > being asked here is an enhancement, is the understanding correct? >=20 We consider it is an enhancement to introduce the RTE_MICRO_ARCH and I unde= rstand it is a high risk and we did not agree here yet. I will submit v3 to change the configuration name from neoverse-n1 to n1sdp= , to address Honnappa's comment. /Gavin