From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C8B7A057B; Wed, 1 Apr 2020 10:27:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7BD041BDAC; Wed, 1 Apr 2020 10:27:52 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2045.outbound.protection.outlook.com [40.107.21.45]) by dpdk.org (Postfix) with ESMTP id 68C512C15 for ; Wed, 1 Apr 2020 10:27:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nfEw08VVgbD3oFxy8st1gjLqMH/j8fc7FkLd535qnaE=; b=n8r0l5BXH9yDlLGykV22aL7/2eOMPsn6mP3Sax+BKlMBluXh7VM7eph3COK9M5Hkt4LB569wcQZz/1uD2PyVS7kkAPwCOHkU2E1Hyin221Txu1kt0sljv7AsL9M1AcuYJLsCK4jk4rZT1N32qAuyWB8rdmgP/jkvDua2umqDsOM= Received: from AM0PR05CA0006.eurprd05.prod.outlook.com (2603:10a6:208:55::19) by AM0PR08MB3267.eurprd08.prod.outlook.com (2603:10a6:208:5e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18; Wed, 1 Apr 2020 08:27:49 +0000 Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:55:cafe::d) by AM0PR05CA0006.outlook.office365.com (2603:10a6:208:55::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Wed, 1 Apr 2020 08:27:49 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Wed, 1 Apr 2020 08:27:48 +0000 Received: ("Tessian outbound 1425309d4c0b:v50"); Wed, 01 Apr 2020 08:27:48 +0000 X-CR-MTA-TID: 64aa7808 Received: from 3fdba11fb78a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F83980D3-0E36-48BA-81C4-9188BD5CAFA9.1; Wed, 01 Apr 2020 08:27:43 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3fdba11fb78a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Apr 2020 08:27:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PBD4dE0h3GPImay6BZjRFyIElXagMDskEvYLZMmRzEDDXD7OcfOPqCG+DcWTeNAiU7Dm/ZeMGmbwtXFZwsvVOmPD5JhlhaWQh4abcZecGKWF0NQuMEuwV1M5L6/tZT3yVZ1tol1Zxu3fPwfjgu2pcVb8XNzcRHBSnaYg8IkZh6Zd5/IeXV1Vkeglxj5LV+Jd4rYfkiweKEURKUJ5yRnqfTt+K43M/wuPdeqRuWgS4GhUEumI2QqgvZMWIrXpZ1h1V9GKi8gw6enXkqnkChqq256ogm6kB5FYgQGPZuMt/N0+s0eXjBNCXa0Wr1y7fC1bIkWEentlwgFMR+Ef/TEWOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nfEw08VVgbD3oFxy8st1gjLqMH/j8fc7FkLd535qnaE=; b=SeuCeOwCoHsuXSS74LhjxLvNtzE94KRXkltq75uM2eCuh/c+PWMvBtRn/oG3h9Py/AtNU9syVdBYFhRT0889qo4u5UwdNWwNtjaX08qRhfWeyCxA7I9JM71qxigbUZAyT9PtDwlIfzKORILXahdAc1uTDpRuDC1NTAGkz4PjKfEQisIHWugUU9Bi4lLIe3I2xZmbSeelMXDA3yDNm6yfhlAOjBHyeV8IBoPx/FBghrwAxVvEz/IXxaUKDSRbaTqSwzEAUsMPtVtgQLrjTMRyPFcNe+izBno2B+jiG103CI/0Fc2EXjhICOCc0AG+WgnEae8eLU5sm2HSoPjum+H93w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nfEw08VVgbD3oFxy8st1gjLqMH/j8fc7FkLd535qnaE=; b=n8r0l5BXH9yDlLGykV22aL7/2eOMPsn6mP3Sax+BKlMBluXh7VM7eph3COK9M5Hkt4LB569wcQZz/1uD2PyVS7kkAPwCOHkU2E1Hyin221Txu1kt0sljv7AsL9M1AcuYJLsCK4jk4rZT1N32qAuyWB8rdmgP/jkvDua2umqDsOM= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (10.255.196.79) by VI1PR08MB3374.eurprd08.prod.outlook.com (20.177.60.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Wed, 1 Apr 2020 08:27:40 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::a0e2:2a9f:be7b:4b15]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::a0e2:2a9f:be7b:4b15%3]) with mapi id 15.20.2856.019; Wed, 1 Apr 2020 08:27:40 +0000 From: Gavin Hu To: "thomas@monjalon.net" , Joyce Kong CC: "stephen@networkplumber.org" , "david.marchand@redhat.com" , "mb@smartsharesystems.com" , "jerinj@marvell.com" , "bruce.richardson@intel.com" , "ravi1.kumar@amd.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , Honnappa Nagarahalli , Phil Yang , nd , "dev@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs Thread-Index: AQHV9fjDQIVqneGA9UyvXJPk6tDlY6hjbXwAgACh/AA= Date: Wed, 1 Apr 2020 08:27:40 +0000 Message-ID: References: <20200309095410.28983-1-joyce.kong@arm.com> <20200309095410.28983-2-joyce.kong@arm.com> <1650352.esFFXGZ24q@xps> In-Reply-To: <1650352.esFFXGZ24q@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: ac7c35b9-f705-4a83-92e7-2e0efc1f6d6b.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [221.239.170.106] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0f3d65a4-afd2-49f8-baa4-08d7d6168ff9 x-ms-traffictypediagnostic: VI1PR08MB3374:|VI1PR08MB3374:|AM0PR08MB3267: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; x-forefront-prvs: 03607C04F0 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB5376.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(6636002)(66946007)(33656002)(71200400001)(7416002)(478600001)(26005)(7696005)(66556008)(316002)(55016002)(76116006)(86362001)(54906003)(8936002)(110136005)(2906002)(9686003)(8676002)(81156014)(5660300002)(52536014)(64756008)(81166006)(6506007)(4326008)(186003)(66446008)(53546011)(66476007); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5pl/9pIZyhrpAowXIdlLIA5nNPIeOUVTAnpDcLsI34R42Tnau7wdWnOmLbxyWrh55109OJ0Ybph9t0hG+wysPz6VJB5MvyajYEgUtVsEVfb9MWN0lTMTtyM2RzpEfN9daGsPZkjFJUvctfEBqpnAfohdh9Hpxmw6EZYUTws35F51gZfpzROsoP1npNiUxE92iFxrOFban7JTHDnKvIqsjBT19V2Ev110SysYTtPdcqLT5ftLzXYdrJSfedlWDVDSIkCiaNLsxufYTL8iZKgwTeUssBpmsC5vb9vDw1mlvjDqt/ltOK6Gr5nQejmxsQoNyKAEkmxuhKGIH/ViR3Kd32ZXKEzxVYtihmPpLXnvo4QivvxKrakbwheNSUqL86oSFRzgkozxKeX4vJ9gEdNQG0Ne7vbO0t81aC+V0K7nUgJcdcpa6j2OfTqIl6jfgAtP x-ms-exchange-antispam-messagedata: WR4P8CakHNzjWQwKOo7jfxfh6EVWBdZR6XvcGrRMG9KlR0e7EWE/AY21y5PXy1VKXKhMsvznc+TMCUDwgSrewtQ4peEfVdiSaZM+Rm8HjPVrZi5j3NiobA8xKJ5rM4ui6y3fjU6konfRowigaOcdmg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3374 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(346002)(376002)(46966005)(26826003)(186003)(81156014)(356004)(53546011)(55016002)(52536014)(4326008)(86362001)(9686003)(5660300002)(478600001)(336012)(2906002)(70206006)(70586007)(7696005)(26005)(47076004)(8676002)(82740400003)(33656002)(6506007)(36906005)(316002)(8936002)(6636002)(81166006)(54906003)(110136005); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 225b5979-41cb-4cbe-d235-08d7d6168ad0 X-Forefront-PRVS: 03607C04F0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qKpk29hLe1Mp85zYS/z7i3cQjmoGTssHfJfWCi1DDoy0rqKrCdatKGzDjoF5jjQKazzLqwO0OThl/mdgiF2hrjhktRk5bA00p6uk6g+uw5wEQ8m93MLVI1k/dDRceHMgNe6gMUSCZCc/ADKp/bZVtBI6Y0Y7JdP3BpraBu5fwaYEwdFRvCd6gHpXMIthSWCUvf+NJGGXiW2SYcIK+BhyArSfa/OkUHi7tOiLIorTWLqlPBHrIoDd3d7rpOa8yxNVKny4VSVKvAqrYcUx309EGWk3zOxNTJa67kKkG+x+Q5YPUftrRzy1TXDy0yhFCTwXqIN9TyPaJO3J21aF3eSinlkLjNnuhs6zrvO/7uyIqMtoHu1tNFckZdgp0CgF7gfESo/Ni75rdn1pkJRYXP/IOE6zdDS6SE3g/b8dXpLjTnWG/+RK6uOx5OlmdzjiBH2mTEQOwsUwh2dDsHZOk1vaGNA/HdF7KtiytaQnfQm5rELlvq89G3FRtmBw9mQY8aJm X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2020 08:27:48.8316 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f3d65a4-afd2-49f8-baa4-08d7d6168ff9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3267 Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, April 1, 2020 6:36 AM > To: Joyce Kong > Cc: stephen@networkplumber.org; david.marchand@redhat.com; > mb@smartsharesystems.com; jerinj@marvell.com; > bruce.richardson@intel.com; ravi1.kumar@amd.com; rmody@marvell.com; > shshaikh@marvell.com; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Honnappa > Nagarahalli ; Phil Yang > ; Gavin Hu ; nd > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of P= MD > bit operation APIs >=20 > Hi, >=20 > 09/03/2020 10:54, Joyce Kong: > > Bitwise operation APIs are defined and used in a lot of PMDs, > > which caused a huge code duplication. >=20 > Statistics of the series: 653 insertions(+), 326 deletions(-) > I would not say it is a huge duplication. We did not include all PMDs, just a few for piloting and seeking opinions. It is a huge duplication when counting all the PMDs. >=20 > > To reduce duplication, > > this patch consolidates them into a common API family. > [...] > > +PMD Bitops > > +M: Joyce Kong > > +F: lib/librte_eal/common/include/rte_pmd_bitops.h >=20 > Why is it called PMD bitops and not simply bitops? The scope of these APIs are decreased to PMD use only, for libraries/applic= ations, it is recommended to use C11 directly as there are complications of= more ordering models involved.=20 >=20