From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 192B8A0559; Tue, 17 Mar 2020 08:59:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D61D21BE51; Tue, 17 Mar 2020 08:59:07 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40066.outbound.protection.outlook.com [40.107.4.66]) by dpdk.org (Postfix) with ESMTP id 701BC292D for ; Tue, 17 Mar 2020 08:59:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8jWdI9xW2n3v/mcfUHCqxDirXJKAcHkbehJD55RI7nE=; b=pf4wMSnvp+Nkw9wQa/yHXfgZ+awC+CazDHmKHSrPx0xCyeIHYORSHtsrwasZw6rQB+icMsYn40kjNk2GnEYda/iTrMpA99T6jysTdwgwLNoTpJvGZXeWxqb+fvv8F7o+Z85MxXyu1sb5EWzmOyNrrvWPKHHTyYzkP1jh+SMH5Wc= Received: from AM5PR0502CA0007.eurprd05.prod.outlook.com (2603:10a6:203:91::17) by AM6PR08MB3990.eurprd08.prod.outlook.com (2603:10a6:20b:a3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.16; Tue, 17 Mar 2020 07:59:05 +0000 Received: from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:91:cafe::c2) by AM5PR0502CA0007.outlook.office365.com (2603:10a6:203:91::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.16 via Frontend Transport; Tue, 17 Mar 2020 07:59:05 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.13 via Frontend Transport; Tue, 17 Mar 2020 07:59:05 +0000 Received: ("Tessian outbound 1f9bda537fdc:v42"); Tue, 17 Mar 2020 07:59:04 +0000 X-CR-MTA-TID: 64aa7808 Received: from 04ef6bc5364d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E61A08F7-9B8A-4731-8593-C53ECCC4A767.1; Tue, 17 Mar 2020 07:58:59 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 04ef6bc5364d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 Mar 2020 07:58:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QFJXsTRstNB9sdSXskHZt209xzlhbehqqzyB9m4VEPPpwPpsGYf3vm9moLd1ifoXycKNM30XlTxwvroTGBqmA/ONmkPoMHw2fRSwTFWX3DrlKkzdV72NWpi9xRjAGdZYsT+GjKYS3lhvAv7n4gpGs0M48xgIMPMMuRKdT7nW26pVUO1zH04E7AkO7rHS5ziKplnwY2CPPhvTh9cZ+c4u7UOfcaQfgFa6Js+dw0eoVebMjPLzuNDAFTUBk1HABkbTNz4N04Z4uuyORT7ueuBfe50bDJ6URSrvPrg78GRdGRvv+JAISy9/x9G40FhDyutSGNRc5+Gc+qDuYt1RwgF6Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8jWdI9xW2n3v/mcfUHCqxDirXJKAcHkbehJD55RI7nE=; b=KgbHrQqhdbLs5yugp8In0JR+ejyWtltk/N8TG2Ko4DunL35fJpK1toETHr0CvTeYOtuehTbaWVbl5IG5EJsmUlvhSF8hvWAboyUhmxp3bkx+l6P1E4+aiT+PcIwP5tdVWUNklNJeccpeIHnt3I6dwaLA1NBr2VAmMmzCGq3lxlhguHiY9XZ8bqSNnuj1MkDZoGPIRjeczEx3fWYIEKyHk4WA3b9UwLWvsD4PWU4SExsz2IKQr1zWS+9E+VdHLGMnULPGxbJOXcVuq8PWE7qriFM+aqj8dv5ZbAncxSTs+edg2jcyQfh1bdbSJGIy5PquC8rqd4lUUKvYHywHfP0m9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8jWdI9xW2n3v/mcfUHCqxDirXJKAcHkbehJD55RI7nE=; b=pf4wMSnvp+Nkw9wQa/yHXfgZ+awC+CazDHmKHSrPx0xCyeIHYORSHtsrwasZw6rQB+icMsYn40kjNk2GnEYda/iTrMpA99T6jysTdwgwLNoTpJvGZXeWxqb+fvv8F7o+Z85MxXyu1sb5EWzmOyNrrvWPKHHTyYzkP1jh+SMH5Wc= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (10.255.196.79) by VI1PR08MB2909.eurprd08.prod.outlook.com (10.170.239.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.14; Tue, 17 Mar 2020 07:58:57 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::a0e2:2a9f:be7b:4b15]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::a0e2:2a9f:be7b:4b15%3]) with mapi id 15.20.2814.021; Tue, 17 Mar 2020 07:58:57 +0000 From: Gavin Hu To: "Chauskin, Igor" , "dev@dpdk.org" CC: nd , "david.marchand@redhat.com" , "thomas@monjalon.net" , "mk@semihalf.com" , "Tzalik, Guy" , "Schmeilin, Evgeny" , "mw@semihalf.com" , Honnappa Nagarahalli , Ruifeng Wang , Phil Yang , Joyce Kong , "Bshara, Saeed" , "Matushevsky, Alexander" , Bruce Richardson , nd Thread-Topic: [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes Thread-Index: AQHV+3YoBygG9l9U6EWVq6l5PsWv0ahMa7gw Date: Tue, 17 Mar 2020 07:58:57 +0000 Message-ID: References: <20200313091835.58039-1-gavin.hu@arm.com> <10e90cbc7bbe4d84979dabcb0fbe0c41@EX13D12EUA003.ant.amazon.com> In-Reply-To: <10e90cbc7bbe4d84979dabcb0fbe0c41@EX13D12EUA003.ant.amazon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 71ea08f6-4833-4670-8179-c0f623105a04.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4ce70134-a6b8-4d3c-8303-08d7ca49104b x-ms-traffictypediagnostic: VI1PR08MB2909:|VI1PR08MB2909:|AM6PR08MB3990: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; x-forefront-prvs: 0345CFD558 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(199004)(316002)(26005)(478600001)(81166006)(6506007)(81156014)(53546011)(55236004)(8676002)(8936002)(71200400001)(7696005)(86362001)(186003)(55016002)(7416002)(33656002)(52536014)(110136005)(66946007)(76116006)(4326008)(64756008)(54906003)(5660300002)(9686003)(66476007)(66446008)(66556008)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB2909; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gEcrEIfhb3PIqWBAsVtMAyggTeswK5dbio6w6LFtbH/wEkTli11gMD5rvbVTsXhwtT//4VhDZRYKWc66QI36YZQ7RP44ECuJhW5L4wPSTjTR/CeYLtmyOM5DVicD4P+fCz7+fxF2Vi5rAfpSbIoIdfOh0Q40RgZVDfNBWlXGdV46R1JoiPb8LnltG2Gq45PAh+hIRjiqwc79LNAKLnYbEDwgLSuZ9RxzZCgYfVcWcEGbTh8ObkjBJHY2SpLec/gxQtLDWtqmYW4Le57PwulZDjKqNvE3m96UVZWmWQVEwsBLK4p4u/qk+CBt6hEX0RZa3oMXobFOI24PIx0re9XmQ18gphoJNfHMcrkQiS91iMbQzKUlIYKMDePgq2QDyKcFNRCQDBK1uG14WCCrkdnsMKZOkgKWqxNChSCw1+0rxRIgutOOF7aQoRXzVL3I9Ot8 x-ms-exchange-antispam-messagedata: 3O+1s2UNHlg+ddyKqkh+PrTYfmkFVo4GNibZ2IXGTndCvuJHQpo5taNa9bfbS8LG8O5ifbSemoezAFw27Pwp0cgHeUt0OoZ4Aj2ZJdIras6KAfvLDLIfsxf35gjFKZOdgIXPZnBOI8HIvTHikbbPyg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2909 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(346002)(376002)(136003)(199004)(46966005)(336012)(9686003)(36906005)(5660300002)(52536014)(70586007)(70206006)(2906002)(4326008)(478600001)(26826003)(8936002)(81156014)(81166006)(86362001)(33656002)(8676002)(47076004)(316002)(26005)(186003)(55016002)(7696005)(110136005)(53546011)(54906003)(356004)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3990; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Pass; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 66441aa1-93cb-4472-4253-08d7ca490b9b X-Forefront-PRVS: 0345CFD558 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n2CzVC0SJ5s7q1HZM4HUrmpNXl8fng9LPvAO6bORtnoSwqN1+erdn4W/urd0c2bO8rS4cWSjIqf085JdKK6AyS41Lighflmwd8XoKlRM63fW6rnx+m6cN+J/F0DpIZAAeNukyJsf1OvwjFuhOn/T1AhO1xaYfbcHyT307M3BpgPqazBVZs4j1sYXHlvGK+iYGUGr0QyelJ03DjyBcQhKrnpTG8f42AqNEP75jIIHZ5Rye5QFCcr8r6L0LXhM+EOb45IwSsUiEBj3Wfcw+zMQHuh8nDihtwgpydQ6h8l/0yuQtOvDVtccf9+aib3GFt3dTL5cgde8lPsGJcw5iMrDNzUZdU6yippuiL2FL0AeY9GyuSCBF0dedkduQecu4MIGTfhzNQB1yKGzQ5Oefm7cKvNhyS1gPrFf3ywVQYzs5QP/yQpMiNFAeHdDhbpY0qjipOVgftOAdW+uM3GohgF5+2iKiemPvFj5vQBLay9xB4qJGLiPXwrKaeQuYGlld7v7 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2020 07:59:05.0411 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ce70134-a6b8-4d3c-8303-08d7ca49104b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3990 Subject: Re: [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Igor, > -----Original Message----- > From: Chauskin, Igor > Sent: Monday, March 16, 2020 5:35 PM > To: Gavin Hu ; dev@dpdk.org > Cc: nd ; david.marchand@redhat.com; thomas@monjalon.net; > mk@semihalf.com; Tzalik, Guy ; Schmeilin, Evgeny > ; mw@semihalf.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; Phil Yang ; Joyce Kong > ; Bshara, Saeed ; > Matushevsky, Alexander > Subject: RE: [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixe= s >=20 > Hi Gavin, >=20 > Thank you for the contribution. > Please do not merge these changes (patches 0..7) till we (the ENA team) > properly review and ack/nack. > These changes can potentially provide performance improvement, yet we nee= d > to ensure they are applicable for all possible scenarios. Specifically, t= he > behavior on x86 platforms is likely to be different. > What testing have you done for these patches? Was x86 tested? As noted in the cover letter, these patches were not tested as we don't hav= e ENA NICs. We rely on you to do that, any concerns and comments welcome.=20 Yes, the behavior on x86 platforms is also different, Intel people are welc= ome to comment.=20 /Gavin >=20 > Thanks, > Igor >=20 > -----Original Message----- > From: Gavin Hu > Sent: Friday, March 13, 2020 11:18 AM > To: dev@dpdk.org > Cc: nd@arm.com; david.marchand@redhat.com; thomas@monjalon.net; > mk@semihalf.com; Tzalik, Guy ; Schmeilin, Evgeny > ; Chauskin, Igor ; > mw@semihalf.com; Honnappa.Nagarahalli@arm.com; > ruifeng.wang@arm.com; phil.yang@arm.com; joyce.kong@arm.com > Subject: [EXTERNAL][PATCH RFC v1 0/7] relax barriers for ENA PMD and smal= l > fixes >=20 > CAUTION: This email originated from outside of the organization. Do not c= lick > links or open attachments unless you can confirm the sender and know the > content is safe. >=20 >=20 >=20 > To ensure the stores to the host memory are observed by NIC HW before a > door bell ring to the NIC HW and the HW starts actions, for example, doin= g > DMA, a barrier is required on weak memory ordering platforms, like aarch6= 4. >=20 > However, unnecessarily too strong barriers like 'dsb' on aarch64 will dam= pen > performance. >=20 > In a typical doorbell use case, as NIC and CPU are in the outer sharable = domain, > a lighter weight 'dmb osh' barrier is sufficient. >=20 > The patch set relaxes the barriers in similar places and include one more= patch > for statistics logging with relaxed ordering and the other patch removing > duplicate memset. >=20 > Note this set is submitted for RFC as we don't have physical ENA NICs in = the lab > and the patch set was not verified nor benchmarked. >=20 > Gavin Hu (7): > net/ena: remove duplicate barrier > net/ena: relax the barrier for doorbell ring > net/ena: relax the rmb for DMA > net/ena: relax barrier for completion queue update > net/ena: relax the barrier for bounce buffer > net/ena: use c11 atomic for statistics > net/ena: remove duplicate memset >=20 > drivers/net/ena/base/ena_eth_com.c | 2 +- > drivers/net/ena/base/ena_eth_com.h | 6 ++-- > drivers/net/ena/base/ena_plat_dpdk.h | 2 +- > drivers/net/ena/ena_ethdev.c | 46 +++++++++++++++++----------- > drivers/net/ena/ena_ethdev.h | 8 ++--- > 5 files changed, 38 insertions(+), 26 deletions(-) >=20 > -- > 2.17.1