From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EF0DA04B5; Tue, 27 Oct 2020 17:16:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1FAEB5947; Tue, 27 Oct 2020 17:16:34 +0100 (CET) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 7BBFA378B for ; Tue, 27 Oct 2020 17:16:31 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id s22so1056082pga.9 for ; Tue, 27 Oct 2020 09:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cnhihw3OSHc44VSfAFRw3r/UiOKZ4PAIY6iU/aBZw9Y=; b=CPeEdw/R/k2e1TRDamN5IGWBdP4G/fue0bVhloPy3BMEEWOTPaijgW7IDEuIs0nzt4 lnK7fDMdkukRfUKqOH32rN6KmtSzxgfnysrkYGFbJLP/wlDwelSCyW6Hip2EhfG7xHwZ Ed25ztYPom+5qdTXoWN+SOWHRwBUvgxuv2TvopnABO8FoFoahIHMyIxNeISg58NWb+/r OlTXeZt7zdNMoO5RtDnXymQEpnU3yeNPpBFpO00fjt6x3YkVblwO3SMh0tU+lb4wF8Xp P825NlM8ft7R+ARQ2lzDXxSwKyhgENk5DwwSaRhDnABlbtMvZQWnceLs7zS4UJJgVeK/ FN7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cnhihw3OSHc44VSfAFRw3r/UiOKZ4PAIY6iU/aBZw9Y=; b=tfVrOCGx0kfI1S3eUKNXCmQbh1xFBn3vdc8xy3UqBsLtaoC3xQQMYiFilPs5XIxW0v xcxJ5zB1v+l72Y+efWP6rJKP+mfMVHAnPQ9a8I1rNfxdrmRVcwTSZu43NfjZtmnA6ksx ncvsyEz5+Otypwt7gj3c/CO30JH/UlV9cv97UTCnmO2k8UtDA/4DThpH7PN9HAjB/zy6 DdYJD9IJx0vc4dcZsEXp9lpVKLggLRTuym5vmMaYOcvsk04RO5KQ/VYx193qyr9cdYwt 51ft1lfsLskXsaRqi6lERjqLYaZvtb9z90lDsHt6usS8CfaiOkj6Xt0tcNhKBIAslBcD lzRg== X-Gm-Message-State: AOAM531c6uUKy4ka2lX+PC5N4uHnoVizH+qgIzUgg6eYOXD2n1AO1Ydq 5vHz+OE27OJizIAYpDoDziY= X-Google-Smtp-Source: ABdhPJztJ+aMkzeHjkEq73FTrDo+bjtacziOjyzP+I6N+rvE1uZKUw0Lp+R1N7z0NGZHEnTShUmzWw== X-Received: by 2002:a62:2b52:0:b029:164:ea4:2d13 with SMTP id r79-20020a622b520000b02901640ea42d13mr3016647pfr.9.1603815389470; Tue, 27 Oct 2020 09:16:29 -0700 (PDT) Received: from gmail.com ([1.6.215.26]) by smtp.gmail.com with ESMTPSA id n12sm2576290pjt.16.2020.10.27.09.16.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2020 09:16:28 -0700 (PDT) Date: Tue, 27 Oct 2020 21:46:23 +0530 From: Nithin Dabilpuram To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com, Pavan Nikhilesh Message-ID: References: <20201026052105.1561859-1-thomas@monjalon.net> <3912863.aCUjeiqxCm@thomas> <6053263.1sEcI2TILj@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6053263.1sEcI2TILj@thomas> Subject: Re: [dpdk-dev] [PATCH v2 04/15] node: switch IPv4 metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 27, 2020 at 04:57:16PM +0100, Thomas Monjalon wrote: > 27/10/2020 16:33, Nithin Dabilpuram: > > On Tue, Oct 27, 2020 at 03:33:35PM +0100, Thomas Monjalon wrote: > > > 27/10/2020 15:23, Nithin Dabilpuram: > > > > On Mon, Oct 26, 2020 at 11:20:02PM +0100, Thomas Monjalon wrote: > > > > > The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. > > > > > It is moved to a dynamic field in order to allow removal of udata64. > > > > > > > > > > Signed-off-by: Thomas Monjalon > > > > > --- > > > > > --- a/lib/librte_node/ip4_lookup.c > > > > > +++ b/lib/librte_node/ip4_lookup.c > > > > > +int node_mbuf_priv1_dynfield_offset; > > > > > + > > > > > > > > This change doesn't work in secondary as it is process local memory. > > > > > > Yes that's an issue. > > > Can we copy the value when starting a secondary process? > > > > Currently there is no call back which will be called only in secondary. > > > > Can you move this value to node->ctx 8'th byte offset ? Node context is of size > > 16 bytes and should be sufficient. > > Currently first 8 B of node->ctx is used to store that socket's lpm pointer. > > Please would you be able to do such patch? Ack, will send a patch on this thread so that you can include in next version. > > >