From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2262A04DD; Wed, 28 Oct 2020 11:33:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B5B8C9A6; Wed, 28 Oct 2020 11:33:27 +0100 (CET) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id C0089C95E for ; Wed, 28 Oct 2020 11:33:24 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id e15so2672380pfh.6 for ; Wed, 28 Oct 2020 03:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UqAGhec0fr67xUxm9QOwhR1XuJu89P1a+wBdFv+VXhk=; b=sEyGOCcDPdUi5IX3CHYGhbm0u4ymui4JRv3SvYW2uKSaU920Aph5FAeETmW7tstw5u bF4iKoL/g1A5GFmmv+sHUKVdXkbaf+qRFc8SFMWZ+NabaDpqAlmGlktAeSZ55O8hlVaf j0GmmuyUp5NQJ40l0pKhfJJAPsCmUXaIayx8/0oNWqvr8hPhuMngcnJZKHDEmV921pvF T7zhQlbdFhTd5YOEg3Fj5NIwpM6aKpcrvvqB8Y6Hc9Ah2H4elfSnBh8QF0T1ROGy+u6H rh/d5cCcJzRTHC3C5E+qXeF2fSNJ3YeZ5pU3Li1GCpZ9Q+XsQXsc4UACDnDy6/N4QkPE y3cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UqAGhec0fr67xUxm9QOwhR1XuJu89P1a+wBdFv+VXhk=; b=VvORIjJmv2gYGVknWGBOIeuVEmY8maWpVFYnW4Dr5cBs65AGh091dJlmV6wChZmvNu NwPsqZyUlkpRq39rFkv7BJaQk+/b8rXG/ok4jXI2nLpRtWQQf2ox4fCNcY0UP8PlIKm8 R/m8qN0AVa+udfDbEeJIcEnAGQNmt6RShcPHAvXpvpzPMeNvsyUtUvvuTfX4NZ+TJrNM dUFKRM5vFICTVmb7rUsWxgB4ddSxdxdjJwM04tP1Ol8hdi0Tfu+Oe2xs2kJHBg1kvG7F KKyEzshYQJMCSg4UuPejkM8w3zx9SIVP6Ow6+9B1d6NgjaAeQtT/3z7Eiio0oXd4ll4A ll1g== X-Gm-Message-State: AOAM532C/8MZMwTHW9lhIuSqkqDvnJ2uDkEyjqTJbjqeZU8lzBpTP3BJ AW3VC5lDy5uMxTUT+96msuVatBuUv6/DznA4jR8= X-Google-Smtp-Source: ABdhPJxnAjigv42/UmD/WDr45pX3Nd3Q7ah6GZ9TTVt8exoObyvXP48R77WFTdLHqxCuqst+uc1ERA== X-Received: by 2002:aa7:9048:0:b029:152:883a:9a94 with SMTP id n8-20020aa790480000b0290152883a9a94mr6671633pfo.24.1603881204008; Wed, 28 Oct 2020 03:33:24 -0700 (PDT) Received: from gmail.com ([1.6.215.26]) by smtp.gmail.com with ESMTPSA id x23sm5399802pfc.47.2020.10.28.03.33.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2020 03:33:23 -0700 (PDT) Date: Wed, 28 Oct 2020 16:03:14 +0530 From: Nithin Dabilpuram To: Thomas Monjalon Cc: Pavan Nikhilesh , Jerin Jacob , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , kirankumark@marvell.com, dev@dpdk.org, david.marchand@redhat.com, olivier.matz@6wind.com Message-ID: References: <3705096.qAGAdPRMt2@thomas> <20201028093003.29564-1-ndabilpuram@marvell.com> <2153992.0QQoBXgI6F@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2153992.0QQoBXgI6F@thomas> Subject: Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 28, 2020 at 11:08:47AM +0100, Thomas Monjalon wrote: > 28/10/2020 10:30, Nithin Dabilpuram: > > From: Thomas Monjalon > > > > The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. > > It is moved to a dynamic field in order to allow removal of udata64. > > > > Signed-off-by: Thomas Monjalon > > Signed-off-by: Nithin Dabilpuram > [...] > > + IP4_LOOKUP_NODE_PRIV1_OFF(node->ctx) = node_mbuf_priv1_dynfield_offset; > > That's interesting. > You copy the offset in the node context for better performance. > How much is it better than with global offset variable? > How much it decreases compared to a static mbuf field? Moving it to node context was not for performance but for functionality as for graph's created in primary can be looked up in secondary and graph walk can be called on them. So having the dyn offset in global variable doesn't reflect in secondary. This is partially better than referring global offset variable directly in node_mbuf_priv1() as it is caching the dyn offset locally and passing it to node_mbuf_priv1() instead of loading from global variable for every mbuf. As mentioned earlier, this is done only because currently there is no mechanism to have a callback triggered in secondary alone where we can update the global variable. > > > >