From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF510A09F6; Fri, 18 Dec 2020 11:15:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56D68CA6E; Fri, 18 Dec 2020 11:15:35 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by dpdk.org (Postfix) with ESMTP id 74C47CA68 for ; Fri, 18 Dec 2020 11:15:33 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id x12so1150814plr.10 for ; Fri, 18 Dec 2020 02:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=USuTYC2+Ba1h7PcNG0E6a+FYjLNMi/cq8sTyKqXxlhw=; b=GCoR8CI2zON9nh76MyR5vRi9SAZRM22oTW1UT9Q5RPM05nJt+0se7+QzKHtB2PBSBw UoB7rvjybvQz3640fmrmbe0bxBanoQR9we4HbFezyCX9fmrB9ZPt1W7UEfc4vo8feGdV w7QNQ2ASM9Tej5Y/ja8Y/nbqyq5NCCSNEqQH+miF0pGxvcwO8kkEDf49GKUPv2nHCH+y daqQMNsYTTNr6hu0mmtOYKnPdYoiv/0yFAkISTI0ty+GmeMX/mKElIjQdrpJagc5BUTq gdcKjY90zMOZW0R8ftF4xRbmPNSZ+08o387J8JTiQHXs8J7wuC3/DGnyMKf76/UCsCqW VMsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=USuTYC2+Ba1h7PcNG0E6a+FYjLNMi/cq8sTyKqXxlhw=; b=O7o0fVjkdL6ybCcCkJl5m5iblBUWmIfTWcRGKAkWWlkO2+lXrZdVP+35kTx3oz5yqP +dEf5j1UCE/rzz5UyKbVGham4V1N8a+6ZJGzR+eSGU1H2rHF68YTKp8IiW226nusb1iA 4LNzu7qC+flMbi4Vz7eDd7n5V26a2qM7kyBVe90Gzp8YD2Aj250nitX2evsR4g5xqXDO vorINwlAm/JHewmniNlmpKMB9Q9esjUgx+sgp8/XY4CO+RWm9CYwAW3iLMaT9k12IDQD AoKW514ZQHvqU4RtbygkdoiP7spqgHn0UyxsNY/JJC63YaP+zgP/GEzZ6bXFPfR+O/hN YBzQ== X-Gm-Message-State: AOAM532uNiTaQtfELBktLjfrjmpBdhTzdN4Tcwq70aAn+znKxRKBdmEZ DrEiAydBNhapG4a7jjSi1PQ= X-Google-Smtp-Source: ABdhPJwBgGdospr0yDUn5w1ZcRmhTD+IcaoCRqrH/H21RSRhym7my163YMqkZWOHEs4uyea0ivII7Q== X-Received: by 2002:a17:90a:4689:: with SMTP id z9mr3662719pjf.87.1608286531424; Fri, 18 Dec 2020 02:15:31 -0800 (PST) Received: from gmail.com ([1.6.215.26]) by smtp.gmail.com with ESMTPSA id d8sm7141622pjv.3.2020.12.18.02.15.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Dec 2020 02:15:30 -0800 (PST) Date: Fri, 18 Dec 2020 15:45:12 +0530 From: Nithin Dabilpuram To: Steve Yang Cc: dev@dpdk.org, wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, asomalap@amd.com, rahul.lakkireddy@chelsio.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, jia.guo@intel.com, haiyue.wang@intel.com, g.singh@nxp.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, xavier.huwei@huawei.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, jingjing.wu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, rosen.xu@intel.com, sthotton@marvell.com, srinivasan@marvell.com, heinrich.kuhn@netronome.com, hkalra@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, rmody@marvell.com, shshaikh@marvell.com, andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com, thomas@monjalon.net, ferruh.yigit@intel.com, ivan.boule@6wind.com, konstantin.ananyev@intel.com, samuel.gauthier@6wind.com, david.marchand@6wind.com, shahafs@mellanox.com, stephen@networkplumber.org, maxime.coquelin@redhat.com, olivier.matz@6wind.com, lihuisong@huawei.com, shreyansh.jain@nxp.com, wei.dai@intel.com, fengchunsong@huawei.com, chenhao164@huawei.com, tangchengchang@hisilicon.com, helin.zhang@intel.com, yanglong.wu@intel.com, xiaolong.ye@intel.com, ting.xu@intel.com, xiaoyun.li@intel.com, dan.wei@intel.com, andy.pei@intel.com, vattunuru@marvell.com, skori@marvell.com, sony.chacko@qlogic.com, bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, rad@semihalf.com, slawomir.rosek@semihalf.com, kamil.rytarowski@caviumnetworks.com, wei.zhao1@intel.com, junyux.jiang@intel.com, kumaras@chelsio.com, girish.nandibasappa@amd.com, rolf.neugebauer@netronome.com, alejandro.lucero@netronome.com Message-ID: References: <20201209031628.29572-1-stevex.yang@intel.com> <20201217092312.27033-1-stevex.yang@intel.com> <20201217092312.27033-13-stevex.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201217092312.27033-13-stevex.yang@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 12/22] net/octeontx2: fix the jumbo frame flag condition for mtu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Dec 17, 2020 at 09:23:02AM +0000, Steve Yang wrote: > The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but > the Ether overhead is larger than 18 when it supports dual VLAN tags. > That will cause the jumbo flag rx offload is wrong when MTU size is > 'RTE_ETHER_MTU'. > > This fix will change the boundary condition with 'RTE_ETHER_MTU' and > overhead. > > Fixes: 0e2efd02db58 ("net/octeontx2: add MTU set operation") > > Signed-off-by: Steve Yang > --- > drivers/net/octeontx2/otx2_ethdev.h | 2 ++ > drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h > index 3b9871f4dc..99f0469d89 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.h > +++ b/drivers/net/octeontx2/otx2_ethdev.h > @@ -51,6 +51,8 @@ > /* ETH_HLEN+ETH_FCS+2*VLAN_HLEN */ > #define NIX_L2_OVERHEAD \ > (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + 8) > +#define NIX_L2_MAX_LEN \ > + (RTE_ETHER_MTU + NIX_L2_OVERHEAD) > > /* HW config of frame size doesn't include FCS */ > #define NIX_MAX_HW_FRS 9212 > diff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c b/drivers/net/octeontx2/otx2_ethdev_ops.c > index b36d37b9f7..963cc285ed 100644 > --- a/drivers/net/octeontx2/otx2_ethdev_ops.c > +++ b/drivers/net/octeontx2/otx2_ethdev_ops.c > @@ -58,7 +58,7 @@ otx2_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu) > if (rc) > return rc; > > - if (frame_size > RTE_ETHER_MAX_LEN) > + if (frame_size > NIX_L2_MAX_LEN) > dev->rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; > else > dev->rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME; > -- > 2.17.1 > Acked-by: Nithin Dabilpuram