From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB99D41D5F; Fri, 24 Feb 2023 10:25:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B28C840697; Fri, 24 Feb 2023 10:25:18 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D699040693 for ; Fri, 24 Feb 2023 10:25:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677230717; x=1708766717; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=FNoKS2CDZbraqJeVnzSE3ngSYDcA0bHMbWedMxcGBXo=; b=TyUr7kNq1XhqK7mt9F6DTZEZZUO2NxMBgfIsLThishr8EAX1H77QvYVv ZeJudHxwjyRg0XzSYvT8hMFSof3vNJVmj+fOWvNLHzzFGgeHY4PuvERlE Mu23MVjcGhffzGaEB+Bmf8GD0NThZG9VioYh9tGvN7DxXRC0z44gsiVMe +7GlqOVL3n/gO9tWi4LLLl4/V2fZYLozdkkTTVABnVvpXSWsw9ckTtm8A HWLv+ecw+flCq+3LMk4yKWo/zHMObjEz144Fcx/GHJTKPnG926yU1ij5y mlHdRevz43T1va7uZZZryI5SS3XS1etLY+UneZZilDqcZSHmuYAoFQiUs g==; X-IronPort-AV: E=McAfee;i="6500,9779,10630"; a="321634186" X-IronPort-AV: E=Sophos;i="5.97,324,1669104000"; d="scan'208";a="321634186" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2023 01:24:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10630"; a="761724311" X-IronPort-AV: E=Sophos;i="5.97,324,1669104000"; d="scan'208";a="761724311" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 24 Feb 2023 01:24:00 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 24 Feb 2023 01:24:00 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 24 Feb 2023 01:23:59 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 24 Feb 2023 01:23:59 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 24 Feb 2023 01:23:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PCS65UC++T0owGAulKgrdeQcNtBJcCorKE3zOiWsXMq3welTnsXZezimMv8lJKBYjHpCo4nK5r2aPUkqrsUh3/+QXbOo50mi+D3xx3Wxad2vodByHVr73egLXBmDKb+xceA0k9JkAfBRNRzS6iitAzHIexbGqKfndl8SIBZxGAS3cdNtpNXipxZehxSY1ziMF8Yv8ETn2ITJE/V8DrO3D5SE4D/+Fkfy0sqHyBXosddF4xKlvqvXYPyqKuEp5SQGRr/4DhQl6iGOzt0i7Yudem84iS2XVsLc6Ghz+dg7+L0OLuJSZ9c5XPI5B7HYeEOVpdc/YhswiK6xth6pFTWRFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZQ7uXfIAptuKwR6pzylpurDu9+EdE2rPQvrEVg0nRss=; b=NrU8h2LubGecF8SIaxOHGqYBrMgAuxXWL6rQZHiGXYvQcRt3ZInKyBD3bDcWJsIIMh9eDldsRkqpkHy86CwwEVRSPLzs+Tan9KQ1Gz20WA3zyfOUdC9Bur+V7d6TUvpBEB9ULoWdJ8ahclcz04CcedcA+NQr6WhBms3R3M7fDhA8DtuLIIALErwrXLvT+7LMZGc55RI85ulxoCEGS8s/1tWf4ujaIze2fHN6PguE+jZyvChMYdQ4BWr1Tzxb6OhyL7pZWZ66R+UCzym2TJ25ZUKRV+5FzVBEMjrP3RNIkLn5AxRrFoIw8xDPuavvRvm7pQTDO3fIP8iL8eoTcVqSqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB6951.namprd11.prod.outlook.com (2603:10b6:510:225::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Fri, 24 Feb 2023 09:23:51 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%6]) with mapi id 15.20.6134.019; Fri, 24 Feb 2023 09:23:50 +0000 Date: Fri, 24 Feb 2023 09:23:45 +0000 From: Bruce Richardson To: Ferruh Yigit CC: Tanzeel Ahmed , Subject: Re: Devtool test-meson-build.sh failed Message-ID: References: <730d5f3a-6ba2-272b-554d-39d909e6d41a@amd.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <730d5f3a-6ba2-272b-554d-39d909e6d41a@amd.com> X-ClientProxiedBy: LO4P123CA0312.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::11) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB6951:EE_ X-MS-Office365-Filtering-Correlation-Id: 43c3880d-79ae-4d2b-1d70-08db1648d712 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VZs+vdc0chiey1dVQSZOQzWkMsBOjyX1cSI5YkqRYzTNCu19yRMgqTUgaVVYKRS5HswT4uHfyAm4ykLRCokaUofhZ74m+a2XLV7LD5Y3wCeAdSZLGJy353Cu1rl6vuIL5vyuYRflI4xj7fbcA+/HpmiWJlzD0QuqgFWBpv+yMlwMrZr5ujShjtnPEHowyxc1hZR/Nc7qTxj5YhtD8uCoDaAWf3LG58PhAOGXI/XGSzwPybcJ9M/oV2qriQw6Bv2Z2wd+y23xnLewN/n1s/ID7zOV9WThyn6BDsl92PSBwqcsp/Q7VcwUMJWj9lmYu1vsYcxm0nZg4PM24FXSyCLtNKlKzmNFwy0vsgYubt3QR/UK8mTlYVFSiqxHrdZyUzpllg2DoGXm4OMYUnQ3xDxPIZmf9X4lyNYoIhdXYHhaoslRdUipKOKio4wqeWTIQMXAlnNFrm0cmKGnz+SKpdzlLDGLDudtzjdAn26CVjog/yihuT9HLqQxpv88hCfpbZw3DbeKzEws6Q74Cu5/pKcN4zKLxjlOByvW4wt1Sd0Y28fZofZHH2WXaj7n+7eHSbdMYvpIQrgyZpeTb5H4FjjiEhSTCWMXqKLPLzCEggfMo39BHhug1Lmg3omFpx9A5GxR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(366004)(136003)(396003)(346002)(376002)(451199018)(6506007)(83380400001)(6512007)(53546011)(26005)(6486002)(2906002)(186003)(478600001)(41300700001)(4326008)(66556008)(8676002)(66476007)(66946007)(6916009)(44832011)(86362001)(5660300002)(8936002)(38100700002)(82960400001)(316002)(6666004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEVicDNFcDlPcEREY0xCMjJWZDlmUWhyVmhScjZnUllUMFV3bUE4SEE5V0Fl?= =?utf-8?B?emZCQjQ5TkhqM3pGV0RiMXRTS0NQbTQxeDJYcUJOWDBhb3dTK1lua2p1M2E5?= =?utf-8?B?dENvOEZqb1dsT0twek5VSVV3QkEvRGJuK0pQZ0dPS0RNT0M1VFY0czNTVFlw?= =?utf-8?B?MEdmc1V4Q3FqN2didEtNYVUwWXU1cVJIZXhGcjR6MUp1QTk1cGlhYjd2YUdy?= =?utf-8?B?MlpmTkh1OGFHOGVsdDJJQTBQNmtJWFhiWjBUMFlZNUhENzBMWDAwK0M3ZnN6?= =?utf-8?B?eVkrN3BrVEtjRVhiUU90THN1eTYrT3RaQTFpY3BBcG5WMVEvN2JTQWRVbXdU?= =?utf-8?B?SXBCZjhkRSt1UUZLeGZuM1VZNmppY0ZpNGVYc0FJcGR1eldsSCtlRlpxdWkz?= =?utf-8?B?cTlNOTdxZUY3OU9CZTJsYXBaY1U3K3JIdUJ4Z1ZKZ0hvU0hITXlmdkx2eWIw?= =?utf-8?B?b1EyNWZKNlJhWXNabXl0dFhXMVhYQzdzVWhVcFVzUXZRVEhEYTRuOVlSd254?= =?utf-8?B?WE1Idjc3NCtLb2pJOTI0UEpUOWo3ZzhNTUZaZERZSjBHMkV3dmNIYVFEYk4y?= =?utf-8?B?S2wxalBHczlTaVRxcVEzbTRSR3ZzZytURjh4YjF2bFZuMzVUOU81RjNDczJs?= =?utf-8?B?QmNsa09SYWFTV1VRb1JlTS9nNFBaYnVkb01sOGdHVklNSUhvaHZyalMyaGpP?= =?utf-8?B?Nm1SdHczeENWZGRIQTU0UUdMNlVLSCtXeDRvMDBFTHJKZE5oM0lSeVZmWjJv?= =?utf-8?B?NlRnc0k0REhXOVRRaDRTN1hDOGhPRE5mUkt6R084ejd2ejFkd1NYRk1FTHR0?= =?utf-8?B?RkIyU3NyYXBoQktCZVN0MjUzZURHSHltR1pyaXVrQklwUDVLb3pjNUpHZ1d3?= =?utf-8?B?ZlVEeTFKaG81d3hjNUhqQmlHQUdxb3ZiZjh4K21RUWUzZDBHZVM5Umk2OVhs?= =?utf-8?B?eUoyOUxENXlCblEvU0RUZUdTdjRsUENWVWswRUVPdEpGLytoUVFKTEdUS2xT?= =?utf-8?B?WFh5RlpiVTUrakdObjFIN25oeHZGTXVhM1dmWFRZMjVuQjFWNzZla3VYc1JF?= =?utf-8?B?NVlpT2JLa3RhL0QvN3FtVE4rT3BjRS9xRjNRNTFxNkNidzBqOUNYUHpTV0wz?= =?utf-8?B?T1RaNVJpaXFJamRNWGxwUEJ5a0lhK2JiSjllekkrSllwRk4yZm5tMTFjUStj?= =?utf-8?B?QTZPWGhxTElxQXVJT1dxZ3JpZ29QQTdIR3ZxcEhhZVNLM2tnYlpFanRQeDJG?= =?utf-8?B?YllUbStQbko0MlYyc09HZXBwNjFQSGFGd2JjUEpJUXMrWXJodGpJRzJHd21C?= =?utf-8?B?SXFrbjZPTW9YdTUya1ZOQ1QyN21CWGZSQmQzanZBbFZ0c2lIRnZKOEdTNXFq?= =?utf-8?B?OTQ5Szd3Sjc4YkUzbDNCbW1ydFpkOUFzQk5aakphc0VDdWZtd0xkVStiMVcy?= =?utf-8?B?Z2VteGhCcnpzcEtucFhxMkFEdEFPZGpla1dHK2R0cFRoQTdzb2FIbXpIbG80?= =?utf-8?B?ZUd2U2oxejFPQ0RHZ2VJd1lPb3N5V0dUODRCVUlzVzRac3o0OVFwL0VQQVo3?= =?utf-8?B?NlQwb1RsMW1tcmNVWFpmT29HN29nSDB6QmNSajJjTTdwRjR1ZG5GMUFmMURB?= =?utf-8?B?bG1kSmRYeGhpT1BqNWgwZ2ZnN0s1Ykp3aEZUUW82NlZqN2VMYVcxYW5uREVz?= =?utf-8?B?VUJNemkyaExTWHN3T1dPSFAyOTkyWDNYU09xMW9FZ1dnWncrWmdPdVo1TGtK?= =?utf-8?B?VnNmL0RraHFYQ29JR2ZyRHcvTVFHOFI1ZFRueFhFQWp0RWR2dDBQUlZEaE1v?= =?utf-8?B?MVJlMWpVeHpBNXZaa3c3ZHU2eTVFb1dKVkhUTzMrMTUybm9UMmp2YzYyMmt1?= =?utf-8?B?RWNtbjBybUZvVTduRFhLbGNYQUR0azRBc1UraW1Zajd3RXE4amg3VHg5OVlv?= =?utf-8?B?WmxvL1RscHhKWGVCL3RVdVVMNVdKQWpwdFlnd3BRUGw5em1HZmhDNkdSVTRF?= =?utf-8?B?S2M1NTNtbURUcDRqOVV6dE5CbUpvYlkvWE8yeUFUenp6eG0vM2hvSFdkQjNr?= =?utf-8?B?Y0JqNVRVaHB2RnBiSkpLcUtSZHE1Vi9wSXBKSlhqdE5KTEVDeWFrZTl1L2U0?= =?utf-8?B?V3JxZHo3SU5TK2Nqb1ZLNjdPdXNMZnFoWVhxcFQ1VUxqSVkyWnZqR05pRWFl?= =?utf-8?B?Mnc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 43c3880d-79ae-4d2b-1d70-08db1648d712 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 09:23:50.7313 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1kcIXpBxqhvdMIJ1DuBX/opMw7pmWPOUXOZwdZ90UDHN22qLm2Z19SuETtibXcdAqHwWcOS0bmKSZ6tz/9k82siXDdZkrEy0PUrtpO7kTD4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6951 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 23, 2023 at 11:48:47PM +0000, Ferruh Yigit wrote: > On 2/23/2023 10:58 PM, Tanzeel Ahmed wrote: > > Hello, devs! > > I hope you all are doing well! > > > > I am currently working on a new patch version for "[PATCH v2] lib/net: > > add MPLS insert and strip functionality". However, I am facing an error > > when running the devtools/test-meson-build.sh script. The error is > > related to unused functions in rte_mpls.h that is causing warnings to be > > treated as errors, leading to the build failure. Following is the error > > snippet: > > > > *[50/3060] Compiling C object lib/librte_net.a.p/net_rte_net.c.o > > FAILED: lib/librte_net.a.p/net_rte_net.c.o > > gcc -Ilib/librte_net.a.p -Ilib -I../../lib -Ilib/net -I../../lib/net -I. > > -I../.. -Iconfig -I../../config -Ilib/eal/include > > -I../../lib/eal/include -Ilib/eal/linux/include > > -I../../lib/eal/linux/include -Ilib/eal/x86/include > > -I../../lib/eal/x86/include -Ilib/eal/common -I../../lib/eal/common > > -Ilib/eal -I../../lib/eal -Ilib/kvargs -I../../lib/kvargs -Ilib/metrics > > -I../../lib/metrics -Ilib/telemetry -I../../lib/telemetry -Ilib/mbuf > > -I../../lib/mbuf -Ilib/mempool -I../../lib/mempool -Ilib/ring > > -I../../lib/ring -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch > > -Wextra -Werror -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated > > -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations > > -Wmissing-prototypes -Wnested-externs -Wold-style-definition > > -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef > > -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC > > -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API > > -DCC_X86_64_SSE42_PCLMULQDQ_SUPPORT -DRTE_LOG_DEFAULT_LOGTYPE=lib.net > > -MD -MQ lib/librte_net.a.p/net_rte_net.c.o -MF > > lib/librte_net.a.p/net_rte_net.c.o.d -o > > lib/librte_net.a.p/net_rte_net.c.o -c ../../lib/net/rte_net.c > > In file included from ../../lib/net/rte_net.c:16:0: > > ../../lib/net/rte_mpls.h:61:1: error: ‘rte_mpls_push_over_l2’ defined > > but not used [-Werror=unused-function] > >  rte_mpls_push_over_l2(struct rte_mbuf **m, const struct rte_mpls_hdr *mp) > >  ^ > > cc1: all warnings being treated as errors > > [99/3060] Compiling C object lib/librte_vhost.a.p/vhost_virtio_net.c.o > > ninja: build stopped: subcommand failed. > > Can it be because 'rte_mpls_push_over_l2()' is defined in 'rte_mpls.h' > but it is not inline? (just a guess). > I believe this to be the cause. Static functions in a compilation unit must be used or else you get a warning. This does not apply to static inline functions, therefore all functions in headers must be static and inline to avoid compiler warnings. /Bruce